Received-SPF: pass (google.com: domain of linux-kernel+bounces-59564-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 9 Feb 2024 16:56:26 +0100
From: Joerg Roedel <joro@8bytes.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: suravee.suthikulpanit@amd.com, Vasant.Hegde@amd.com, will@kernel.org,
	robin.murphy@arm.com, iommu@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/amd: Mark interrupt as managed
Message-ID: <ZcZLKtFrbLax9lYP@8bytes.org>
References: <20240122233400.1802-1-mario.limonciello@amd.com>
 <de66890b-a42c-4d8b-8079-fcfff0007aeb@amd.com>
 <ZcXhMNZDOHstOP5k@8bytes.org>
 <23361410-3b56-42fb-aea8-3be53bfe5ae1@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <23361410-3b56-42fb-aea8-3be53bfe5ae1@amd.com>

On Fri, Feb 09, 2024 at 09:48:57AM -0600, Mario Limonciello wrote:
> Thanks!  This problem should go all the way to when MSI support was
> introduced (2.6.28):
> 
> a80dc3e0e0dc ("AMD IOMMU: add MSI interrupt support")

That makes most sense to me, also if it only uncovers with ...

> 
> But I don't think that's a correct fixes tag because
> irq_managed wasn't introduced until 3.19:
> 
> cffe0a2b5a34 ("x86, irq: Keep balance of IOAPIC pin reference count")

This one.

> But then I tried to go off the original introduction of the error message,
> but that's quite ancient.
> 
> 1da177e4c3f4 ("Linux-2.6.12-rc2")

That is not relevant, as the first AMD IOMMU driver was only merged for
2.6.27 :)

> Cc: stable@vger.kernel.org # 3.19+

That makes sense too.

Regards,

	Joerg