Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp1033799rdb; Fri, 9 Feb 2024 08:21:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IFr+9kVxmS7nK4YSGQUsz/G5vMbpU4/LPIUnulLlL0fgPVUo23a0IUm0l/NSswGLYROyg3M X-Received: by 2002:a0c:cd10:0:b0:68c:aac7:35ae with SMTP id b16-20020a0ccd10000000b0068caac735aemr2106528qvm.58.1707495691376; Fri, 09 Feb 2024 08:21:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707495691; cv=pass; d=google.com; s=arc-20160816; b=aU9HN47RE9qp78/O9J970LFYKR8Ri9jz6KoGejTfPeuWLit/7PktcLhMZNWSxmGGmz dCfUvA43cd0Ku87/Q+0h3aRj3NjPS0u8xXXqQpPg2xjPxaoBJ9Yk5yxndHlBqdhQOFb7 iVYUPasChGmmylBXRuLT1ihJJEUrV+QUyN4QbUe2WDLTP+rL2xSAAauIcPWvtbWIY4Ur +R3Q96y3A7lvjb01JcQv9ASasg/9ytSR5Lb5AhCsPJBc4rVUWUisuBae2tfQgL1r+bOY bWDkHzLPbrXWwVIXTC2ewnkIq1cCZqJnlS+cXvkWwiXmcbBHiYLoLG0waPA1O005q+jP /Vng== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=fEj/wlxe3qZWeo+suI5CAz2T52FPUWpKZIPaMq/89kk=; fh=fzHOCdL0vr6/dalKLo7tl7dUwmW8Fc4PDfp28CBsIfE=; b=YjLq9qGGJWlwKeZYMYEdwGH5TlrA/iRfoomXypiNy2EkBetAzypotmDu8v06JAqbTu FBRNJHz9pqE6CX/3pWLgTP+nIgEAMpBMQrwl8FaL32NNr1AbvaMm03FsPGQfeI+uQ+mZ k7s0uXq/NM95arhPFHhb+dzzFw8496JR1aLHtFk3lKjs/PxEZhngA+eF1xeftrPHcarg JsZK5OgDaW25fnPHxcOqmx/iwMALIgZiw8wJSnVTqA9I2ztOE/Mq5I7AlwSJBIQJNKZ+ 6d2YpJX0rnYviLqzA0DvKDE8uo6WyAVZG4w1EfOd7Uu+MqH3w8aY2mo4dZBf0uNkbbdA dbZA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GQXGsRDx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-59594-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59594-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCWIIhgCJ3nhqP9jlcL/Kin4iPT1emixsLHqq99guyHpQ+fJyn67vdOAl0CXAy/8dZauK6QzrxsWgQvdarRiJRChIl+/TJcWXBrrP1dUjQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id kj7-20020a056214528700b0068cd0e72118si2302856qvb.271.2024.02.09.08.21.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 08:21:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-59594-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GQXGsRDx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-59594-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59594-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 261CC1C22F9C for ; Fri, 9 Feb 2024 16:20:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B4A3E79DC0; Fri, 9 Feb 2024 16:20:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GQXGsRDx" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D24846BB2F; Fri, 9 Feb 2024 16:20:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707495647; cv=none; b=AtvBY4psqjr0D0Hg+7Z4bVEMm9brvNFmNYt4+bFhh2HzIgdKKYDzv9Cvr9DJFCseik9MmLxg/PUtQC61axRVEfcUNwwJqH71Jsh+WXb6Wrg1ShiPqWOVfjd0OhCbHDcz3CNguPeFrXgkFOHjoMjCh5lBXVLx4hVTKP8WGV7daK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707495647; c=relaxed/simple; bh=FUe8AyhhPCKSa/J30DiqA+BD7KZPrczbV8a2zpDNWO0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ldcr2EtzQfrYtt4UR71ezWVwu0gxuhT4QnaqQPAO202/bR3UW/3MAx8wttBWQPhXEWJ7k3o9qqaPvErONYPURCXmXX4GHB0uB9nuRiuNP7i8ZlWW+IusaQ7S/LkgHb7mILYDbBoKN0Tvjsgp3L/JIWkmcdJKMfQsR7aYekRzJAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GQXGsRDx; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05C6CC433C7; Fri, 9 Feb 2024 16:20:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707495647; bh=FUe8AyhhPCKSa/J30DiqA+BD7KZPrczbV8a2zpDNWO0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GQXGsRDxpBriaidC+OgfY6oXLfYbLCdwah49E0Kj05jtSJVm5RYtTSdqnHXMQCmYm nCDIq2ey1U9Mfp3oyw+dpJjsDkDbOS+uocsUf5NyfkfHH91hw4OzPhIKUr6iK3XeeR 4uoWjyLv0pWb4c6W0yCEnKNY03ylyvQjvFhQY4AAryNczpWORQPJpI1bHk59iyJeJI NDtl4XBYNjZkV4shJsWigfR8mcheewLnn63S5b1M1JOqsd2lK0Y9xGjqbiSPaMmvqE t1cJtB92UHSFex6cBPJUVISS5aZ3elPWYG1XyquA4P8S6rc8FE03tYGnbhaI4UIGof ns1UAF50nUF3g== Date: Fri, 9 Feb 2024 08:20:46 -0800 From: Jakub Kicinski To: James Chapman , tparkin@katalix.com Cc: Samuel Thibault , edumazet@google.com, gnault@redhat.com, davem@davemloft.net, pabeni@redhat.com, corbet@lwn.net, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3] PPPoL2TP: Add more code snippets Message-ID: <20240209082046.6a87f7f8@kernel.org> In-Reply-To: <20240203223513.f2nfgaamgffz6dno@begin> References: <20240203223513.f2nfgaamgffz6dno@begin> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 3 Feb 2024 23:35:13 +0100 Samuel Thibault wrote: > The existing documentation was not telling that one has to create a PPP > channel and a PPP interface to get PPPoL2TP data offloading working. > > Also, tunnel switching was not mentioned, so that people were thinking > it was not supported, while it actually is. > > Signed-off-by: Samuel Thibault James, Tom, looks good?