Received-SPF: pass (google.com: domain of linux-kernel+bounces-59599-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Feedback-ID: ibe194615:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-144-ge5821d614e-fm-20240125.002-ge5821d61
Precedence: bulk
MIME-Version: 1.0
Message-Id: <c4e6d61d-d836-4a79-a89d-141f92f6b41e@app.fastmail.com>
In-Reply-To: <dfb993c6-0e10-bc70-e8e9-a88651863a27@linux.intel.com>
References: <mpearson-lenovo@squebb.ca>
 <20240209152359.528919-1-mpearson-lenovo@squebb.ca>
 <dfb993c6-0e10-bc70-e8e9-a88651863a27@linux.intel.com>
Date: Fri, 09 Feb 2024 11:23:18 -0500
From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
 "platform-driver-x86@vger.kernel.org" <platform-driver-x86@vger.kernel.org>,
 LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: think-lmi: Fix password opcode ordering for
 workstations
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

Thanks Ilpo

On Fri, Feb 9, 2024, at 10:34 AM, Ilpo J=C3=A4rvinen wrote:
> On Fri, 9 Feb 2024, Mark Pearson wrote:
>
>> The Lenovo workstations require the password opcode to be run before
>> the attribute value is changed (if Admin password is enabled).
>>=20
>> Tested on some Thinkpads to confirm they are OK with this order too.
>>=20
>> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>
> Would a Fixes tag be appropriate here?

Hmmm - good point, though it has been "wrong" since it was originally im=
plemented (where we tested on Thinkpads).

I guess I could use the commit ID from when I originally implemented opc=
odes?
Fixes: 640a5fa ("platform/x86: think-lmi: Opcode support")

Do you want me to push a new version with this?

Thanks
Mark