Received-SPF: pass (google.com: domain of linux-kernel+bounces-59660-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Valentin Obst <kernel@valentinobst.de>
To: arnd@arndb.de
Cc: a.hindborg@samsung.com,
	akpm@linux-foundation.org,
	alex.gaynor@gmail.com,
	aliceryhl@google.com,
	arve@android.com,
	benno.lossin@proton.me,
	bjorn3_gh@protonmail.com,
	boqun.feng@gmail.com,
	brauner@kernel.org,
	cmllamas@google.com,
	gary@garyguo.net,
	gregkh@linuxfoundation.org,
	joel@joelfernandes.org,
	keescook@chromium.org,
	kernel@valentinobst.de,
	linux-kernel@vger.kernel.org,
	linux-mm@kvack.org,
	maco@android.com,
	ojeda@kernel.org,
	rust-for-linux@vger.kernel.org,
	surenb@google.com,
	tkjos@android.com,
	viro@zeniv.linux.org.uk,
	wedsonaf@gmail.com
Subject: Re: [PATCH v2 2/4] uaccess: always export _copy_[from|to]_user with CONFIG_RUST
Date: Fri,  9 Feb 2024 17:45:05 +0100
Message-ID: <20240209164505.2108-1-kernel@valentinobst.de>
In-Reply-To: <6eeba3ce-d66c-45e2-8c34-ad0109ec2ef0@app.fastmail.com>
References: <6eeba3ce-d66c-45e2-8c34-ad0109ec2ef0@app.fastmail.com>
Precedence: bulk
MIME-Version: 1.0
UI-OutboundReport: notjunk:1;M01:P0:WYS6P+aomTw=;XbzcNBCwdRbiLAarLUO+W6j+zRv
 YmUPnF8KuqGLTbCtueKO5+Eo46bePsEZ03rFMT638bJCtRHA9A4Krkn1OTjp3kwSr2jECqCFF
 w+ISolpyNiZdEk271ZbqKHPHDZUts02OBAshvuCzKAiX8+Tz1dxVWFfleqbLAV2WbGgiX0oY9
 niJ+03TbpNIe8y3CZ9r9RtIERZU+uoBiclYpMidzWMALBwCHIvPd6GFvFaO+x/TtJ/d1kyj5b
 h9OlliECsCYXadWNfvp+58EBRbELyL1I7xu/kZK1L70kJFbCksJ2HCRaTvcK/KmE+YpLErwce
 ZP9Erp2Dx1RYwm2TUJvQ5PjZMss4Ut7Ow9jXz4j10cPq/tLBok3nQdfHDEmT7gHI6viqsjcdd
 HEYZJxRisDW/F9CuBRFZdGhxNdyZHJO98UySZSlTJaovLr8FowyZ2s7hD1QE3FljjAZqs+dD5
 FbT9cmERg5UBVZBUhv6GgFhM29l2MNNWPEZwFD1fMROthjQhX6mYKWH374og19eci12ZIA9md
 mKh19gJmToG64bOYCToNhDp38mQuzEjBjd9qaXsn/GvY53O1Adam2zucdHg0uElljPXysj5Pf
 cGIuBkFw2MM3QLkG61eFT/vfB2OQoK0my1R6Dkkb2mqmzfwsnkpCpcO5vXEfuD+Xt9/S6+FjD
 c0tW3gRSltQtP6QBDImfHtql5ZJljlP8ImeLF/gnWj5wiRRdaJ0kaiiP9knYJSMolYsz8i9if
 NiMd+Aq4/na/Wi9+iuya/GspSunD4X9qjhlQUVhnLNYU4kkJ0v+mbQ=

>>> -#else
>>>  extern __must_check unsigned long
>>>  _copy_from_user(void *, const void __user *, unsigned long);
>>> -#endif
>>
>> This function is now unconditionally declared, but only defined if
>> `!defined(INLINE_COPY_FROM_USER) || defined(CONFIG_RUST)`, i.e., in the
>> common case where it is inlined and Rust is disabled this can lead to
>> link-time problems if someone decides to use it.
>
> Yes, that is intentional.
>
> If someone tries to use it when the declaration is not there,
> they just get a compile-time error, which is not all that
> different from a link-time error in practice.
>
> It's unlikely to make a difference here, but enclosing
> declarations in an #ifdef is annoying when you want to
> reference it from somewhere that is parsed by the compiler
> but not called without the respective options.
>
> The if(IS_ENABLED()) and PTR_IF() constructs in particular
> only work when the unused functions are still declared.

I see, thanks for the explanation.

    - Best Valentin

>
>        Arnd