Received-SPF: pass (google.com: domain of linux-kernel+bounces-59701-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <045d1d74-d369-40d7-ad34-2094afd2c47a@smile.fr>
Date: Fri, 9 Feb 2024 18:09:41 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-j721e-sk: fix PMIC interrupt
 number
To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, conor+dt@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, kristo@kernel.org,
 vigneshr@ti.com, nm@ti.com
Cc: Neha Malcom Francis <n-francis@ti.com>
References: <20240208212422.213693-1-romain.naour@smile.fr>
 <20240208212422.213693-2-romain.naour@smile.fr>
Content-Language: fr
From: Romain Naour <romain.naour@smile.fr>
In-Reply-To: <20240208212422.213693-2-romain.naour@smile.fr>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hello,

Le 08/02/2024 à 22:24, Romain Naour a écrit :
> The tps659413 node set WKUP_GPIO0_7 (G28) pin as input to be used as
> PMIC interrupt but uses 9 (WKUP_GPIO0_9) as "interrupts" property.
> 
> Replace 9 by 7 after checking in the board schematic [1].
> 
> [1] https://www.ti.com/tool/SK-TDA4VM
> 
> Fixes: b808cef0be46 ("arm64: dts: ti: k3-j721e-sk: Add TPS6594 family PMICs")
> Cc: Neha Malcom Francis <n-francis@ti.com>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> ---
>  arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> index 188dfe291a32..6a8866055f77 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> @@ -574,7 +574,7 @@ tps659413: pmic@48 {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pmic_irq_pins_default>;
>  		interrupt-parent = <&wkup_gpio0>;
> -		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
> +		interrupts = <7 IRQ_TYPE_EDGE_FALLING>;

We need to do this change for both tps659413 and tps659411 nodes for the
k3-j721e-sk board.

There is only one PMIC on k3-am69-sk.

I'll send a v2.

Best regards,
Romain


>  		gpio-controller;
>  		#gpio-cells = <2>;
>  		ti,primary-pmic;