Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp1072679rdb; Fri, 9 Feb 2024 09:24:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IENzKA5/iQeKmRehfrE22W4l5+DOXmCIjuVMgn6uUqnZln7gkYyJeUj/lWIde8lV/qI2vza X-Received: by 2002:a05:6a20:e99:b0:19e:9c83:da3f with SMTP id fk25-20020a056a200e9900b0019e9c83da3fmr1945834pzb.38.1707499460962; Fri, 09 Feb 2024 09:24:20 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707499460; cv=pass; d=google.com; s=arc-20160816; b=kVPMrSypXnKe6Pn33cOxNFYL0dXxvtdw6TZh9yswUC0LOFS1vg1iHYb2P8hkFEYSNn N5E/MmoMVDPS3G43O2GrAkErXy3yIwiEzuCPdE0T0hHsXojm7Vxzfpdizy4uXzMtTH4L CB9VKcoOSCqWP6ojXhBLtXCwLbZ7sMHsqz+PptRPKtrxGQCb1dj3vHvUQeHcp0ksfQNT sTUke4fnC82H72gD3ZjTneEmpEhTH9CouVVrmDEdIAAzRVCnnZrV3hdZ2z4Be1+LscsN ZlpGVZMrFVb1PAU9hazGaDG8MM6B213WpMdEiXHLB3gsz8rIl0t8EX0tGp4wn83pxet7 GBcg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=mCTkf7Uhk05htdUngOFotI43lknoNa0E5lP/jBopk84=; fh=BITGT2KiZrG7mbvOdh21xhZz+UDFPQOIUO9PhkPwgwg=; b=IxeS6ktVaJmzCn+LUD69jdO+vS70cwpbWadt0ZZ6OBlJrqm1ERoHDl7rPjU0I+VnmK KL4pgLXjn6Ai2lnzRD110a2UERbVhIz9J9V9O3lWcjquoxwqqBl6gdxTdor4MgclGtq/ FxmM3jIP539bSQStvs1sI7qsx5asR+H0fNWLs2mESFALOpIYYLZpGAwh2iXejK9dJUpA bKIMp4licGky+etBPwZEamZLMwQOX/z8dyTAR5Hs7SaBrnDHxvO1NT71OTkg8DAuoooF Zo4gEhSKxDXcAqwrDrfifrLJCchDlURHr6nGZhZsH3ExA92j/ScE/uvx/7eGPkOQbfL7 ZLIw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=LHznyKEG; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-59718-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59718-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch X-Forwarded-Encrypted: i=2; AJvYcCW+EzxcYHUNBkcXDowUThz7yz1QzT8cQd88QKOZ9o/QMVHT7LkBxJ+zPR64VPJ2MIzJ4qCaqsRN9T8aWGbX86K9eiOY+lKRHaXLF2II7w== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id x5-20020a17090a8a8500b0029701fbc930si1916544pjn.80.2024.02.09.09.24.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 09:24:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-59718-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=LHznyKEG; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-59718-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59718-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 687A7284D34 for ; Fri, 9 Feb 2024 17:19:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8B7707EF1B; Fri, 9 Feb 2024 17:19:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="LHznyKEG" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A4457BB02; Fri, 9 Feb 2024 17:19:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707499159; cv=none; b=bKuWRekmQVJ4pAlVMpNE5kbvuQoTUMblm/Fbx1SEjFjgeIWPMrxA7GJOtS48flIBqpVg4ONvAHYAQM8odYntbTFU7EI1sUavJueMSBWCM96HYCMSr/k+K5WLDgauoA8eJB8e407FtgAyArOUcW66+tqFPpqirGKfNTzJuq14hKg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707499159; c=relaxed/simple; bh=5chEcUoZy69N+Njxway//+D9Qq97cnHEhm7OTKP1+z4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VZRwM9QXziM55KyrVvGaxtBb3Pl3yfnYJcWt1AYTWc5WFxlXDGBbUw2uPNYj0W2yIkRqnLgIGuati1b3yPQWMX7Q446lc1vvFueuJYSdFlmJpIcmgOSLy5EnigIOZFyaoU+8SVHWh+YRoz1Y1nGxHMOXwO6cQuKc3lhH2msIuw0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=LHznyKEG; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=mCTkf7Uhk05htdUngOFotI43lknoNa0E5lP/jBopk84=; b=LHznyKEGKRt7UxP+B/ChINmYVD fZWLUuYEyPS5FhCXMRw/ImIQBWn503zlvLefjzwSgOG+QwOlAnW06F8p38bPX+ksKWjDOi9ORuN+3 LWP4qJOtgpJ10JjchxgOVW4PEHkw4jZY/a4xnYq7ss0K3AJ62uOBJUjcntUZYILHyJaA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rYUWo-007P7U-3P; Fri, 09 Feb 2024 18:19:06 +0100 Date: Fri, 9 Feb 2024 18:19:06 +0100 From: Andrew Lunn To: Jon Maxwell Cc: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next v2] intel: make module parameters readable in sys filesystem Message-ID: <135d4123-29f5-46dd-b06e-d5a66bd7f598@lunn.ch> References: <20240208221802.131087-1-jmaxwell37@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240208221802.131087-1-jmaxwell37@gmail.com> On Fri, Feb 09, 2024 at 09:18:02AM +1100, Jon Maxwell wrote: > v2: Remove the "debug" module parameter as per Andrew Lunns suggestion. > It's not really needed as ethtool msglvl can control that. It is normal to places comments like the above under the ---. In its current place, it will be part of the commit message. Under the --- it gets dropped when the patch is applied. Andrew --- pw-bot: cr