Received-SPF: pass (google.com: domain of linux-kernel+bounces-59744-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 9 Feb 2024 17:40:06 +0000
From: Mark Brown <broonie@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: Doug Anderson <dianders@chromium.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Dave Martin <Dave.Martin@arm.com>, Oleg Nesterov <oleg@redhat.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64/sve: Lower the maximum allocation for the SVE
 ptrace regset
Message-ID: <ZcZjdnchVblj4iP+@finisterre.sirena.org.uk>
References: <20240203-arm64-sve-ptrace-regset-size-v1-1-2c3ba1386b9e@kernel.org>
 <CAD=FV=XupbtO3_+P9=XO26vH_5nALSSLZZHZywPSR_hQsWxM0Q@mail.gmail.com>
 <20240209171155.GB25069@willie-the-truck>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="bt/WGUaP7bIvKfoi"
Content-Disposition: inline
In-Reply-To: <20240209171155.GB25069@willie-the-truck>


--bt/WGUaP7bIvKfoi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Feb 09, 2024 at 05:11:55PM +0000, Will Deacon wrote:

> I can pick this up as a short-term hack if it solves the problem for you,
> but I also saw that you posted:

> https://lore.kernel.org/r/20240205092626.v2.1.Id9ad163b60d21c9e56c2d686b0cc9083a8ba7924@changeid

> to fallback onto vmalloc() for large allocations.

> What's your preference for a fix?

We need the change kvzalloc() regardless since the ZA regset is just
over 64K which is on the big side, I do think that reducing the reported
regset size is useful as a fix independently since even with kvzalloc()
it's still pointless and rude to ask for such a big allocation and we
might reasonably be generating core files or dumping crashing processes
under memory pressure.

Dave was looking at sizing the regsets dynamically but there's enough
going on there that it's not great if people want to pick it up for
stable.

--bt/WGUaP7bIvKfoi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXGY3YACgkQJNaLcl1U
h9C/VAf/UtPKLS512P+gFBhbamgPYl2plAY+VsbTOvsLsMDb/VU58mlAJG7XYakP
9JJfei4c2vAm6+uN00bqGQmmYQtTG+NPH0ZgNbMOcwqVHL9xlJgeBWD7OSgnHZVk
VakcwgnF9mxv18L2+fMcKKe0a6GzXf7oPyfncbfoWMWqMcUDGNqkCHXs4psUuYav
/rYOmcuS90M5oMylI9b/gSDpiYv2+Xh15SwghD5IB09weilR5mdHurHgEkItVVi1
ocxqZKd/n+f9nkyjsJ/duyCp71hwrF0MERLMpIBMaNsiMH2IOnQEROC8Z9uhWfL1
cRf+Al21F8Myp+cKA5CZ9jybWPsWnw==
=2tur
-----END PGP SIGNATURE-----

--bt/WGUaP7bIvKfoi--