Received-SPF: pass (google.com: domain of linux-kernel+bounces-59721-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <66714dd6-b590-4ed9-acfd-22d2ef56ae3d@intel.com>
Date: Fri, 9 Feb 2024 09:20:02 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 2/5] selftests/resctrl: Add a helper for the
 non-contiguous test
Content-Language: en-US
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	<shuah@kernel.org>, <fenghua.yu@intel.com>
CC: <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>
References: <cover.1707487039.git.maciej.wieczor-retman@intel.com>
 <42246fb33f396267431e8b5432554647179acc27.1707487039.git.maciej.wieczor-retman@intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <42246fb33f396267431e8b5432554647179acc27.1707487039.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHZJeTN1a0RSYSs5WE9XRFB4U3BBc09VMU1vVE9PUmtwd2wzeldGZCtzSkxp?=
 =?utf-8?B?NnIzNVU1bUQ2d01zcW1hRlRMUW9TbjBLUmJnb2VnaWwxdjlLVjJmR3FWSW1r?=
 =?utf-8?B?UW1vZ045Yno5bWZKZk40TnVLOXhlRHNnR0pHZ0Rhb2pDMWVuV3Z1VE5KWndR?=
 =?utf-8?B?d2dKTmtpRTR4OENoRzBMSWhWWDRLelBSWVJKdENaSkh6TFlNSTVWZnozVy9w?=
 =?utf-8?B?Yk9lYTNJV0h4em9OTVoyd05KWXNEZzhlZHhVRTJWYTI0N1B4Y2JKUDN0UG04?=
 =?utf-8?B?WUJPYjA5RWtnMkFnWXhkYm01WG9tMHVtcnVRenlCWDFJV1NjNW5reEt6a0Ix?=
 =?utf-8?B?NVMweTlaVHNEMUR1VUl4Tnh1M1ExbS9BR2lDN2FJdmRKelFwSUdqWTJPR3VW?=
 =?utf-8?B?RHRWVnNUTC9pbVE0TVRDaFRxd1lBN3Q3UmQrZUlwK0ZpMEtUdzJpNUQ5ME9I?=
 =?utf-8?B?RWRpT0dVMnFQei8yS3R6dmRLeWVYdXlVRzQzVTlWZkx6d3VhYkJaR2s2eVZL?=
 =?utf-8?B?Y0R1U3RCaUNwNkwwRTM5Y2hyTmt4a0JadytBUXBoeHNMV0RzMnBxTVJCbUp1?=
 =?utf-8?B?ek9HR0ZPb1dPbGVXdDdDOHBramEzekgvTWMwTkpZK0dFdy9ZWFhwYjlwMzV2?=
 =?utf-8?B?b0N5SmQ3SWlGbVZnWTlvai9SVStQVEtoazFaeUNOdURnalBVSHpiTmdZTUlZ?=
 =?utf-8?B?Nk5sZTFNc3BRQXdmMWZKbGg1R3M3SjAyOWZndlFLb0k0YjdDM3BZZE52MG1Y?=
 =?utf-8?B?eVlMc3VXSWNXTDQvN0FIVlpJM3F4OTdnbUtvdG5INFIyWkpYMjlJREI0SzNZ?=
 =?utf-8?B?eHNsNWxLTGFkUmc4akg0RGIza00vbHpyNURGTUNvRXZiSU9MMVFuVk5CRkJL?=
 =?utf-8?B?cS8vZVlCT0pPVUs4QnVNeUh1cUFYWEF4VG85MFRHTkc4RXpONGpESVFaVStX?=
 =?utf-8?B?SU5DUzRvQ2JseUQxNjJlMlJWbHZzMHhCcHJRS05EOUsraDF0K2QvRWN3eGhF?=
 =?utf-8?B?ZG1OVDd0UGFIbEJOSHlNeXQzdnNrbk5CZWwzZ1c2Z1czSG9UalBWdWNBakI2?=
 =?utf-8?B?enV0cUlhME5CRXFwUnNKRHlieGx5VkZDRGVyNUozODMzUVdzTTZHYnlXNVZq?=
 =?utf-8?B?SkVENlBhSnZXTmpZUkg0RkFNdGc2bXNseEFVS2dCNHB0b0c3bk9WaFVHbVVy?=
 =?utf-8?B?aS82RjMyK2JpN01jWHYydkJkNldmN2VtZDdjRGVPZTR5NE1GdVMxSTZNeFU5?=
 =?utf-8?B?QmVIOStxVmZzY2MrZElGekpRaXIyQmRidnkwOFhoT3U4VUJFTkNyQ1NDUEov?=
 =?utf-8?B?aXFvaHpxbFlYM2VOQ3hVZlpodC9UUnBuRDQ4Z2RWZ085QXZueWNmNmVjaTBL?=
 =?utf-8?B?RzVkWmFqOUhob1B2YjlqUm1taTNOMWpLeW8vVG41aGM1WklDMm5wais1MmNC?=
 =?utf-8?B?dFlpRlVNc3BmUm96V2phb1lmQ2c5UGYxRHg5Wm1XeVlLMm1QM05kUjVqdHVu?=
 =?utf-8?B?WlArQzVCVlFqTU9WRktPQm9RNlpZZlRkbk9ndVNhdXYrYjVyTlBIS3lBQWFX?=
 =?utf-8?B?aDZPanhIdDFxQWg3WHRTUnU4M0dPZEUvYWVNU0Z4RXlBdnNHVWk3OVhWTjVq?=
 =?utf-8?B?RGF3c3dmMzgxVkU2K3RmbjJPd255WHFZV2hOUnJ2N1ZPRlUwanhHeVU5UnE0?=
 =?utf-8?B?NHpqY2tlTWExYlNhYnVsOW9GU3ZtRmR0NVZiYk1FYnQ0b1Z2dk5rKzN4UWx2?=
 =?utf-8?B?T3FwbzZvSEo4REV3K1hFR0t1QXN2V0xOQ0VoZlluTVdxTk9SZ1ZSRzJRaHlS?=
 =?utf-8?B?Skl3a2gzSWFtOVdKYkJEOHF6NDZCS2ZHUWRwTkFMOGdSaXUybWR6bDZrUDc0?=
 =?utf-8?B?NXFIQUJLYS9rMzZWbTRqQ3NBcy9rMlJvSVlyUHg3czk3bmdlb3JDSmxiajN1?=
 =?utf-8?B?bGNrUnBHTmoxM2gvYkFvMktDNDFhaXpGS1dpNmZjTVkwMW5zM21pVTczMFJ0?=
 =?utf-8?B?RHBId3NiM3BubEhRZVRZMjU4eE9BOXJVTXVCQVNtTEd3K2NrRkd5c3ZXMFp3?=
 =?utf-8?B?LzRMZlBhNlYya043YndFMm5la0RPb3ZyRWFoQkFSVC9leTJ3UVY5RjVtN0dN?=
 =?utf-8?B?M3NVSUNmY0dPWGdoQXpBVTd1MFUzUUVuZHNOaTRmeUVBR0Uzdm1uQ3ZaZ1VY?=
 =?utf-8?B?b0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c98762bd-8534-4af6-7888-08dc29935b5f
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 17:20:05.0881
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cuPl+5wGNo7jOfrZhGesz/iqQsUDb/BB9Cu8U/zpTKyhoBHVJyAchf9M3BZD/Bl7vKQ+9LHezvv5AQ7cPW+8jdq0hCzA/129Q1u36MGcNCE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8454
X-OriginatorOrg: intel.com

Hi Maciej,

On 2/9/2024 6:01 AM, Maciej Wieczor-Retman wrote:
> The CAT non-contiguous selftests have to read the file responsible for
> reporting support of non-contiguous CBMs in kernel (resctrl). Then the
> test compares if that information matches what is reported by CPUID
> output.
> 
> Add a generic helper function to read an unsigned number from
> /sys/fs/resctrl/info/<RESOURCE>/<FILE>.
> 
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette