Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp1093194rdb; Fri, 9 Feb 2024 10:01:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IFjULxnwNR68YJzjSZzGQam5VXy1kQAeWZw6mlZrcd4nczDuIchRarvFuQOC+o4KKF0Bibv X-Received: by 2002:a17:903:41ce:b0:1d9:f62b:2348 with SMTP id u14-20020a17090341ce00b001d9f62b2348mr2350048ple.10.1707501664157; Fri, 09 Feb 2024 10:01:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707501664; cv=pass; d=google.com; s=arc-20160816; b=YmnUJF2c+1eWB5MDeMWHn83QMI7MCN8xsc/xkEatKWwwQMTI4z8EXcWieG1tcNq+SX 6JHDZDsLsHU73ZBNaB4vbAsLXHlKtyA9zgD9JaWDVAdJNBiGdWJ+b+VDUXljZ3cRttcx zuuVLPC3+H6SIdHfStVclEgJM187QV4A+FIteqL+EozWilDMKqCBFOUBSQPBPVrwpx+q IMWQv2+sgfFk4pLF2QmsKzwMzrUP1sS1EVb14TA+PJVOi0/oxbRUGm89jjxcLmoDERqX iUbzVz8TDP501ukL6f98tmd0HxuRuT0mg8lrlGXFHiOUbRUaV5/Lj3ONv58oJC6ND+0z YhRQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:organization:references :in-reply-to:message-id:subject:cc:to:from:date:dkim-signature; bh=/ylu12OBeg+Qpx23OaATwkmagVevzhUpZSCqsCihw3M=; fh=qEZ2EqIhDaa2bslflPZk/fGgsJ0fHY7y1roRYsLnnaU=; b=w54GZ116DxQ1SLe/SNi5prekAUPb8uvnr7khRREIR2rtuR8nen5FBXOM7u+Dy5cu8g 7LtZAqhPfrh2I6IAHBvMp2Y2gwy1W3xWzcaItbULi8Sg8xa6IKo/sjIXAS5vQuTGpa43 3mjGS8OiS572YCJXDFTKk52Y7rvDh7Nuy0+5OsYBISD0e8Vd+ZhVL3LgV3kRoZYAeVv2 1tzeR/C53+F2dZ7RVVaTl/geGS94CcuAfXSyFljPmPHGCNibVgDFolXerOtB52sip8PI 8lYt0qvfKWBi54j8ITV1YfD6WhBPOpMXVXwFqX1vtSXnYCHEeRcdQohY6NjD6sB4A7pe Xfig==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fQe0EU8X; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-59757-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59757-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Forwarded-Encrypted: i=2; AJvYcCUTVZYor2TLO4ZaLXi8ng1Yhart61mmymtioTg+72oAckkhuwBcVmo+K0u1Z69H1Gq6wPrLb7q542k4KUhqieqr0NPoQiQGUgE1vM1IMQ== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id ma7-20020a170903094700b001d9607b682dsi2125128plb.96.2024.02.09.10.01.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 10:01:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-59757-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fQe0EU8X; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-59757-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59757-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C0449289C23 for ; Fri, 9 Feb 2024 18:01:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 162CD7F496; Fri, 9 Feb 2024 18:00:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fQe0EU8X" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92DD87BAF3 for ; Fri, 9 Feb 2024 18:00:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707501654; cv=none; b=dCFlmTC1XMgGYhgxxYX7kkcmhseuYUzbLOwPwcPGM6Ri4DQBHNnbBa5kMaCS9vNVfGxj85Sff4/RUXsWreihrvRYx6pQmXwxK/1JVjSM7T6c2AI77xxbhla2Y6BgHXhIDP1o8BQwk4LBTLz2nTyhx5XOTYcOoeT3bsDplHm2uUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707501654; c=relaxed/simple; bh=QRdZxK7Tu+cNFBLPSs5931EMt7+QiU8yFs+2dn34QJw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HL0t+oXjhwyz5Wpt8rp5n6I0sSWlc/O2H4R5GOOA+1S8o0dKB27AmK8e4tZBNeXaR5gQJC1fpZW0RX9+fCjI7w70DjiRM9vo9coQKguFHu5qh/J4QSlnVIKldy/bYZ/NmxUS+LdvpEJ3G6AQj2PktVmOaEPiddoAZD6+Gini4kU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fQe0EU8X; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707501651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/ylu12OBeg+Qpx23OaATwkmagVevzhUpZSCqsCihw3M=; b=fQe0EU8XAtwnpth/wEkKuSDOgwFlftdKDtm5W3znydJfOo6Q2YDoJniy2XZYQZGK4XS/te LKZKC0EXe2CIBhmdTwY0OvHL/xAAb5G6VrbHl3uF0JAM8JJOtk98B3tG4FiFgLv2yVO6kY SOpWyPoaxPCw+9RixMfmX9frAzJiggE= Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-Uhc-s4SwNXWL83wpW55tlw-1; Fri, 09 Feb 2024 13:00:50 -0500 X-MC-Unique: Uhc-s4SwNXWL83wpW55tlw-1 Received: by mail-il1-f197.google.com with SMTP id e9e14a558f8ab-363be7d5b20so11630205ab.3 for ; Fri, 09 Feb 2024 10:00:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707501649; x=1708106449; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/ylu12OBeg+Qpx23OaATwkmagVevzhUpZSCqsCihw3M=; b=bi76bmAiQ44lWMRxr8uNm4itTnvLTI0Ds8kLdBSpqdOBxMmyKnSbTMHTkw+MzpRBy/ ikFv0BR2IpHPPnSZkDZICMwRP3H96XRGDyQ4YqD/bVWoUby4TASgQRwDMceEzn2cmXYd ZuuEAO+GF8DmKEyPnu4tw/yzwMOJasESWXGhAC9j13o8hqQQvvsX7l0yXXXahtPZvJHR 07MVyjc38A0PWlfvbHvRJ+fLaTX24TgJ7fs9J3EBFY/6b1sDE7JL5JiYOCOi3IOIXBeF ZU9AoLQKg0/M+F1lUoZvjwjrtDCior7i4H3/y3ZLrDfFdrDwz9C7fb/6AU0iVMH4lxoW BcPw== X-Gm-Message-State: AOJu0Yxx1667oFzcV83eTI1m2Rg7J5Xwk/rOgqCijSthXxTZBsGg9499 eMzCNACNvgOzvZZo1iUJTReMWKUd60BnYiNY0vZ+4ONN9p4NJh8xue5heAOOkBonj2wmCxXnj7x 69B0LDiSkhaRxzD2+Qz8V6OZvmjA5fP+pWdHgU7C5Gyvxyw433KzWvg/25cKCfg== X-Received: by 2002:a92:d6c9:0:b0:363:dec8:fedd with SMTP id z9-20020a92d6c9000000b00363dec8feddmr2458767ilp.12.1707501649234; Fri, 09 Feb 2024 10:00:49 -0800 (PST) X-Received: by 2002:a92:d6c9:0:b0:363:dec8:fedd with SMTP id z9-20020a92d6c9000000b00363dec8feddmr2458749ilp.12.1707501648980; Fri, 09 Feb 2024 10:00:48 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUqTJ/AvYob1YGJIkPFFnbJSol62E5jK8DLlHBvkHgShAo6XP0ctsRuUoesVlHBjb6e4e0aleLFOqwvNApbP7bEkl55EiBjbpWCd+hpcV9lQoQnJ84HC9cx74g/N0/GjpjaNjz3uNAGUHah07yVF3y5X9//E65OBmk0/fTxkznB9KJC8x0A4z/XArB1QQvXa2r0QnAWci5TI3lS3Etr+3VRzwBNL8bNUbhX2l2vd5CHFykn+xLxcYY3srpcvzslAjWTfa/1R0jhGdGZfKOFp/cZku8AijaF+QWImVPUnlqkFT0ZvTa7YqV3xJmeR/n5z1SUBuPdiPPyI1Q6dqRjfkqQg2vAPURr+mKZvlbjAXD0r1rwntYjy+RZOh8cpcI5o0gH3Gpo6aT8J8P6WmIpmBJSE2iRxWHiQGIg9+V6QALh9JiT726dFcVG2t/S06EL/l8bP67i6WRGXZQGrFnp6CIbi64bgeyVkq4Go+U9pi6WEpQD9lLaGugXmvrjT1ndcwWM3UEhrw7TU6VCWJythFdKMhxVomh/tPHyeOn/1EdyKqnXInkRYsv8MlI77/qpepBaEMwDAHA8C288wh6wIi6aAlDaosIBqSfmo97WvVKfrmgLFShUYpqsjWM9NovkKVKW+kHVRLGZ7Shvlv6duNG0fpOpnmTuv3Gat/fFDmzfg6IvCAHESrzoJWxUecrejb0J58G15ceEp2mP9nTyvI2j711FTLKYdLyYWjRB33Fv77lPo6u56A45ZtK4QrFKCIYWXZJfzyKDqhzjoeevuoVYrZQTVCGMYJlxAVGQGpOiUdTGEjKMFEAs Received: from redhat.com ([38.15.36.11]) by smtp.gmail.com with ESMTPSA id z9-20020a023449000000b00473535d00absm108437jaz.16.2024.02.09.10.00.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 10:00:47 -0800 (PST) Date: Fri, 9 Feb 2024 11:00:44 -0700 From: Alex Williamson To: Jason Gunthorpe Cc: Ankit Agrawal , "Tian, Kevin" , Yishai Hadas , "mst@redhat.com" , "shameerali.kolothum.thodi@huawei.com" , "clg@redhat.com" , "oleksandr@natalenko.name" , "K V P, Satyanarayana" , "eric.auger@redhat.com" , "brett.creeley@amd.com" , "horms@kernel.org" , Rahul Rameshbabu , Aniket Agashe , Neo Jia , Kirti Wankhede , "Tarun Gupta (SW-GPU)" , Vikram Sethi , Andy Currid , Alistair Popple , John Hubbard , Dan Williams , "Anuj Aggarwal (SW-GPU)" , Matt Ochs , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" Subject: Re: [PATCH v17 3/3] vfio/nvgrace-gpu: Add vfio pci variant module for grace hopper Message-ID: <20240209110044.0cb6707d.alex.williamson@redhat.com> In-Reply-To: <20240209171903.GQ10476@nvidia.com> References: <20240205230123.18981-1-ankita@nvidia.com> <20240205230123.18981-4-ankita@nvidia.com> <20240209085531.73f25a98.alex.williamson@redhat.com> <20240209171903.GQ10476@nvidia.com> Organization: Red Hat Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 9 Feb 2024 13:19:03 -0400 Jason Gunthorpe wrote: > On Fri, Feb 09, 2024 at 08:55:31AM -0700, Alex Williamson wrote: > > I think Kevin's point is also relative to this latter scenario, in the > > L1 instance of the nvgrace-gpu driver the mmap of the usemem BAR is > > cachable, but in the L2 instance of the driver where we only use the > > vfio-pci-core ops nothing maintains that cachable mapping. Is that a > > problem? An uncached mapping on top of a cachable mapping is often > > prone to problems. > > On these CPUs the ARM architecture won't permit it, the L0 level > blocks uncachable using FWB and page table attributes. The VM, no > matter what it does, cannot make the cachable memory uncachable. Great, thanks, Alex