Received-SPF: pass (google.com: domain of linux-kernel+bounces-59779-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 9 Feb 2024 19:13:54 +0100
From: Thorsten Scherer <T.Scherer@eckelmann.de>
To: "Ricardo B. Marliere" <ricardo@marliere.net>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, 
	Pengutronix Kernel Team <kernel@pengutronix.de>, linux-kernel@vger.kernel.org, 
	Thorsten Scherer <T.Scherer@eckelmann.de>
Subject: Re: [PATCH v2] siox: make siox_bus_type const
Message-ID: <gixkaq442day5gcirj5rbcb4pbihlma2ruhrpqweyvzqx5rz3j@hpt5esbvvloj>
References: <20240204-bus_cleanup-siox-v2-1-3813a6a55dcc@marliere.net>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240204-bus_cleanup-siox-v2-1-3813a6a55dcc@marliere.net>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?FU0WJzmpbqS51dsvychP0Ez6AIRfgoalocrF+EhbOP7PHUVSIF2ev34Fvzok?=
 =?us-ascii?Q?MBXL5GZUG7wvpQKiJ5W+/PF2FrPlrvvlLmSxmjf7koh/gPlM3lapPZpQlSMG?=
 =?us-ascii?Q?0W2kldVHd5SYTxZMjMRSnvDBB0tEjEPP/uVtOrrM7+LqOglPy9IZCzZ4zdnt?=
 =?us-ascii?Q?X7V6N5pZLXIkuW8e87l2RaWlmoQ7FavcRO9x1YKdOgjdvjIpm57Cye+Y9v7m?=
 =?us-ascii?Q?iQ+rCRwBMvpTRL49EDn7f+3OWDXIsEhjpzNZ5f9lmBih9y2oFVmcd1/7Vqlb?=
 =?us-ascii?Q?1Kk3xG1cN+CqHdgiNk65z+klJIpZ4+TkKBldLrSvxzyiLeFCv+BrEiWSfbvn?=
 =?us-ascii?Q?TL46AeAN3w6dS0SwebT0Jng0G8idrDezEy8JXSWUfnh/FKSThP/8gwSXewsk?=
 =?us-ascii?Q?6VrV4QZ6yGvu8EZ12nyQGWOCHJ3x8pxGcJ9WyLtp9JhLsI7zK9vUXUHQQyyk?=
 =?us-ascii?Q?liPY1gxoksr0ZV2EV6xSR58xAzC3bRQ5XN9A+U/7BWJZI6vSBaSwo4Par8uj?=
 =?us-ascii?Q?bPt6vRY2iOX/WOGG8mSzkgl22Sb1/hh+29GhJtof3Z4VW5O3JDgzFt8ySr6Q?=
 =?us-ascii?Q?ERZByh8y8KsSpsULckFZnEGwAMcRswKF2rN9YG04LERGeS5Q5zAKbwsPn2yh?=
 =?us-ascii?Q?epMZIPE6Gt96rwAbLy4lwHdgRc1O1JAIY5RlZqGqnI2oYUDVwg8skFWBjUiV?=
 =?us-ascii?Q?0pgPP1ymJTVFfuQjtvd6zGUgDtuY7o4JoxphskWNuwXBG2Pb8pcEi0gouoao?=
 =?us-ascii?Q?NM1wHxPIXF6V+8NVzf9VlAw2/TfYcCek2wpnXOVIOFdukLBtUiCb8dQhpZ24?=
 =?us-ascii?Q?Orii2bCyR+OJusOaTpmvZmXzNnVi1s/RBHGdpQtRRiWC6MBZavP+WW4aCbS2?=
 =?us-ascii?Q?lTzhtWzBuc/AiMJIax9fUdwOnvdUfnFJHIi8NPpMl3h6qzCNbpKE3h1DEpo2?=
 =?us-ascii?Q?yc8zoBP/BMvpIAWhZgREt3ufuebSSexyu9h7F9aFViCE8Oih4Q4Nilaz85Dx?=
 =?us-ascii?Q?8OkawevKSk5XjVom4ENJ3yDasNHtcoGlvhPZytHjVlvT4tNxOZtRi4aOk+5M?=
 =?us-ascii?Q?k8QvvNdsiSsUsbOniDz2OCCod8wPehlh8mlptXzT5sjNdTFJsmuhCrVTvSd5?=
 =?us-ascii?Q?ymFmihFgvF+VZ5p4ujlEli+RPipotmdOg5+vSJqewSiekzjvdv5KUQAgTca8?=
 =?us-ascii?Q?IbLIbKFaAM6LBuYOhEkyZvjXD/gE1Fd5F9qCnO0UBQITore9NIzhX2u0LOZf?=
 =?us-ascii?Q?NmFAlUeOIOQ+kWLIKS/ZUPfWSV5qurpqxOKZ4gTktqvDD+UxEB4WfFsz2d6z?=
 =?us-ascii?Q?5CqWKR7TOGO+/doCH3g+NrDe+Fmgda0e9xEXKCWD1VOFXCNtyfazNzqcyx2u?=
 =?us-ascii?Q?O1C2M8/0ZgC4FwfOlbJTZ14n7i0QcKyAX3zAT6/f7ddKG+J3Hw8aTLnNzXVl?=
 =?us-ascii?Q?2Ke1es/QtwuDQWT5OAleciTgwPcHhFcYdrPeuOjtKVugoJJGqD9hW1fX9M44?=
 =?us-ascii?Q?8Taku+xXAxtZ5pQ0CVkzzFILMg2fpYDwZRfuxg3EjEwp0RzWeu5Fmyzcwlap?=
 =?us-ascii?Q?rolqWO7m6GKnr4SSdZrTMKraWd+yvxOhuSiDTqNDDdHUOo47lAmmQWev719t?=
 =?us-ascii?Q?nyuEnGRZ7daWHZ1SmQ88Y5jwiNjMyS03meXmuPtakDxf?=
X-OriginatorOrg: eckelmann.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a8d26e4-6ad3-4d7f-876b-08dc299ae0f1
X-MS-Exchange-CrossTenant-AuthSource: FR4P281MB3510.DEUP281.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 18:13:55.7111
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 62e24f58-823c-4d73-8ff2-db0a5f20156c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jyh8QJhI/tgzdkKA8Az5bxMWmu8MWguqCVgz8ACJ+ehqZEy1o+GGoOkQ78lUeoS3sAZl+Mq8pHFeixgSRKI10g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BE1P281MB1938

Hello,

On Sun, Feb 04, 2024 at 07:26:42PM -0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
> a const *"), the driver core can properly handle constant struct
> bus_type. Move the siox_bus_type variable to be a constant structure as
> well, placing it into read-only memory which can not be modified at
> runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Acked-by: Thorsten Scherer <t.scherer@eckelmann.de>

@Ricardo: Thank you!

@gregkh: Would you please pick up this patch?

> ---
> Changes in v2:
> - Fixed changelog: mentioned commit d492cc2573a0 instead of the word
>   "Now".
> - Link to v1: https://lore.kernel.org/r/20240204-bus_cleanup-siox-v1-1-2d12583d3a6c@marliere.net
> ---
>  drivers/siox/siox-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c
> index 561408583b2b..a1eda7bd76ed 100644
> --- a/drivers/siox/siox-core.c
> +++ b/drivers/siox/siox-core.c
> @@ -543,7 +543,7 @@ static void siox_shutdown(struct device *dev)
>  		sdriver->shutdown(sdevice);
>  }
>  
> -static struct bus_type siox_bus_type = {
> +static const struct bus_type siox_bus_type = {
>  	.name = "siox",
>  	.match = siox_match,
>  	.probe = siox_probe,
> 
> ---
> base-commit: 41b9fb381a486360b2daaec0c7480f8e3ff72bc7
> change-id: 20240204-bus_cleanup-siox-ccf8775bf069
> 
> Best regards,
> -- 
> Ricardo B. Marliere <ricardo@marliere.net>
> 

Best regards
Thorsten