Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp1116711rdb; Fri, 9 Feb 2024 10:42:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IEKFuvyeQCtutUNh5l9rlRio1iB6UaUj97f8uCUdjyUxsI3BoVS7mUlGQ3RwsqdL26QVXL3 X-Received: by 2002:aa7:d1c8:0:b0:560:ebd9:9c1f with SMTP id g8-20020aa7d1c8000000b00560ebd99c1fmr2012828edp.24.1707504138693; Fri, 09 Feb 2024 10:42:18 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707504138; cv=pass; d=google.com; s=arc-20160816; b=gswb3XTPg2JwlysP1/2ijfbgUwVoKnYYeFZN0eKsJ9MHqPtvsLhqKXyiLIKxaXQktu GvnPuJZ4HEmzXMtPInMi/K1bh3/fR6YmFLS2aOlkKzhIH/BH/YryfsjtekIjQ84zYfmK qxpnrLeyPyBcB1gFKqCPFxNjIkyTNzDrbxdPMU+Cl99YJJrHvnR9jJTt0itOS+nnBZDH S4B37qx1pgZ7sJpjINHc0rSRUWtpgOP1pn9qOhoUAXnBQGRV8ZB27Aa/FoOCKNsb3GMM ebhrSrVfkaSHo7gTyW2f8C0TgwkQPNGskbKHIlIXPBSryBlGZcdDNT5ZU22XTRSzTESQ jvvA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=jWYMZqp+284IUdOrq1kbsP8V/FUP3TNVMqsn4t0Z31Q=; fh=c+c2gMbZyiBLY+RzMGUU25icaRzXwf17QAvC5dbUk04=; b=PcitTxidAGPArY6fYaEYKx5bCiMr4yzBpDfbok0p4BFaUCwNTRA6Kv4Ycg1NRTt0Kr 1SnS1CZ//3fnOUi6AZpeVq6SW/XooY6gM51u0Pw+IrMOqbjVvUYwnHbOj0+80n6MHrt+ 6ORmeNd2Mevi0CyngRTayf9oG6U/nvfT70HXh0bPrliJXt7uQvsU8S05k3rXV25JgABo kJY2pDgbucm8eZxDJt3ME6ttckrTYsI5B5Jh/Z5rqeqHA8ZVXd0Y6g2MtRrC69FK6Ieu bFAAqoP4RXC9O/no9lh3BmSlT/kF2aAV0KXhmqGd08rreSCBjirlLN7bQYVD/c48m4Bn PiLA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ALal7hRT; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-59800-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59800-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCVdkmwgt7mj9zBCdc14vhOXDe8jaY2tL52TDqVacSd61Mcr0BLCVzkiE/yMAiJuJzAXWEOAPL1Wm1a4TJ3REdcmgidaRCeskZ0ZonVgnA== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id y3-20020a056402358300b00560fd7dda24si6238edc.53.2024.02.09.10.42.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 10:42:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-59800-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ALal7hRT; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-59800-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59800-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3B1961F287C7 for ; Fri, 9 Feb 2024 18:31:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5A05C80BF5; Fri, 9 Feb 2024 18:31:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ALal7hRT" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8295A8286E; Fri, 9 Feb 2024 18:31:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707503484; cv=none; b=T4awoPmwQhbzl7OGSrBhDpnXvAAqCFW6dAmvRAwPx4qa2zSzIwl7g7nk5z5O9anAjBWKAv4XalQQv8evdlPaf1/aSV+n6xHFNA7X+zp4EM/SEIjrYW2St6hNMMKgaF3267YWvh7rAGuEMmP0lB0/i1EKXKU1C3eXB9XTGtPTEpA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707503484; c=relaxed/simple; bh=yMevUDxLK0NwGJ8Z8pZ5Sin6BlhE8eNPdZ5e6aErPGA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=kguY2iOZ5pcYJoStUwe+7Tw+fBkrXyuOn8tTpsmVeAiP76gbnvkZ9qUNmMwi47cf40CAfgeFguDUV2oWla5W+kALKavtW6zwjn8v5v4mNKALkNdEuApemR/v8TeXXhY6LSc4VW90IJ7Muhpp9HyvFJVzNpS1nUX1Y4G67ti7azc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ALal7hRT; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E320C433C7; Fri, 9 Feb 2024 18:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707503484; bh=yMevUDxLK0NwGJ8Z8pZ5Sin6BlhE8eNPdZ5e6aErPGA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ALal7hRT51AXkooxAQe7tbFSCnXqsv1P8A49tGycGrPr0G/Nt/XfREhi1LEjzRdKP iYdxGyAvYp+JTAvxy+oxXMTjrQZ8urT0iOlEgclt4fiS2EBxglUfCPgkusSw5bS+1Z RHrFlIE6GsqJMaC70d1f2gXpPMR6hqB76bOJuuOlStzkCLtndrMlQxLtCAZohbxAwS lANWZNjWkfvEOj7rHxhRin0Us2HIc3i3yx9PAls8BE6L1lToC3qbWnTBGgIcPqEO3M 7vBQnF8lolqpO6OXE/Lz9A7eP/Chhr1a9Fe0gJi5wg1au7AMib/cXFOiAyclggdYlX Z6DSZC3fFSCPg== From: Will Deacon To: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Fangrui Song Cc: kernel-team@android.com, Will Deacon , Ard Biesheuvel , Peter Smith , Jisheng Zhang , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Dave Martin Subject: Re: [PATCH v2] arm64: jump_label: use constraints "Si" instead of "i" Date: Fri, 9 Feb 2024 18:31:08 +0000 Message-Id: <170749826521.2630324.4507897270923627883.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240206074552.541154-1-maskray@google.com> References: <20240206074552.541154-1-maskray@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Mon, 5 Feb 2024 23:45:52 -0800, Fangrui Song wrote: > The generic constraint "i" seems to be copied from x86 or arm (and with > a redundant generic operand modifier "c"). It works with -fno-PIE but > not with -fPIE/-fPIC in GCC's aarch64 port. > > The machine constraint "S", which denotes a symbol or label reference > with a constant offset, supports PIC and has been available in GCC since > 2012 and in Clang since 7.0. However, Clang before 19 does not support > "S" on a symbol with a constant offset [1] (e.g. > `static_key_false(&nf_hooks_needed[pf][hook])` in > include/linux/netfilter.h), so we use "i" as a fallback. > > [...] Applied to arm64 (for-next/fixes), thanks! [1/1] arm64: jump_label: use constraints "Si" instead of "i" https://git.kernel.org/arm64/c/f9daab0ad01c Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev