Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp1118847rdb; Fri, 9 Feb 2024 10:46:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IFercz00rRh2OA/xY64JZ81d5GMIH+Urz6krcoXozYFZs2vl8itufv/e18A27NnZ807EUBl X-Received: by 2002:a17:902:dac1:b0:1d9:3b54:d857 with SMTP id q1-20020a170902dac100b001d93b54d857mr148134plx.23.1707504404430; Fri, 09 Feb 2024 10:46:44 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707504404; cv=pass; d=google.com; s=arc-20160816; b=pCyMQBwN33lGslmOKDqED5gVYHu5HiTCxf9vYv9x/zVlaKXHkfYAoa5wJE/RHGXVTN kxIgKO17dvP1w8P/51NSF6jxOIcRgHqHxQdB5HDOMrPYRpzT7Z82DkOFvOvmwG5lOosw /kFCpoV5/My+kc/HpCi9qH0Dh+s62W9NtLM1XuuGtqIyOy7//Il0BWzEqopTgtoTSN5H b/X6FGCCsvMTzJDCAplkewRVOXucUoigN5LgIT90fhLrla/zBuJrUCK4OrADFlZUkV8L paUNCiFSbK57DeCVi87LkpTqN44wFXMiqUqNaHQifa5j2wU6dXfHsXiYqyd6suHzu20v jQow== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=cjKv+jVfvnPh9mUF0MHK6koNgD++0+DcNaTWgE5p9mc=; fh=lp6GZFrpsMhMbqbQiswCSt5NmnIzHZUKq3kO4rSa1i4=; b=U2qyH2wpD2ADYuAio0/P7Ix+XqND6qXb7cy9lk3ndDDoW1DMfZvCoqoFtY2RhqP04J O2HMeZ7QkNR/fCWsn5WOPgvN0qkzN13ba5ex7bGz5V6EtcJQAuR8qjxzf1yErOzVbpIn j0e01+TooJWhla7M+LPSsaJTf58hwywdsvPMehopkvb6SZ5k2sAV0NKG39HAY1fOEU7B iX6ZeBMYkUd5cjjeU+3HV45UJ4hcW8puQPZ5YIPSPpAgp8O1lyCGwZJzqbZ3IR+1cDSL dHPLq9EOAxgndT6/QQu31s00WHU1ed9rcKDtRooFIsU4rnIBAV3DqXrvEWRozkWdbO+L C1sA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Gtx1iKMR; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-59825-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59825-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com X-Forwarded-Encrypted: i=2; AJvYcCWa/UjjyZbs4xYLrqogF8o/yQdjdlZsEFD3ApRErPaQrYwMwYX8Rqz0p4zFoD5TJ1C6DsVPMKDIhCh8/swsOiRM3m8wT9WGP7h6ddVLMA== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id j11-20020a170902da8b00b001d78a87de63si2117326plx.205.2024.02.09.10.46.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 10:46:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-59825-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Gtx1iKMR; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-59825-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59825-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 56C9B2887FF for ; Fri, 9 Feb 2024 18:44:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 48CAD80C17; Fri, 9 Feb 2024 18:44:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="Gtx1iKMR" Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D4D869959; Fri, 9 Feb 2024 18:44:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707504249; cv=none; b=ZvrXtvFaut7mZ/0ZyTQ3lGXdv9ld59C1OnyNe0Wwd1IW4/ai5DSk8RJ1Ic/lAa7xXJCAFu5N2ci9YIHKq+sov3ycWYfflrqj+AAO2cU5MLAJ5oOyCD7593EutJ2Fn2UJ5kSzg8ii+JQg85WG97dSNiaTXsC6qCaliesQHDWPOLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707504249; c=relaxed/simple; bh=UfmR3ZT3cA3JUHC/b3QdxxcdpoQNCdTehSaoKm0uANY=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=MKV1JEiMUPR0BEjr0GcdAAu1iEfn9s0BP+fG28skiIPWnTS1CBHl7plDqX8TD2+l6U/Exv0ufmCIQKTmVGT0bbSe6mjeU2wXGSkv8M5fUKUV1tFFWueFXP+OrgfBM4GwTm7OAgV/cQu2z7+Yaf8PG7Wa1H0bkv/loz3JQIyNzsg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=Gtx1iKMR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 419GL1Ah004579; Fri, 9 Feb 2024 18:44:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=cjKv+jVfvnPh9mUF0MHK6koNgD++0+DcNaTWgE5p9mc=; b=Gt x1iKMRBwtFQg4KaM3ubTJe7nyyb0ODm2llg3E6wfj9zqgVV5qB0ljHtal90Bchgq 5E2EVj9hVByyTahXHnCuncrWXNNwjndI4tfB5BzJ7+vz9DQthMUNKAZLC3Le6Yky 8/9R8UppQXD4e2q9e+xattg1SRa7BjtqA1rG2PfAemjiW8TlFdhM6U5ATvU1Udnr HzAKprqkoU+y3SYABs2EK2C1ofjA1JWIWcw8EeZ68gYjpeKmSUTl+JhemacHn3bM r8aa5gj24J5oVyf5ZEnU6peV8PQRuPEvyCa+3wbpr2YSMO+34HGsPybfOSUSWhFp rDBDoThIpWpYYk3UCk3w== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3w5ann1x4b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Feb 2024 18:44:02 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 419Ii11K011288 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 9 Feb 2024 18:44:01 GMT Received: from [10.110.104.98] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 9 Feb 2024 10:44:00 -0800 Message-ID: <9a4bf513-4390-3e36-f3b7-f9fef1c296fd@quicinc.com> Date: Fri, 9 Feb 2024 10:43:59 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v4 2/4] drm/msm/dpu: support binding to the mdp5 devices Content-Language: en-US To: Dmitry Baryshkov , Rob Clark , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter CC: , , , References: <20240208-fd-migrate-mdp5-v4-0-945d08ef3fa8@linaro.org> <20240208-fd-migrate-mdp5-v4-2-945d08ef3fa8@linaro.org> From: Abhinav Kumar In-Reply-To: <20240208-fd-migrate-mdp5-v4-2-945d08ef3fa8@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: Gr34EX9Ru715wN-GU__jFD8-ecibzKXK X-Proofpoint-GUID: Gr34EX9Ru715wN-GU__jFD8-ecibzKXK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-09_16,2024-02-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=962 priorityscore=1501 phishscore=0 clxscore=1015 impostorscore=0 bulkscore=0 malwarescore=0 suspectscore=0 mlxscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402090137 On 2/8/2024 7:01 AM, Dmitry Baryshkov wrote: > Existing MDP5 devices have slightly different bindings. The main > register region is called `mdp_phys' instead of `mdp'. Also vbif > register regions are a part of the parent, MDSS device. Add support for > handling this binding differences. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 98 ++++++++++++++++++++++++++------- > drivers/gpu/drm/msm/msm_drv.h | 3 + > drivers/gpu/drm/msm/msm_io_utils.c | 13 +++++ > 3 files changed, 93 insertions(+), 21 deletions(-) > I thought we had agreed on a quite version of msm_ioremap_mdss for vbif_nrt_phys? Anyway, its not something to block this change. Hence, Reviewed-by: Abhinav Kumar