Received-SPF: pass (google.com: domain of linux-kernel+bounces-59840-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 9 Feb 2024 10:56:10 -0800
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Brenton Simpson <appsforartists@google.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Cameron Gutman <aicommander@gmail.com>,
	Erica Taylor <rickytaylor26@gmail.com>,
	Ismael Ferreras Morezuelas <swyterzone@gmail.com>,
	Jonathan Frederick <doublej472@gmail.com>,
	Matthias Benkmann <matthias.benkmann@gmail.com>,
	Matthias Berndt <matthias_berndt@gmx.de>, nate@yocom.org,
	Sam Lantinga <slouken@libsdl.org>, Vicki Pfau <vi@endrift.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	trivial@kernel.org
Subject: Re: [PATCH] Input: xpad - sort xpad_device by vendor and product ID
Message-ID: <ZcZ1Sn_iPwlgfI3s@google.com>
References: <Zbl49VAMZx2qrz-p@google.com>
 <20240130231903.293265-1-appsforartists@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240130231903.293265-1-appsforartists@google.com>

Hi Brenton,

On Tue, Jan 30, 2024 at 11:19:03PM +0000, Brenton Simpson wrote:
> Signed-off-by: Brenton Simpson <appsforartists@google.com>

Empty patch descriptions are frowned upon. You should be able to add at
least a single sentence why the change is being made.

..

>  
>  static const struct usb_device_id xpad_table[] = {
> +	/* Please keep this list sorted by vendor ID.  Because the lines use different
> +	 * macros, you may need to sort it by hand.
> +	 */

Kernel style of multi-line comments is:

	/*
	 * line 1
	 * line 2.
	 */

I adjusted and applied, thank you.

Thanks.

-- 
Dmitry