Received-SPF: pass (google.com: domain of linux-kernel+bounces-59892-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <f4d4ff97-7d40-4915-943a-a7371e24dae5@amd.com>
Date: Fri, 9 Feb 2024 13:38:34 -0600
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v15-RFC 0/8] Add support for Sub-NUMA cluster (SNC)
 systems
Content-Language: en-US
To: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
 Reinette Chatre <reinette.chatre@intel.com>,
 Peter Newman <peternewman@google.com>, Jonathan Corbet <corbet@lwn.net>,
 Shuah Khan <skhan@linuxfoundation.org>, x86@kernel.org,
 Shaopeng Tan <tan.shaopeng@fujitsu.com>, James Morse <james.morse@arm.com>,
 Jamie Iles <quic_jiles@quicinc.com>, Randy Dunlap <rdunlap@infradead.org>,
 Drew Fustini <dfustini@baylibre.com>, linux-kernel@vger.kernel.org,
 linux-doc@vger.kernel.org, patches@lists.linux.dev
References: <20240126223837.21835-1-tony.luck@intel.com>
 <20240130222034.37181-1-tony.luck@intel.com>
 <91bd281e-e21f-4b60-9e73-2f14fcbec316@amd.com>
 <ZcZvguSNel-z3Xe5@agluck-desk3>
From: "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <ZcZvguSNel-z3Xe5@agluck-desk3>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N2dXbEtHVGt5OTlSL3VzazVGdkpCRHJiVUh5M1JTYVl4NWFrL1lBVzNXRmJ1?=
 =?utf-8?B?VVc4dmtDK08rUkRvYnhQSXBJbENyMDFJYVlJVWFJUjR1bTBseThjdkVkVSt4?=
 =?utf-8?B?bTFhQWNhL2szdmtHaU9CSVBpWG5iSUZKcjYzd24yblFBM2lDTVVsMTNlQzdB?=
 =?utf-8?B?dUNsbXFVL1EvWW82d1ZKWFF4YlJMbjMxSG1yV0RzZ0NMR2lkNjdScXAvaEFQ?=
 =?utf-8?B?emtCODZRRnNaejVha0lQZWtLRmZYS0VuZ0tLS2IvUDVrZVdzVEVIREgyT3lI?=
 =?utf-8?B?TllvQzcwTFNmdk5HeDNkZlhxNmpLZzJGY2lML1JMZ2VlRi9Lay96MlZjMVFE?=
 =?utf-8?B?c3U1UDJGK29zYkQyK1BkZzBpMytXVUZUVUJadXpXTU9kNTdFdDRhZ0o5Rmg3?=
 =?utf-8?B?U2NQVmJ5c1dqcExNQzJDOW5vRm1nUE9taTJidFFobTZ5cEZLYlVmUDRjVS9w?=
 =?utf-8?B?MlNLRkFBa3Q4VklYNWVHVEYvM2pWb25yQ1pJbTRtOS9YblNLeTR5TTE0Rkhv?=
 =?utf-8?B?THUwbmxEbmtMSTkxNkFRVlZXczFDb09zY24vVkp1elFGdXdRaTIxKzBoMTQ3?=
 =?utf-8?B?NEx4SmlZd3lYbEJrRWJ3cjh5aE1oZ2QxQXZFNlNhMS9OUENFaUlqZnl6WWVv?=
 =?utf-8?B?OVBpbURVTEZ4eU5NeTlBZFpnZ3JrdG9odXVKSkU5VkhlYktGWVFYMXRGekNt?=
 =?utf-8?B?YTdyd1VTRFk3NmVkWmZWSHRWWUxPRitFN2E2MnFaNWNQdGlSYjFTR3ROV0c4?=
 =?utf-8?B?eTAxTVg3bEs2NnlvMHhZZFVYUTJtTXNYK0FKRENzSVBSOFhlMFdMMDVBSGJt?=
 =?utf-8?B?ZTdjcTNVYXZYdE1pZjdmMDAzeW9tMHNiVDhLbW1XTk5tVjdJSG9jYlJ0cHFO?=
 =?utf-8?B?Z1pheDZUS2lMMFl2S25Uc21ZdjEweDZOUnM4SGZwQ2VhdUdGYU1JR013TGc5?=
 =?utf-8?B?Uk01Z0FYY1d4blpMNkd2Q2xEdVJRU0pXbnhNbUliUGNuY3NyMEZQVjdEcDBY?=
 =?utf-8?B?am80enpUcVdYUWIvRnRhVlNQR0YyMENyeDNCWWZNK3lXd0x1aWJHRkVqUWJJ?=
 =?utf-8?B?RVAzQWVsblRVMzV5dFNqOElwZlN6bU9LQmQ1em0rdERYWXczUjVKRVJxcUR3?=
 =?utf-8?B?SlJGdllFUWdCYUROSjJUd3dOWHFPdFRqY1UzOVlJaWFNL0taWXdpaE91eGVp?=
 =?utf-8?B?SGtXV3hmY0lOaXBadmkwdjZzbmFjdnF0T0JWQTExM05kaG5uQ0piSkFQaUhn?=
 =?utf-8?B?R1NYT2FKN3VhcVV1cGlOZkU5WVZ5YVNXZ3VaTEFlYTNadzB0YU4xdWN0NTFh?=
 =?utf-8?B?Tnh0NUZSWXZQRXNyblJnbDJZclR1UjAyKzRvYUY5SlRtZDEvYk1uUHhBMWNV?=
 =?utf-8?B?NEVKcjR1Vzk2QlRFRE1ZWnhtY2RuSXlaNzlqUWVwRFlqS2Jva0gyQVgzamlH?=
 =?utf-8?B?MHdmU0tVSHZSUjJJc0ZTVXJiSWRyWm1PZlpxTjNPc0V3VHF2UGxxeElOMkJH?=
 =?utf-8?B?NHhiUG8zcmc4dWhuVDRJK1piS0dXTTFlOVZCdzdkZUFOcnZ2c3NkTTVQcDhK?=
 =?utf-8?B?RGhTMkQvREJtQTZWYVJLcSsrVG5pdFAxVitINUJKazJ5OThOemRtdnpLOWc1?=
 =?utf-8?B?WE4yN3ZQbDdoYkpvUEdQWnd3WVMydW1lS2FGM3JTejllWTE0bWw5YzV6RDlH?=
 =?utf-8?B?QzBOZThQN3NyVEFxUTJ2UGhrUEt1YWZRNWdsMml0aDZCOU0wbnIrOGpXR2g4?=
 =?utf-8?B?bzllcHlvdWVhYXZXN0hhWlRSQlBFcjg1K01rTGkxOUxVZStQUU9DOWNCSGdF?=
 =?utf-8?B?NWI5azNVOWt5M0tMblpiYnF3RW45QWxaQWpxMHh2UkdGTktYRWlNR21yL0FQ?=
 =?utf-8?B?Mjg3blhrZmxoTi9UTkM4UzlVcUpwcnJZZnRVM3BCWVlEM0c3RXUzMktPN3FN?=
 =?utf-8?B?SXgzcXJNNTRMMDlTc0hPMGM4cUFWY3FxMVB3UUhuNE10a2l2d0VDVnVMUFhH?=
 =?utf-8?B?cEsrTDhYdTlTS1RwbndLV1p5dVMrVmlTZlc0UFBZaENSSDQxSmJNL3JTZUlz?=
 =?utf-8?B?RE9xTnVkdVBYQjZmVHF0NmRvNXZlUFBoZXErQzdKRmdzZFpQeERYWlhUL25E?=
 =?utf-8?Q?LNbtZqMyxmeIyUVM9fskp9Ir7?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5df477e-99b9-4d1b-b2df-08dc29a6b5cd
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 19:38:37.2457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rbkFl5HK/zEiVIcL0nmh1fl8aym1NL4eT7Ec4UHMjhQuLwqZO6N99SBFECUQqgMc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5673


On 2/9/24 12:31, Tony Luck wrote:
> On Fri, Feb 09, 2024 at 09:27:56AM -0600, Moger, Babu wrote:
>> Hi Tony,
>>
>> On 1/30/24 16:20, Tony Luck wrote:
>>> This is the re-worked version of this series that I promised to post
>>> yesterday. Check that e-mail for the arguments for this alternate
>>> approach.
>>
>> To be honest, I like this series more than the previous series. I always
>> thought RDT_RESOURCE_L3_MON should have been a separate resource by itself.
>>
>> You need to separate the domain lists for RDT_RESOURCE_L3 and
>> RDT_RESOURCE_L3_MON if you are going this route. I didn't see that in this
>> series. Also I have few other comments as well.
> 
> They are separated. Each "struct rdt_resource" has its own domain list.

Yea. You are right.
> 
> Or do you mean break up the struct rdt_domain into the control and
> monitor versions as was done in the previous series?

No. Not required. Each resource has its own domain list. So, it is
separated already as far as I can see.

Reinette seem to have some concerns about this series. But, I am fine with
both these approaches. I feel this is more clean approach.
-- 
Thanks
Babu Moger