Received-SPF: pass (google.com: domain of linux-kernel+bounces-59896-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <f1aef7ce-fb0b-45cf-985d-d4b26015ed07@amd.com>
Date: Fri, 9 Feb 2024 13:40:57 -0600
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v15-RFC 1/8] x86/resctrl: Split the RDT_RESOURCE_L3
 resource
Content-Language: en-US
To: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
 Reinette Chatre <reinette.chatre@intel.com>,
 Peter Newman <peternewman@google.com>, Jonathan Corbet <corbet@lwn.net>,
 Shuah Khan <skhan@linuxfoundation.org>, x86@kernel.org,
 Shaopeng Tan <tan.shaopeng@fujitsu.com>, James Morse <james.morse@arm.com>,
 Jamie Iles <quic_jiles@quicinc.com>, Randy Dunlap <rdunlap@infradead.org>,
 Drew Fustini <dfustini@baylibre.com>, linux-kernel@vger.kernel.org,
 linux-doc@vger.kernel.org, patches@lists.linux.dev
References: <20240126223837.21835-1-tony.luck@intel.com>
 <20240130222034.37181-1-tony.luck@intel.com>
 <20240130222034.37181-2-tony.luck@intel.com>
 <c9629380-c97c-4797-b6b3-5044d5beeb97@amd.com>
 <ZcZyqs5hnQqZ5ZV0@agluck-desk3>
From: "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <ZcZyqs5hnQqZ5ZV0@agluck-desk3>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S0FPalpHRm8wYUE2UUN1dVVDOHljcXV5Y0lta3ZrQ2lVZWJIa3k2WnBCemc4?=
 =?utf-8?B?UmljNzJuWmc3VWhGUjFwMmNXMjhNckRTTWEzWmxaWmU3VjFKazBtV0N1bzkz?=
 =?utf-8?B?WmFGbUFrb0trYktIUTJxV3ZBSHhJSGhVNWpsclp1OFlJZ29UQVhBSXdoR2Vz?=
 =?utf-8?B?Qy91ek5oNFZqeisvanRyeVNmbkdjYms2bk1lLzd2NjZQSGx1OHp1M0tNVnpi?=
 =?utf-8?B?NC93RkpQNUNPREJKZCtxYlN3eTVFWTFpN1hwN1Q0K0NlVmQzODVJa1ZNTEN1?=
 =?utf-8?B?aWFJN0lWV2N6MVFFMWxPWThuR2psU3p6Nnh2MmtwKzMySXRablNiVENBakoz?=
 =?utf-8?B?SE00STk5eUlYU0hwQkcvMzgyOE9hemZFY1hIR3l3aEZ0TW8vVGV3YUg0Qjdp?=
 =?utf-8?B?NmcxMndmNzlqMGxSelRaUUgvV2RySnJZbWx6ZHFYbVd5QUZhYXkzWnpwSnV3?=
 =?utf-8?B?aENRMlpwTUNKMXNvMnVpRnI2WUZwcElrb2JnbUdPVkY3L2tlN3ZnTy9iSVFW?=
 =?utf-8?B?S2Y1OE8vNWR1QzVIczFFcmdha0Nibk1EbVNiSXVqQ2xtSGhIdXZMZGFEOEF0?=
 =?utf-8?B?K3V5OTFDTURoZTJhU1hYUzIvMEZDNXp2WElGNExGV2FycjVtdW1SWjg3dmc3?=
 =?utf-8?B?a0ZnVXYvZHJCRVdhU0FVcVlqSzR3Q1IrWHpCV2pFZGFBMU8vRURHT2dPeGN0?=
 =?utf-8?B?aUM4OFJsbmpMMFMydjJkNUxncU5jSXJ3WHg0U2dZaWk3cm9RZHJKUGVxVW9q?=
 =?utf-8?B?RlJsd0ttelgrNk10RDZhU1F6dkUySTdraTNpNCtlNnV5a2s2V1JjWmJjcEpQ?=
 =?utf-8?B?SWRaTHpuN0RyNTU0Tk1iNEh6QUFOcC9XcTV3cmpxeDVPVXVEbDNNWWd3Sksz?=
 =?utf-8?B?MmRwd3ByTXlrWFlqbTNZSm5IanNMdnpZeVFaa3oxQkthbHMvazdHU0tmeGww?=
 =?utf-8?B?dGp6cGJrMG0yNnBXS1dTRGVpMFlxOFU0MUxBeGtma29LTW02ekpETjRRQXpB?=
 =?utf-8?B?cVpHN1hKTEQ3cFIvTEJGN2lqWmVHeXplOEVzRmZTVnpYc3dBcHRQamhGT21k?=
 =?utf-8?B?V3NCWjdHSDdZb0R5b05YcmVEU0VsNkllUmswWkxyY0pzNnpmWFJtb0RReHB5?=
 =?utf-8?B?aHhaVVBkcjZMdDlNWEJGV0VqeVdlZ0xpYzdjcGxxczk0Q2R3MVQrSVpOMGpU?=
 =?utf-8?B?ZWl2OW9hMEhGS1pUNXpxUllYaS9tWUlJdDZNT1M1cUJscGpESGJvalhrKzFX?=
 =?utf-8?B?N2dmNnEzd2VuekpDMk1CV0wrZUVPalB5ZSs3b0lmTytDOEkxQlI2T0FyOWFh?=
 =?utf-8?B?ZkZyM3hIMUFqZVdWWFpqSEQwNzZpbGcva0ErL0JKY2pMcktlNDRnQmxFMXZh?=
 =?utf-8?B?TWp5S1puNjVOdll1V3hQNXdiK1ErNkJ4R21XR1ZZL1FXMmRZWXozYXBoZnlk?=
 =?utf-8?B?VEVucS80Umt0RjhxcDBQSWZRcVJZVnRJaE1yYlY0VUpKdUo5TnpPTU5JVGFh?=
 =?utf-8?B?N3ZGZFlWTThwZ0JSWUdxUHBzZEduaEdQSnI1aE82K1FEaU9EVWdHdi9rbGlY?=
 =?utf-8?B?b2NweTNFZUMwTmxQNG45eXQwTGVENzNqYk0vQzlBdnl4U0gwYktrM2Jtc05N?=
 =?utf-8?B?OTZkNlFxRzlIQldrb01WUkdidVVMenlVRFd1NFdSWWFpT0o4cHB1N0dKOHdh?=
 =?utf-8?B?MVY2NkwxSVIwNllmdEprTTcrbWhsaGRmNW1nMnJSWDZvWWhnQmNTQWdIU2E3?=
 =?utf-8?B?VEw5THdKTkZlS1dFVUU3cjlLcjRhWkxRYjdDT1RTUjFuSEZ0ekR6V1IrNHlO?=
 =?utf-8?B?Mlc3L1NXcUFHSmNpN2haSENueUZjTHZGNVdDbmxXYTZEdXhrcmpSbVVxdWFx?=
 =?utf-8?B?NnFwSGY4WFRSeXBNUzBEVUVlWXlVWWNESW5yT0M4R3ZPWVhEZ3RoY3ptMGw0?=
 =?utf-8?B?Z2F1cVpNU3pTdm1OMnZpTG1wNjhnL3dPcUJ5U2FaUnB6ZUJxY2JNYmRycGZ0?=
 =?utf-8?B?L1dUTnpoNmx4VXQ2dUJOK2RsVjR4ZzhGb3F0OFZaUFdYbXhlUG5HSjI4N1VQ?=
 =?utf-8?B?VDQwbE12WXcrZE1OVFRyQ0s3UFo1ZjdDUzQwUmxxcWN3MXdxMExmaE5hMWFi?=
 =?utf-8?Q?5GCDROmpIYjUskKNJ2DoLp9K+?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 789aa6b0-2b8e-49e6-bc07-08dc29a70aed
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 19:41:00.0624
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4mbvfJ61Ia+PyXk3ejyOyL+/XzqPrk8AkQ7dlgrY20+W2p/eHBltE38MIMKmnLYN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8160


On 2/9/24 12:44, Tony Luck wrote:
> On Fri, Feb 09, 2024 at 09:28:16AM -0600, Moger, Babu wrote:
>>>  enum resctrl_res_level {
>>> +	RDT_RESOURCE_L3_MON,
>>>  	RDT_RESOURCE_L3,
>>
>> How about?
>> RDT_RESOURCE_L3,
>> RDT_RESOURCE_L3_MON,
> 
> Does the order matter? I put the L3_MON one first because historically
> cache occupancy was the first resctrl tool. But if you have a better
> argument for the order, then I can change it.

That is fine. No need to change.

> 
>>>  	RDT_RESOURCE_L2,
>>>  	RDT_RESOURCE_MBA,
>>> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
>>> index aa9810a64258..c50f55d7790e 100644
>>> --- a/arch/x86/kernel/cpu/resctrl/core.c
>>> +++ b/arch/x86/kernel/cpu/resctrl/core.c
>>> @@ -60,6 +60,16 @@ mba_wrmsr_amd(struct rdt_domain *d, struct msr_param *m,
>>>  #define domain_init(id) LIST_HEAD_INIT(rdt_resources_all[id].r_resctrl.domains)
>>>  
>>>  struct rdt_hw_resource rdt_resources_all[] = {
>>> +	[RDT_RESOURCE_L3_MON] =
>>> +	{
>>> +		.r_resctrl = {
>>> +			.rid			= RDT_RESOURCE_L3_MON,
>>> +			.name			= "L3",
>>
>> L3_MON ?
> 
> That was my first choice too. But I found:
> 
> $ ls /sys/fs/resctrl/info
> L3  L3_MON_MON  last_cmd_status  MB
> 
> This would be easy to fix ... just change this code to not append
> an extra "_MON" to the directory name:
> 
>         for_each_mon_capable_rdt_resource(r) {
>                 fflags = r->fflags | RFTYPE_MON_INFO;
>                 sprintf(name, "%s_MON", r->name);
>                 ret = rdtgroup_mkdir_info_resdir(r, name, fflags);
>                 if (ret)
>                         goto out_destroy;
>         }
> 
> But I also saw this:
> $ ls /sys/fs/resctrl/mon_data/
> mon_L3_MON_00  mon_L3_MON_01
> 
> which didn't seem to have an easy fix. So I took the easy route and left
> the ".name" field as "L3_MON".
> 

Ok. Sounds good.

-- 
Thanks
Babu Moger