Received-SPF: pass (google.com: domain of linux-kernel+bounces-59900-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 9 Feb 2024 20:44:01 +0100
From: Pavel Machek <pavel@ucw.cz>
To: =?utf-8?Q?Ond=C5=99ej?= Jirman <megi@xff.cz>,
	phone-devel@vger.kernel.org,
	kernel list <linux-kernel@vger.kernel.org>, fiona.klute@gmx.de,
	martijn@brixit.nl, samuel@sholland.org,
	heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI
 bridge
Message-ID: <ZcaAgXwmpTxISn3t@duo.ucw.cz>
References: <Zbt1dIByBZ2stzjm@mobian>
 <iikhv7e2z3pk7nr6bvtuepwyrmukym5fjtc2xspsmhxzz5jlwe@5vfs4i3w66kc>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="TjKZTdICc2XbU5ZB"
Content-Disposition: inline
In-Reply-To: <iikhv7e2z3pk7nr6bvtuepwyrmukym5fjtc2xspsmhxzz5jlwe@5vfs4i3w66kc>


--TjKZTdICc2XbU5ZB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> > From: Ondrej Jirman <megi@xff.cz>
> >=20
> > This is driver for ANX7688 USB-C HDMI, with flashing and debugging
> > features removed. ANX7688 is rather criticial piece on PinePhone,
> > there's no display and no battery charging without it.
>=20
> Don't remove the flashing part. Some Pinephones come without the firmware
> in the past. Even recently, I've seen some people in the Pine chat
> asking how to flash the firmware on some old PinePhone.
>=20
> It's a safe operation that can be done at any time and can only be done
> from the kernel driver.

I can re-add it later, but initial merge will be tricky enough as-is.

> > There's likely more work to be done here, but having basic support
> > in mainline is needed to be able to work on the other stuff
> > (networking, cameras, power management).
> >=20
> > Signed-off-by: Ondrej Jirman <megi@xff.cz>
>=20
> I should be second in order of sign-offs. Martijn wrote a non-working ske=
leton
> https://megous.com/git/linux/commit/?h=3Dpp-5.7&id=3D30e33cefd7956a2b49fb=
27008b4af9d868974e58
> driver. Then I picked it up and developed it over years to a working thin=
g.
> Almost none of the skeleton remains.

I believe From: should match First signed-off. I guess Martijn should
be marked as co-developed-by or something like that?

> License is GPLv2.

Ok.

> > +	ret =3D of_property_read_variable_u32_array(dev->of_node, "sink-caps",
> > +						  anx7688->snk_caps,
> > +						  1, ARRAY_SIZE(anx7688->snk_caps));
> > +	if (ret < 0) {
> > +		dev_err(dev, "failed to get sink-caps from DT\n");
> > +		return ret;
> > +	}
>=20
> ^^^ The driver will need to follow usb-c-connector bindings and it will n=
eed
> a bindings documentation for itself.
>=20
> That's one of the missing things that I did not implement, yet.

Yep, I fought with device trees for few days. I should have yaml
ready.

Best regards,
								Pavel

--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--TjKZTdICc2XbU5ZB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZcaAgQAKCRAw5/Bqldv6
8hVHAJwKdrMSwlHGJgCePaiwKzXOXwsYGQCgmaWFSFHZOLEP8pMfPXnkuU8afj8=
=zDar
-----END PGP SIGNATURE-----

--TjKZTdICc2XbU5ZB--