Received-SPF: pass (google.com: domain of linux-kernel+bounces-59918-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <d9e6ba68-180d-4ac7-9aa9-b9972e1e9f71@collabora.com>
Date: Fri, 9 Feb 2024 22:04:59 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ASoC: SOF: amd: Skip IRAM/DRAM size modification for
 Steam Deck OLED
Content-Language: en-US
To: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>,
 Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
 Liam Girdwood <lgirdwood@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
 Bard Liao <yung-chuan.liao@linux.intel.com>,
 Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
 Daniel Baluta <daniel.baluta@nxp.com>,
 Kai Vehmanen <kai.vehmanen@linux.intel.com>, Mark Brown
 <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
 Takashi Iwai <tiwai@suse.com>, "Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>
Cc: sound-open-firmware@alsa-project.org, linux-sound@vger.kernel.org,
 linux-kernel@vger.kernel.org, kernel@collabora.com
References: <20240209122810.2258042-1-cristian.ciocaltea@collabora.com>
 <f4b87510-4f55-4364-960f-5870c4d86874@amd.com>
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
In-Reply-To: <f4b87510-4f55-4364-960f-5870c4d86874@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 2/9/24 14:49, Venkata Prasad Potturu wrote:
> 
> On 2/9/24 17:58, Cristian Ciocaltea wrote:
>> The recent introduction of the ACP/PSP communication for IRAM/DRAM fence
>> register modification breaks the audio support on Valve's Steam Deck
>> OLED device.
>>
>> It causes IPC timeout errors when trying to load DSP topology during
>> probing:

[...]

> Programming ACP_IRAM_DRAM_FENCE register to modify the size of IRAM and
> DRAM and it's noting related to signed or unsigned fw_image.
> 
> This ACP_IRAM_DRAM_FENCE register writing need to do before starting sha
> dma. 

Unfortunately it doesn't fix the issue - I tested with the psp_send_cmd()
calls moved to various positions before the line

  snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_CMD, ACP_SHA_RUN);

and I keep getting the IPC timeouts.

However, if I simply comment out the second psp_send_cmd() line

  psp_send_cmd(adata, MBOX_ACP_IRAM_DRAM_FENCE_COMMAND | MBOX_ISREADY_FLAG);

the problem is solved, even when the first psp_send_cmd() is kept in the
original position.

Anything else worth trying?

Otherwise I would rework the patch to add a dedicated quirk for getting
this ACP_IRAM_DRAM_FENCE processing skipped for Steam Deck OLED.

Thanks,
Cristian