Received-SPF: pass (google.com: domain of linux-kernel+bounces-59937-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240206084838.34560-1-usama.anjum@collabora.com>
In-Reply-To: <20240206084838.34560-1-usama.anjum@collabora.com>
From: Andrei Vagin <avagin@gmail.com>
Date: Fri, 9 Feb 2024 12:29:58 -0800
Message-ID: <CANaxB-zB6Qs_AYCJCQNC3ekx+DMoXoHB4Yq-uMBm7qs-bMPv4A@mail.gmail.com>
Subject: Re: [PATCH] mm/migrate: preserve exact soft-dirty state
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Paul Gofman <pgofman@codeweavers.com>, 
	kernel@collabora.com, =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <emmir@google.com>, 
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 6, 2024 at 12:48=E2=80=AFAM Muhammad Usama Anjum
<usama.anjum@collabora.com> wrote:
>
> From: Paul Gofman <pgofman@codeweavers.com>
>
> pte_mkdirty() sets both _PAGE_DIRTY and _PAGE_SOFT_DIRTY bits. The
> _PAGE_SOFT_DIRTY can get set even if it wasn't set on original page
> before migration. This makes non-soft-dirty pages soft-dirty just
> because of migration/compaction. Clear the _PAGE_SOFT_DIRTY flag if
> it wasn't set on original page.
>
> By definition of soft-dirty feature, there can be spurious soft-dirty
> pages because of kernel's internal activity such as VMA merging or
> migration/compaction. This patch is eliminating the spurious soft-dirty
> pages because of migration/compaction.
>
> Cc: Micha=C5=82 Miros=C5=82aw <emmir@google.com>
> Cc: Andrei Vagin <avagin@gmail.com>

Acked-by: Andrei Vagin <avagin@gmail.com>

> Signed-off-by: Paul Gofman <pgofman@codeweavers.com>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
>  mm/migrate.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index cc9f2bcd73b4..05d6ca437321 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -211,14 +211,17 @@ static bool remove_migration_pte(struct folio *foli=
o,
>                 folio_get(folio);
>                 pte =3D mk_pte(new, READ_ONCE(vma->vm_page_prot));
>                 old_pte =3D ptep_get(pvmw.pte);
> -               if (pte_swp_soft_dirty(old_pte))
> -                       pte =3D pte_mksoft_dirty(pte);
>
>                 entry =3D pte_to_swp_entry(old_pte);
>                 if (!is_migration_entry_young(entry))
>                         pte =3D pte_mkold(pte);
>                 if (folio_test_dirty(folio) && is_migration_entry_dirty(e=
ntry))
>                         pte =3D pte_mkdirty(pte);
> +               if (pte_swp_soft_dirty(old_pte))
> +                       pte =3D pte_mksoft_dirty(pte);
> +               else
> +                       pte =3D pte_clear_soft_dirty(pte);
> +
>                 if (is_writable_migration_entry(entry))
>                         pte =3D pte_mkwrite(pte, vma);
>                 else if (pte_swp_uffd_wp(old_pte))
> --
> 2.42.0
>