Received-SPF: pass (google.com: domain of linux-kernel+bounces-59944-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <b007a78c-b8fb-83bc-3be6-963708182cee@quicinc.com>
Date: Fri, 9 Feb 2024 12:34:39 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v14 20/53] ASoC: Add SOC USB APIs for adding an USB
 backend
Content-Language: en-US
To: Takashi Iwai <tiwai@suse.de>
CC: <srinivas.kandagatla@linaro.org>, <mathias.nyman@intel.com>,
        <perex@perex.cz>, <conor+dt@kernel.org>, <corbet@lwn.net>,
        <lgirdwood@gmail.com>, <andersson@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <gregkh@linuxfoundation.org>,
        <Thinh.Nguyen@synopsys.com>, <broonie@kernel.org>,
        <bgoswami@quicinc.com>, <tiwai@suse.com>, <robh+dt@kernel.org>,
        <konrad.dybcio@linaro.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-sound@vger.kernel.org>,
        <linux-usb@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <alsa-devel@alsa-project.org>
References: <20240208231406.27397-1-quic_wcheng@quicinc.com>
 <20240208231406.27397-21-quic_wcheng@quicinc.com>
 <87r0hl29ha.wl-tiwai@suse.de>
From: Wesley Cheng <quic_wcheng@quicinc.com>
In-Reply-To: <87r0hl29ha.wl-tiwai@suse.de>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Hi Takashi,

On 2/9/2024 2:54 AM, Takashi Iwai wrote:
> On Fri, 09 Feb 2024 00:13:33 +0100,
> Wesley Cheng wrote:
>>
>> Some platforms may have support for offloading USB audio devices to a
>> dedicated audio DSP.  Introduce a set of APIs that allow for management of
>> USB sound card and PCM devices enumerated by the USB SND class driver.
>> This allows for the ASoC components to be aware of what USB devices are
>> available for offloading.
>>
>> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
> (snip)
>> --- a/sound/soc/Makefile
>> +++ b/sound/soc/Makefile
>> @@ -1,5 +1,5 @@
>>   # SPDX-License-Identifier: GPL-2.0
>> -snd-soc-core-objs := soc-core.o soc-dapm.o soc-jack.o soc-utils.o soc-dai.o soc-component.o
>> +snd-soc-core-objs := soc-core.o soc-dapm.o soc-jack.o soc-usb.o soc-utils.o soc-dai.o soc-component.o
>>   snd-soc-core-objs += soc-pcm.o soc-devres.o soc-ops.o soc-link.o soc-card.o
>>   snd-soc-core-$(CONFIG_SND_SOC_COMPRESS) += soc-compress.o
> 
> Do we really want to build this into ASoC core unconditionally?
> This is very specific to Qualcomm USB-offload stuff, so it's better to
> factor out.
> 

Ideally, the SOC USB part shouldn't be Qualcomm specific.  Since I don't 
have access or insight into how other vendors are achieving the same 
thing, I can only base the soc-usb layer to work with the information 
that is required to get the audio stream up and running on the QC 
platforms.  In its simplest form, its basically just a SW entity that 
notifies ASoC components about changes occurring from USB SND, and I 
think all vendors that have an ASoC based platform card handling the 
offload will need this notification.

Thanks
Wesley Cheng