Received-SPF: pass (google.com: domain of linux-kernel+bounces-59956-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Zi Yan <ziy@nvidia.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
 "\"Huang, Ying\"" <ying.huang@intel.com>,
 Ryan Roberts <ryan.roberts@arm.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
 David Hildenbrand <david@redhat.com>,
 "\"Yin, Fengwei\"" <fengwei.yin@intel.com>, Yu Zhao <yuzhao@google.com>,
 "\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
 Johannes Weiner <hannes@cmpxchg.org>,
 Baolin Wang <baolin.wang@linux.alibaba.com>,
 Kemeng Shi <shikemeng@huaweicloud.com>,
 Mel Gorman <mgorman@techsingularity.net>,
 Rohan Puri <rohan.puri15@gmail.com>, Mcgrof Chamberlain <mcgrof@kernel.org>,
 Adam Manzanares <a.manzanares@samsung.com>,
 "\"Vishal Moola (Oracle)\"" <vishal.moola@gmail.com>
Subject: Re: [PATCH v3 2/3] mm/compaction: add support for >0 order folio
 memory compaction.
Date: Fri, 09 Feb 2024 15:47:32 -0500
Message-ID: <4E833B0D-668E-4CDD-9E7C-5D01185B3D12@nvidia.com>
In-Reply-To: <28c47a9f-5ee4-425e-bd8d-bd251634534c@suse.cz>
References: <20240202161554.565023-1-zi.yan@sent.com>
 <20240202161554.565023-3-zi.yan@sent.com>
 <025b7e7c-b17f-47c7-8677-ee36fc6dbc52@suse.cz>
 <5F394663-0AFE-4C12-827C-3A0723863395@nvidia.com>
 <193E0D43-0084-48AA-91F5-8316A130ADC3@nvidia.com>
 <28c47a9f-5ee4-425e-bd8d-bd251634534c@suse.cz>
Content-Type: multipart/signed;
 boundary="=_MailMate_40B1309B-C45A-48CC-9A08-24B5DC789F4F_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?MDjsKQLxAfidOaLqvmHkyznHAOkjfLfPXzJt4S93xGEqBZ2LEDYuZkiwUA5/?=
 =?us-ascii?Q?rWQkkx/NE1pX82rSO/NBYCzpsD+uVLPKOtW3Fi9SVUrBuBg9pDNr03caC6wH?=
 =?us-ascii?Q?K8A0Px82BY/4Izh+dpLLiblaH0KBeeuDjfrxpYF9CGA572cWjs3ndtZZSW3V?=
 =?us-ascii?Q?Yj10yuhQSK2lpC5lzNjpiPJlnCgoC+eG4AcsqQN9kSH1vpj6fb7e8XUF/XFA?=
 =?us-ascii?Q?WJxdIDhXRWdIxlP/zgmcCXN5d75k3RSw1P1GRvV5qXVt70SZ/cftFbyk7anS?=
 =?us-ascii?Q?SKG8zWjpG5CGkfyHrZzWzZXThWfhnH7ZDdoxxsC26YZp8cKID/BFW1/Vg/yy?=
 =?us-ascii?Q?J3hSqqVLAkqKY6u5Kn1wAUd9AwczDn5nLrg/Xhs6aPbLsISYjsCsjCA/UGCA?=
 =?us-ascii?Q?9QXIpmQLze+K3vu/gHUIAnQ81ZUTu/sBX8Q1/JlDwUALUPxyVaHrxIzWLWuv?=
 =?us-ascii?Q?tgo9Ay4Ywa/wR9FOHp1v+qI+RP/EIoPTPqRZBzSyin5WWxzM2YJrKjjc4cA5?=
 =?us-ascii?Q?dn6pASdFYtj3EXdkxxcPU6db06wjufCm/p5wZXpcJHJNIkDcT5bSBBhWO0ep?=
 =?us-ascii?Q?sKNUUkBd0W2aIbIO1QqQsOqPsv/UUJ1C8kZl1Qon0j1XjASWQ7HDAjtYUGq+?=
 =?us-ascii?Q?UOdjQot7K98Z7ieXSMfq2Z0q1yHtYdBZ9o2UWeatQSBfxZAxYEZ2fTEz2Aho?=
 =?us-ascii?Q?SCm4LGyVjOhfq4ssrS0V3xX9xYvU2PJ/oFsC1dHQwzwv4+zrdUxzYaLKKARH?=
 =?us-ascii?Q?rbg9sygxR6I6Hxh1XOyD4sHANtiVER7HHyVjyrRX+9gNWfa//+pvYdHg1cVD?=
 =?us-ascii?Q?yWGJwG4PRTkwzaXaWkuvxDJ6StgXJ1WfWKbQ1GzDGAXbsKxzHq6NzaMOvsPy?=
 =?us-ascii?Q?yPfPKd5BY2vitvA0XzLszGUj1udG3Ky5SHrBvQJ5k0iUXQaUNMDoJBZGgd9l?=
 =?us-ascii?Q?rHKAakQJy9+iDlxGX3TGBP7rjkPl9oeOeJ/u52jZeARF+pfC6NTDVYnhrgUp?=
 =?us-ascii?Q?YYgWfDx7R30nnD/AM1iHDayQ/U3telLac5VoasF5+gt3TLYdgPm+NnJOr48C?=
 =?us-ascii?Q?ayo2kFeqCzlYnbQavN1FjVMN5oI2ei9sXMMBoeiAWlLgJA/5EXB4q/6Ougni?=
 =?us-ascii?Q?vzrL5+egBna3A9NvWN0RF8xPSW5hO9+sy4cPs18nO3hJ9im3YWxjXMVV7v3N?=
 =?us-ascii?Q?WsIVpXQQ34eNy6ypKdmGas53xKVwH7zEzo854LmJI+S33RlEssBfY5iTAbYT?=
 =?us-ascii?Q?CiY1lBH+SuYxfZJajY6tFFNtu2DXYvceL6ST2eFkTlTrElb2U2FUZNAw1eyE?=
 =?us-ascii?Q?qQJDN2YcLRF7UmxjAeDbRAsjW64ryW7aRtPMioaYfAle/OI15/iw/r6N7fXU?=
 =?us-ascii?Q?HqMUN8jHsTU/Za0+i0fAw05HbJl1rmzB5EGl+qHguf2SpqC405GxJz76bSKE?=
 =?us-ascii?Q?8zN1q2iiolNhy5w4QoY72Ih0IN+cce6XnBOlfje6CW8nAOPWhSGCarmRs1Gv?=
 =?us-ascii?Q?Lo3Ss5RYjaosDkRszs2APR0Pq6+qZsdF9C2/J8eRhuqH3TP4LwWMMgxHcxbY?=
 =?us-ascii?Q?pj4EV0miiMCOJLXcplZ01KGNsqLVui+KMPEwP+8Q?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 234c2559-0775-48db-c717-08dc29b0582b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 20:47:35.1076
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z2q6sOgK3VueXEobAt5Ze7VfDGjPWghDkrAzwL/XXoy87BAznL2QQIMcfUGgabX7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7970

--=_MailMate_40B1309B-C45A-48CC-9A08-24B5DC789F4F_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 9 Feb 2024, at 15:46, Vlastimil Babka wrote:

> On 2/9/24 20:40, Zi Yan wrote:
>> On 9 Feb 2024, at 14:36, Zi Yan wrote:
>>
>>> On 9 Feb 2024, at 11:37, Vlastimil Babka wrote:
>>>
>>>> On 2/2/24 17:15, Zi Yan wrote:
>>>>
>>>> ...
>>>>
>>>>>  /*
>>>>> @@ -1835,9 +1857,17 @@ static struct folio *compaction_alloc(struct=
 folio *src, unsigned long data)
>>>>>  static void compaction_free(struct folio *dst, unsigned long data)=

>>>>>  {
>>>>>  	struct compact_control *cc =3D (struct compact_control *)data;
>>>>> +	int order =3D folio_order(dst);
>>>>> +	struct page *page =3D &dst->page;
>>>>> +
>>>>> +	folio_set_count(dst, 0);
>>>>
>>>> We can't change refcount to 0 like this, after it was already set to=
 1 and
>>>> somebody else might have done get_page_unless_zero(). You need to ei=
ther
>>>> put_page_testzero() and if it's false, consider the page lost, or le=
ave it
>>>> refcounted and adjust the code to handle both refcounted and non-ref=
counted
>>>> pages on the lists (the first option is simpler and shouldn't be too=
 bad).
>>> Got it. Will fix it with the first option. Thanks.
>>
>> Do you think we should have a WARN or WARN_ONCE if we lose a page here=
?
>
> No, no WARN, it all happens legitimately. It's only our compaction losi=
ng
> the page - whoever would do the get_page_unless_zero() to inspect that =
page
> would then have to put_page() which will free it back to page allocator=
=2E

Got it. Thanks for the explanation.

--
Best Regards,
Yan, Zi

--=_MailMate_40B1309B-C45A-48CC-9A08-24B5DC789F4F_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmXGj2QPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhU55YP/3bCxavjUh0cBZ5rgFbgSEQNJi7vabDHlKeS
XPuEfd4NDZiGU3313jG5aZAeB03y2p4Cv+K+xr0fv0vI8Ut+E4QXzApmLE/85T5i
B5L0qAMbRWjYx5CVwpyWkoMs6k87Iz4KEXwp9wFbvpiEvpQl+nb6md1PdSBZEcp1
f4ukNapBscfditJounJttNJDtlpxgFX/JOael2ajib0I7fU+7mIeAoZtp3iUQyCp
PaCFWrj65wuBq/dcykyJD6zZmHUe1EsFj41EGj1rje2sy60ad/4XIjv3De9ilObY
Szuq3AfnpJYj5pTtIAm1csbhOosT3J/N54vtiDWG4zsmlM+0LvFwSrytbC271MdZ
UvjNu41GAzn1jGt0rNUaAUYIZVnH3ejtkbFIaZr8kWXbkX5pYTBB9lujl7Hiags+
hBP6xICbzE2dpX0eHWcgJbzAc2mR9aTQ8vPU6xlI7fqaOffC7DY42kHuRIh1lku4
a93Ynh15yTdDMxfeNecL2k2i34n0hIc/i9P1mk4T7O+8y0p1qSavkSxx/v3+ax/S
M5PAdlIkRnbEHFlCqT7uQiwMjp3/lE7PPD9QiPa8qCkJs21s5uxpF51HWp5mtZjF
qB+SD5rhledDnYsecdhWMXvAZnma2mV6fHe7V3dQSkncMbhlXaQ01i2YBpuD7V8/
ZmQHL2yX
=OxvX
-----END PGP SIGNATURE-----

--=_MailMate_40B1309B-C45A-48CC-9A08-24B5DC789F4F_=--