Received-SPF: pass (google.com: domain of linux-kernel+bounces-59983-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Frank Li <Frank.Li@nxp.com>
To: Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org (open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM),
	linux-kernel@vger.kernel.org (open list)
Cc: imx@lists.linux.dev
Subject: [PATCH 1/1] dmaengine: fsl-qdma: add __iomem and struct in union to fix sparse warning
Date: Fri,  9 Feb 2024 16:08:37 -0500
Message-Id: <20240209210837.304873-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?LcE/rvjsSlNhO0Cc4MhGk5sSRjx2/l4gkkjXe34jvAPeHQZdEMNMfN0OkFhE?=
 =?us-ascii?Q?aNyWAGzQkK+AVe+Y3ky8B5ZuTv3axR/D4DrTvkIyMp611kFvwYbWKwy3OTAu?=
 =?us-ascii?Q?ajafU9SBoKc8o9YQloHQ8fZZHQtFUhA6AFbyjU6xdrbTI8UiClyDiOYIh6wX?=
 =?us-ascii?Q?FpI8FOOefIyPP4yD+zcsGcygKXIVlI7vDNOdDt0JbiCtRA95+vJz4LBDTV75?=
 =?us-ascii?Q?Dx6SXbzy5RDggGpNWtvi7NqEOrOXsLsaMssvuxDAiZwrhw65yZnCI1lHzFab?=
 =?us-ascii?Q?1U72CnAWkoy/emXte2p6JhkA9NrrGmBPmqjPTmYs6kdfMWWx2Fs2CXsb1ezC?=
 =?us-ascii?Q?OrFXHIvH3eBTlrNfh8Tk2wPwo2wfM9sQUDNFSs3+a6/Vb9Z8bUCnF8hA25Tr?=
 =?us-ascii?Q?Va5TmxehNlWU3kQucXMv29m7naLKQEAEehyEgK2jWo/QirPN4F21pwgA4Oay?=
 =?us-ascii?Q?gyfQBtiyVjL4Wo+BUGPKXwiAJL5agptOc002YFfJrpcgNL1/Ug4VOfJjTxr+?=
 =?us-ascii?Q?0IoAG2c28AKxsdx8nhz1L8gowt3lXBeP+cUw3tWiEQI1Z1eN+r9y7jVEZk8r?=
 =?us-ascii?Q?gVoSQvpsHXJWCYG2SmXcdJXzmdVaxzJ7MICxbz8plQZj/slYXwmVKoMypu8W?=
 =?us-ascii?Q?iap/irN34OfzmmI0JhlzuNX/RQM5jsIdj+LNUKZ9PI4xDwmtOQlCGtUuf76m?=
 =?us-ascii?Q?OeUlqCBPjsWtkLylgO8DKasJ8byKdG+eS49wFuJ+qDkOgX3Bnhknt1quSJSZ?=
 =?us-ascii?Q?bh2leAeEoXNl7oX8Yk1NAA1AnoCc1wJMDmxLfN8PwKnemC0Cc4KhBgDrjXIy?=
 =?us-ascii?Q?r1FHKcncym/+fhn3ajW3r/HkTaDt2XpJStCl/awzU0qc/3vA3m/R7unyZKXL?=
 =?us-ascii?Q?xo0Dy82awSb28F9rD/gHkekM1hF/bU44OzPakv+h99I/6xQo9r+otCV1vjYM?=
 =?us-ascii?Q?hqcIlOuXcO8jtJL7U3BkQobCSDaNYAFb6DftMJ5lrCN+g9u3d8/1aTxIXFiP?=
 =?us-ascii?Q?fxCOaGoSCp1XaNX/YMqyNgsNDcbd++I4KdAlRykrhrnI6viKVhtkK/gqi0sO?=
 =?us-ascii?Q?LFWIprZJPNXIQB5oxG3W4lfIu9lOpkiEvGTn0TReQPzv28ll0FRRu2EZasD0?=
 =?us-ascii?Q?lpAP5RIdmnmicSmExMPM9cJPKDM/vjSJ72xeo0Cix28lD8G6PtdqfEsLjZkl?=
 =?us-ascii?Q?ZaDIu4O3kRCJzgydWrwBQFOYE5wnJRBUdfKZ8jNt82tYOPVPXnYzdyefem7t?=
 =?us-ascii?Q?EhqBayJlpw0Q/xJtOJzOzJamPAHHH3+XM8eIFyFTL0ktqo3esX1Tr27cN/L6?=
 =?us-ascii?Q?R+5Tmyx1vmt5CHjyTezNiTQ5eeLXLvda/WKwLKEkPD71IpkFVlJMOpPpBZHk?=
 =?us-ascii?Q?2vwAT5zfjayGL5a91rYhW4vZWPwwiTaF/Ap2PYymwENzZ4hWsDE8635QNOjU?=
 =?us-ascii?Q?vcJfXJcaJb6wIuiSihWMwduXoZ0VGbKd2aEGgnexjMNh8PAs8E8/yDrVkOT6?=
 =?us-ascii?Q?gETxg2R6G78Gf6kH80JGZ75D/LgLCHRmro+pvxdU8eYwZyZZ6Er/DQsyFHje?=
 =?us-ascii?Q?4L86pbuunLi2ksZOcN0cdQg9sgUni2gb4pqtQqEP?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8eb1f4d6-29b0-4550-e631-08dc29b35180
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 21:08:52.4620
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cjkQr9I7RYrMjRguWyD30NMGxpFzYn246qOK4EPnoftaFcg6Crx8r7O634Obb0b6PyPW0fN2g/YkRyMe0Du/3Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8226

Fix below sparse warnings.

drivers/dma/fsl-qdma.c:645:50: sparse: warning: incorrect type in argument 2 (different address spaces)
drivers/dma/fsl-qdma.c:645:50: sparse:    expected void [noderef] __iomem *addr
drivers/dma/fsl-qdma.c:645:50: sparse:    got void

drivers/dma/fsl-qdma.c:387:15: sparse: sparse: restricted __le32 degrades to integer
drivers/dma/fsl-qdma.c:390:19: sparse:     expected restricted __le64 [usertype] data
drivers/dma/fsl-qdma.c:392:13: sparse:     expected unsigned int [assigned] [usertype] cmd

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202402081929.mggOTHaZ-lkp@intel.com/
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/dma/fsl-qdma.c | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c
index 1e3bf6f30f784..5005e138fc239 100644
--- a/drivers/dma/fsl-qdma.c
+++ b/drivers/dma/fsl-qdma.c
@@ -161,6 +161,10 @@ struct fsl_qdma_format {
 			u8 __reserved1[2];
 			u8 cfg8b_w1;
 		} __packed;
+		struct {
+			__le32 __reserved2;
+			__le32 cmd;
+		} __packed;
 		__le64 data;
 	};
 } __packed;
@@ -355,7 +359,6 @@ static void fsl_qdma_free_chan_resources(struct dma_chan *chan)
 static void fsl_qdma_comp_fill_memcpy(struct fsl_qdma_comp *fsl_comp,
 				      dma_addr_t dst, dma_addr_t src, u32 len)
 {
-	u32 cmd;
 	struct fsl_qdma_format *sdf, *ddf;
 	struct fsl_qdma_format *ccdf, *csgf_desc, *csgf_src, *csgf_dest;
 
@@ -384,15 +387,11 @@ static void fsl_qdma_comp_fill_memcpy(struct fsl_qdma_comp *fsl_comp,
 	/* This entry is the last entry. */
 	qdma_csgf_set_f(csgf_dest, len);
 	/* Descriptor Buffer */
-	cmd = cpu_to_le32(FSL_QDMA_CMD_RWTTYPE <<
-			  FSL_QDMA_CMD_RWTTYPE_OFFSET) |
-			  FSL_QDMA_CMD_PF;
-	sdf->data = QDMA_SDDF_CMD(cmd);
-
-	cmd = cpu_to_le32(FSL_QDMA_CMD_RWTTYPE <<
-			  FSL_QDMA_CMD_RWTTYPE_OFFSET);
-	cmd |= cpu_to_le32(FSL_QDMA_CMD_LWC << FSL_QDMA_CMD_LWC_OFFSET);
-	ddf->data = QDMA_SDDF_CMD(cmd);
+	sdf->cmd = cpu_to_le32((FSL_QDMA_CMD_RWTTYPE << FSL_QDMA_CMD_RWTTYPE_OFFSET) |
+			       FSL_QDMA_CMD_PF);
+
+	ddf->cmd = cpu_to_le32((FSL_QDMA_CMD_RWTTYPE << FSL_QDMA_CMD_RWTTYPE_OFFSET) |
+			       (FSL_QDMA_CMD_LWC << FSL_QDMA_CMD_LWC_OFFSET));
 }
 
 /*
@@ -626,7 +625,7 @@ static int fsl_qdma_halt(struct fsl_qdma_engine *fsl_qdma)
 
 static int
 fsl_qdma_queue_transfer_complete(struct fsl_qdma_engine *fsl_qdma,
-				 void *block,
+				 __iomem void *block,
 				 int id)
 {
 	bool duplicate;
-- 
2.34.1