Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp1220213rdb; Fri, 9 Feb 2024 14:24:03 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV4CDthVHINrgd6A78Hrhz5W3p+NXvfI2Z16R91Su5IFBm7r+kCILtBngp2WxGBlEpsUpx2xa91fpAF4QgrlqrSmdYCBgS8GlGPbJr/ug== X-Google-Smtp-Source: AGHT+IHffNWGw+PnvZrBBKKFxEpmEKehONIBFTwjXc9Fro2ZRYiXTOKwVSEwo2BDS+bcpRDwvN6W X-Received: by 2002:a05:6a00:938a:b0:6e0:6bc7:15e8 with SMTP id ka10-20020a056a00938a00b006e06bc715e8mr844278pfb.12.1707517442733; Fri, 09 Feb 2024 14:24:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707517442; cv=pass; d=google.com; s=arc-20160816; b=AQDh98IvAjXShfqh9GvUaVsmxaYkp9sshQUwb/OgxLTKG+jAcIPidDRGCcbqWHlPgb G4CsmXjV/Y/Q2UnpstJhQqgKs+azcJ5+oqPNXw+APyFewc7G36ie7sc65YqaRY5OeFHm qV0S2tuFOQckDiTVPx7sYyCd41jTBvTcKT1I/4YCLullxJdJJVeRyMXOHUPBgWv4IrSW WqRUS2tw45KhGNTTzb1RWi0TMbog2fo8sEzkZefdPiHSlT4hUBgrzshjBwtXTfZNWBk0 Ww7EdHNLh3ryJeF258uhys25ovPyEAGXFnKxFENts/C38FffQbOhPLeyIdq7Aaltj2QM PPmw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=kFBqGaHGo+G/Mn5cg3R+zhPChtWpwDNacql0Uu34s3k=; fh=Hp3nNIhzBDkkkHsJuI4ROF+Hyr5dbsQaC4n9r1gLsBw=; b=zSGqURJL0qgRfgivTUqTx7pl3dIr80SovnmVOhOhZX4BaDAtWR1JDDngR8kxMPCUVh BrRm6ZuXAsxsxzp9REoD430oZi+gx+NEWGuwsvZwgRIn1hA8NOb6RmW+A95lUtxM2BVe k4JO32NrN3EHGr65USN7yY1bLT3e3i0nRxZctd/+9d5sct5/2brvnaWa/YsgvrvEqWus 0kVrEwcvtP3Uj7Ytm6IshrbXGnOYjP1sl3VW5mRaM5bLPPNvmnFD2wPcZymDhTX7d8gc LqP5eSvkjt4Vz7Xq25vBNaqLKofS6h9dLI2PV4PjG+lBZQE5FbwcLiX0r+Uez5BStqLM czBg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qcBCEuri; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-60059-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60059-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCXLLY8vsQGmHhIG64l3jzdf1LhVrr4OEZCkLTA2LSgdYFH4Q1GzrAQ/uQqum6XxZVEsXkypp0uUBRuVIK1s7KsZjxVOtvMfSAW3d0FoRQ== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id by13-20020a056a02058d00b005d71b72c632si2619776pgb.81.2024.02.09.14.24.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 14:24:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-60059-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qcBCEuri; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-60059-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60059-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id BDD6CB28E3E for ; Fri, 9 Feb 2024 22:00:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 62AB228E11; Fri, 9 Feb 2024 21:59:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qcBCEuri" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 744B420DE8; Fri, 9 Feb 2024 21:59:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707515986; cv=none; b=rW9W839hcxe/Qcf2kokBBSsJg67fdBQVfTPNoSY7WWS2lMhiQiG379JZWxBv+93YNil0wM+//3yvTzRRfkhgVXVJVVw3QvYm5jpk5nM/BeUFW1aSoa8iHMoSmm/EWRwrFnQY93M0Uc1b5+9Dujvwj55c8q6KIH0JcmFjdFY5NYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707515986; c=relaxed/simple; bh=N+nalO7T63dk1WwyO167dEeC237jLd+fkrNm8eoIfRc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uWf7KDR8klQREDc9uyzba4Ut4O/6TpevQeDYqHC5hb3WY0EsbTD9PVgb2qZ3eKNuenZ7iR5syV0nSiDywvn6lW3pKxBoQq1fwpjXInw/nKPhblTbrfrUg05dJnD07QpKTzO+T/m80x+jZUVCoXIpeZMCLphXl8rwBgrxNwYvB5w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qcBCEuri; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78A3DC43390; Fri, 9 Feb 2024 21:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707515985; bh=N+nalO7T63dk1WwyO167dEeC237jLd+fkrNm8eoIfRc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qcBCEurixvSanBDZzwL/H8t1HAlZhS40hckT9FvmrXI8rLg0aeNS/pHPXojJ6h2cP DkHNV8JDpkLdHyD56aqjR8urUzxQEsH0Nh2dAciHBGEkN0dvT3UHFJgKOavQym4nRb khtEgxNdLP2T5H5aVR833gVKMiP50GYc0VmSvZ5Halv9WJxUFNYt9ctfo67oRYworG RYIDZx8HkznRW4XFBxFoZ745UaV3vgExTnxM/+coYSGX0eR8s+0C0BE0VQAOXa3fFb cB4j+VZK6YH+xq5y6N7QkJY/XOa4KHh+0KFXf+q2K7C91Yz8kVIn2DTJbe4Dv+R9eH ov2alAP0HkhHQ== Date: Fri, 9 Feb 2024 13:59:44 -0800 From: Jakub Kicinski To: Andrew Lunn Cc: David Ventura , Jonathan Corbet , "David S. Miller" , David Ahern , Eric Dumazet , Paolo Abeni , Greg Kroah-Hartman , "Paul E. McKenney" , Randy Dunlap , Xiongwei Song , linux-doc@vger.kernel.org (open list:DOCUMENTATION), linux-kernel@vger.kernel.org (open list), netdev@vger.kernel.org (open list:NETWORKING [IPv4/IPv6]) Subject: Re: [PATCH v2 1/2] net: make driver settling time configurable Message-ID: <20240209135944.265953be@kernel.org> In-Reply-To: <20240208095358.251381-1-david@davidv.dev> References: <20240208093722.246930-1-david@davidv.dev> <20240208095358.251381-1-david@davidv.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 8 Feb 2024 10:52:29 +0100 David Ventura wrote: > During IP auto configuration, some drivers apparently need to wait a > certain length of time to settle; as this is not true for all drivers, > make this length of time configurable. Please CC folks who gave you feedback, Andrew's is missing. Andrew, what do you think about just removing the wait? Or decreasing it to 1ms? It feels a little wasteful to be adding uAPI for something which as you said is likely papering over ancient bugs. We'll fix the bugs which are still around and the uAPI will stay forever :(