Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp1221494rdb; Fri, 9 Feb 2024 14:27:29 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUomK4CUAnv4uEfVZ+BpXlFx35zelxYR7PLzIr4WrPDmsiiWEpchmKaesNMevhe47GsOt2DRzeV+S7EYL5HoKy0OkMG2uKBOJoF27Vveg== X-Google-Smtp-Source: AGHT+IEhfPsSssKl6/s6ifiaYbeu2B7ou8XswU2m992IZ5oIeKdTECOOP0DcCpO7TXmGvqBCHeCN X-Received: by 2002:a81:9293:0:b0:604:5b3:d7e8 with SMTP id j141-20020a819293000000b0060405b3d7e8mr592289ywg.11.1707517649481; Fri, 09 Feb 2024 14:27:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707517649; cv=pass; d=google.com; s=arc-20160816; b=jJyEAiSTijo8ftTzAD51ksYlcZbummqeLLJtWVZR2wZk+TgsmCAnQQEyIcPbChl0Ba zD0IkTnOrZlMjy2JL497f/dOC9LFe1Zoyc/bAiaLYznsXJo7yXG4nCyXBNo0HV0SL0aS yUVRJOfT5/RHz8QS6pTZ+Mrm18VF0+tSntkDGnsM8rnBhmmZSwho0k1CEbK1ATCDfUlA 9pPUbZtFxMKpuLxvqewNW8t6xJx8pXekcPpcJG3cgXcgyQlYiYs/V+Hxl2Kq5rSmYid8 UfCEMYK6NMxiLgs0LAQT3sNlFdP3FC81CDR+eLTmstPTP9039VPwm5zknNaUF66g/p19 H9zQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=t6k3/hNhfT8OBOt+8bHq1TqgaZynDusRkHF/Hl9r4Gg=; fh=KOMsSczf/QeGiYb2PyCrQWwvqnVqoEUoTldg6u7dGss=; b=v7QdI00vkm8O4BMm0m9zFZRT1pktYvMnVarbEz/n2UP6NanC9wJfBIeC7bas2G1aIO g0tj08WqXLEngk1Wx4bDBLScrMk91E8UkiC9lUF/7YLxyHmt0e2P0IPYLoAy6/fvEH78 PPvu4dC9GcXzEpmVgSC90OTPW+XqjfqD+nSd7kKIaHXUdwbhBcYM/A67y6oueVHWEFSm IiDBbPN6KDTrdwliHQjWuE4JkJNJ4HAdpHg3KacheONGY1K4PGgPkjPTXVkKMNVa+CjC mPE5GW+wtUYaCkASouOnMSAsQdMnUx35B5ikxYz3pzc3ReO6e/dhaKH6C1xq2PniHlD2 rcAQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Xs//XXqW"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-60102-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60102-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCWCF0C/jMucSLmYAWFNYDomMGkAGv7DAwV9f1efYuDDYKZhZ5wzCc++A9I/9rmP/oed89M6QbT3A1wkHIWkDJ8Q8+wzmgIWdXWsqb11kw== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h20-20020a05620a401400b007856325a291si477233qko.714.2024.02.09.14.27.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 14:27:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-60102-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Xs//XXqW"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-60102-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60102-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3DE0C1C223EA for ; Fri, 9 Feb 2024 22:27:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 10AC136125; Fri, 9 Feb 2024 22:27:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Xs//XXqW" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3666F538A; Fri, 9 Feb 2024 22:27:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707517637; cv=none; b=WkL6xPU5U6TBo5RWoGC+DEIfsMg2TIl9sxLjEMW/PiGZLjFJauleeYeL4ULKc2vi+5filP7kA+AcfbCE1eVjaGG2NsPd0fHGb70e5w+yp7SOmgL4KIi1PAn5E3ePXq8ts5sV28OTxhZhJZVgsZTqQvlxUkE/bKvA2I1qjL78cI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707517637; c=relaxed/simple; bh=XKSPUWEMjH3vv5ObtYK5tHZ32yK2oms1MOCSVnvaXBk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dv1tPQLLpE9Y8fqnVmsqFlNE/MPTpL4j9ViBWPGUMW9gqGrvNTNbQuTNdHi/+UJ4SKWVNywkf51oB+G2svP01Blk/9y6InapYvBXIk/aSa0JFiIH8ij6pg8SunORiYBDaHVvaZ2RD6sXLtKw5e68iFdRoM4ne7+gc4OiKcYsaH0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Xs//XXqW; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1577CC433C7; Fri, 9 Feb 2024 22:27:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707517636; bh=XKSPUWEMjH3vv5ObtYK5tHZ32yK2oms1MOCSVnvaXBk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Xs//XXqWfXd1kOPFVH0FAG5j+y5njvDIJz/H/GBAwlwZc2hBhOAJcA95LBuxunAwE K2PBBKcYjUfe262dL4Qps1duHltv4w6crA+CWukamxxWojctSm1fqMyBhv4ktaUQLg MDnpjxpz5Ey6lp/Rl4Ei2dg8OiRT9ug0aZjWLjWFcXRnf15uA0NGKQipRuuRjoBP/7 U/F9hUgebbFLLs9WLeR3hTAWSViivY8qdxJMQPpJZRijl1LpPBUq89lhtmWJxx0kqp IciWXsI4CytcnhUaDRZJFLZNS+Pu+ItTBU2Ki309lsUzncfj56iTsE6xsTjRlZ9ED5 ax7w9CV8aXioA== Message-ID: <06b1be40-06be-4bea-b79c-ec869dd60a2c@kernel.org> Date: Fri, 9 Feb 2024 15:27:15 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net] ipv4: Fix broken PMTUD when using L4 multipath hash Content-Language: en-US To: Suresh Bhogavilli , "Nabil S. Alramli" , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: jdamato@fastly.com, srao@fastly.com, dev@nalramli.com References: <20231012005721.2742-2-nalramli@fastly.com> <20231012234025.4025-1-nalramli@fastly.com> <4be64c29-f495-4fdb-a565-2540745d5412@fastly.com> <9d636726-514b-417f-ab46-6f570a563eed@fastly.com> From: David Ahern In-Reply-To: <9d636726-514b-417f-ab46-6f570a563eed@fastly.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/9/24 10:11 AM, Suresh Bhogavilli wrote: > > Does that answer your question? Do you need me to make any changes to > get your Reviewed-by? re-send the patch enhancing the commit message with what happens for different policies. Would be good to get a unit test added to tools/testing/selftests/net/pmtu.sh (ipv4 and ipv6)