Received-SPF: pass (google.com: domain of linux-kernel+bounces-60142-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <890de365-f844-4ed9-af9d-90f5ff4bccbd@oracle.com>
Date: Sat, 10 Feb 2024 10:19:24 +1100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] connector/cn_proc: make comm length as TASK_COMM_LEN.
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
References: <20240209121046.1192739-1-imran.f.khan@oracle.com>
 <20240209075032.1deb447a@kernel.org>
Content-Language: en-US
From: Imran Khan <imran.f.khan@oracle.com>
In-Reply-To: <20240209075032.1deb447a@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?bUpvbXlZTThlWWczSEJKQTR3WU1ZZmJnRTU2eWVDdDBaOGdoZ0NKR3RlVUdO?=
 =?utf-8?B?VjhLNHNtYU85N3k3ZVppd0o0b0QxTytiaEVGdGlIV3RIZEFHK3NOZmNlbXpT?=
 =?utf-8?B?MFBPcWVldzJjUHNIWmhZZTZkeVhTaXI0a0xWazRFR1JBMStvaURxa1FvWU1h?=
 =?utf-8?B?clpvV2F2VGx1SS9SaW9UQ2xlemFta0hkY21jSUlCbGVDUEtpZWtNLzNDUGZ2?=
 =?utf-8?B?R1E5cTlzUHFtTVR2RGtXMEJrcDZSLzgzSWk3QzJPdktzcW1vRVdNWHQ0MURh?=
 =?utf-8?B?aWdpZ3RRNkFCYjI1OXJCTk9OYndCRTlrT3JpcmYxSFBjQkFHUVZGVTlUbnZt?=
 =?utf-8?B?OS9JMjdqc3hZQzcwaGhlSTJmbUoxYWQzcHFjcjZyQXNqdFhpTWcvcE9WNGRT?=
 =?utf-8?B?dWpDanBjS09CTHZ1NnVGMHVSV0k0VXlxOHNNUjBrc251Q0Q2aUNTczJkc0NG?=
 =?utf-8?B?OS9BQmJaNlE4RmNJcC9wN25qZFFVdUpXUjVrS2pSMWEzeTQwOWVjdWVGTXFt?=
 =?utf-8?B?TGc5Vm5LWUNhUmZDVkZIN2tUVzFOakdOMmR0OVJ0Z0tzVEMrR1RqRnpDbzlm?=
 =?utf-8?B?eWZsbDBvM2FxZ0J3VmZRZGtNOE5oNnYvbUpGYnp6THlUaVFwaW1YWXJmYWl4?=
 =?utf-8?B?bTFSaFhoMm85Rk8xUHFFQlhsTjVuaithODhVc1Njd3QvdGxKSGN6ZW96bUxm?=
 =?utf-8?B?RldyS1VLaEs1c3NDTGVLRjVma2hoc3FlU1dOV0g0WTVuakhtZ1lURnJ6NE9M?=
 =?utf-8?B?ZGdTVS9RNDNmbGNzejhHakxsaXNzcmJGWFZOSUkwYXlqMXV6MURuZzE2aFhq?=
 =?utf-8?B?cHd0YVF1Z21ld1FlNDdnSjBLL0ZsckZnbWlUUldTQmdocW1UY0czQ2lXUHVV?=
 =?utf-8?B?RjdCOTZWeVBQTFRVSXNJZ0lPUnBXK0w1TVBjUkYvNncrenZEejJNbWlGcVd5?=
 =?utf-8?B?YUgwVno3Z21JNnc2bGJ4WVFJajc1eEFGazBwa05HUkRBZEcxTXNJZjh3Vm96?=
 =?utf-8?B?aGc3RWNLZTNiWVZiRWFjTHl2VGFWT3lkT3JQdU9Zb1RzdVdlK3RNdkphYllN?=
 =?utf-8?B?ajBwM2E3UXVSUEJmSGNmbW8ybEE1aGxQMFN5YTBRS0Q4MGRJT01oeFJkWmJz?=
 =?utf-8?B?NjBMekxwUDdVdVN0R1dEL2xXenk2V2pvaGhOaEFucWNiMkZGVlhmUUx5MTJr?=
 =?utf-8?B?aGZXL3lBSmJOc2p1NXNjRGtXRXNBSGNCbmNUZ3VqUS9SNVdPNWZFMjA5NDJ3?=
 =?utf-8?B?V29Da0JmUHlvQ1BuZFVoK1pmWXB3SXloN3BWT0paYnpzU0tFQ1JRTXhWOWN5?=
 =?utf-8?B?QzF1Z2d6c2VQS2cxTnhOWTc0MDN6RXBPem9nRi9RNGV0TEZ4U2o2V0R1K09q?=
 =?utf-8?B?MTZKMzB5UW00RFlWUGxrSlRIdEFOcE1DbXdUeDZlMFZUSHZkUGhvNzQydVpU?=
 =?utf-8?B?WjFtVU9VZ0dJS0piSkt4ZzZBTVFOUGx5c1RTVGtTK25tbmgveHo4N0lvdjVy?=
 =?utf-8?B?cW1QQmNRV2d0aDhkUGdXd3M1SC9KQnpaY2tFN3J0TFpWMEdnZmNhUGRtTys4?=
 =?utf-8?B?M2lGYjdYei9FYVNzc3ZhOW9ZYzFXK1pIU0drWk9kUFFxalB2MEphc2hMSXZP?=
 =?utf-8?B?KzBMTU9ocDczNUxVVW5Vc2NubFcyRnNqRkpQazdpTUFzejJFYVFpYUZBM2tK?=
 =?utf-8?B?Mng4YW1DbCtSWGRXUlFlakg3dHM3RFRiWmdWY0tnZmwvMStnaFRSZFVuUlI3?=
 =?utf-8?B?U3VSdk9jZHdjYVVvamc1WXN0eThNOW56M0xwZG9QL0RzcUtVaVdnOFY2aHZ3?=
 =?utf-8?B?SmhWeXBwYmNnWFgxNlBoT0JlZ1l2dDVwYlYrS0pGT09yd3lzZmQwc29IMUp4?=
 =?utf-8?B?ejRiU0wxcWViNFZONzlnNzl0V2JNNW0wV2p6djFIZWkxN1FkMERNTzRSbzgz?=
 =?utf-8?B?d2NsM3ZKR05yb3JKdzFqMksyQ2RnMTNUbVJCcmxlK2NUek9DWWd3K0lVK043?=
 =?utf-8?B?N1Q3bWNhU2hlVXdYTWFyMllNUjFuSndGRWZiQzhKd3RTS3NrUzdTVWl5WHps?=
 =?utf-8?B?MjNrSGlRWUtvYm40Z0NVc090bVA5NUVCZHBQOWpYU1NicUdpaWFPRXI3Z2pR?=
 =?utf-8?Q?skHLBMxebjQ7mgZukBH+2tIkW?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	kn8uiZi4w1xXgbApWDH2PRf+opOQjfN8KnobRtBbnoeNcQ90tU9rFDhfE1lV1E6cHr+uNg/Lx5p+LpHja2kMwTYEkX9YZ8IT3ysbw7JFuaC18PCg5pwvcFFTxPzxev0Nfl9iqLRD+8HR4p2v6vbIc2AF+3tILcVGzo6dseLTAdYKdRtDHLcksD8J5WVUd2qwCTBlTyO0UcCainPPZO/lhzrqGElEH9+c5Fi3+Ocg69Z5A0op+amNZcnBNG8Eu6Ok2hBTENG/vLXfYVnPRRiHJTTIz5y+gHptLfsNWUDPd9liS4R6wxUUVJ0bziwSsRS5WyH4r2slS9GkyczqgdkT4cer836nmQ+xUPnllJ+AMrKNQnyP9iVxi6z5UT9TpNmLE+aMuE3dpEUP7fMi1ZMXkx84G9YbvQiN9elucRVSt9v7yza+4szEhhibWXHQVyv2L+WoV8VnYSsAe5DOP4sUtPTlHQM1BkQXbDKqK0mdEBJemhFjrYMyxMayxgooeflT8nV6lKDuWBNXFxLiIcXQR5O3XFCSXkJlnBGYV1XWY+ODqvE84rI04drRvTfQO7ePlUsFZR6zqAiakuRImYWgukAONMs8lAQUXc3hjyhr9mc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b4deaf9-fc09-44ed-7e30-08dc29c591f9
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 23:19:31.9009
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +EFRsD7PrtQ7NAXn4PcEEbKGt07+97oqrToXW+sXMAk5CGy/9WCbEjtKTo2fazM1bupUx3btsv+0IgVyJudRHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR10MB7628
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-09_19,2024-02-08_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 mlxscore=0
 adultscore=0 spamscore=0 malwarescore=0 mlxlogscore=666 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402090171
X-Proofpoint-ORIG-GUID: 6wvw7wYFi2bC69YacUP779m3JmAY9q_Q
X-Proofpoint-GUID: 6wvw7wYFi2bC69YacUP779m3JmAY9q_Q


Hello Jakub,
On 10/2/2024 2:50 am, Jakub Kicinski wrote:
> On Fri,  9 Feb 2024 23:10:46 +1100 Imran Khan wrote:
>> Since comm_proc_event::comm contains a task_struct::comm,
>> make its size same as TASK_COMM_LEN and avoid magic number
>> in buffer size.
> 
> missed CCing netdev?
Thanks for getting back on this. Actually get_maintainer.pl for cn_proc.h was
not showing any maintainers, so I took the "To" list from cn_proc.c.
For CCing I stuck with what get_maintainer.pl was showing.
I have added netdev in CC now.

Thanks,
Imran