Received-SPF: pass (google.com: domain of linux-kernel+bounces-60177-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240201001504.1348511-1-irogers@google.com> <20240201001504.1348511-8-irogers@google.com>
In-Reply-To: <20240201001504.1348511-8-irogers@google.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Fri, 9 Feb 2024 16:21:51 -0800
Message-ID: <CAM9d7cih+JqmhVOSoYmRUK2+FRWnknQ6VucYpg5ZC01BYqdv=Q@mail.gmail.com>
Subject: Re: [PATCH v2 8/9] perf srcline: Add missed addr2line closes
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, 
	Arnaldo Carvalho de Melo <acme@kernel.org>, Mark Rutland <mark.rutland@arm.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, Nathan Chancellor <nathan@kernel.org>, 
	Nick Desaulniers <ndesaulniers@google.com>, Tom Rix <trix@redhat.com>, 
	Ravi Bangoria <ravi.bangoria@amd.com>, James Clark <james.clark@arm.com>, 
	Kan Liang <kan.liang@linux.intel.com>, John Garry <john.g.garry@oracle.com>, 
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, 
	llvm@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 31, 2024 at 4:15=E2=80=AFPM Ian Rogers <irogers@google.com> wro=
te:
>
> The child_process for addr2line sets in and out to -1 so that pipes
> get created. It is the caller's responsibility to close the pipes,
> finish_command doesn't do it. Add the missed closes.
>
> Fixes: b3801e791231 ("perf srcline: Simplify addr2line subprocess")
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>  tools/perf/util/srcline.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c
> index 034b496df297..7addc34afcf5 100644
> --- a/tools/perf/util/srcline.c
> +++ b/tools/perf/util/srcline.c
> @@ -399,6 +399,8 @@ static void addr2line_subprocess_cleanup(struct child=
_process *a2l)
>                 kill(a2l->pid, SIGKILL);
>                 finish_command(a2l); /* ignore result, we don't care */
>                 a2l->pid =3D -1;
> +               close(a2l->in);
> +               close(a2l->out);

I was about to ask the stderr, but addr2line_subprocess_init()
sets a2l->no_stderr already.

I wish it could be handled in finish_command() but it seems
the API allows setting external file descriptors (before calling
start_command).  Hmm..

Anyway it looks like an independent fix.

Thanks,
Namhyung


>         }
>
>         free(a2l);
> --
> 2.43.0.429.g432eaa2c6b-goog
>