Received-SPF: pass (google.com: domain of linux-kernel+bounces-60214-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sat, 10 Feb 2024 02:20:29 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>,
	Robert Marko <robert.marko@sartura.hr>, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [net-next PATCH v7 03/10] net: phy: add devm/of_phy_package_join
 helper
Message-ID: <1787d720-1890-4ee4-82ab-5eb973c279d6@lunn.ch>
References: <20240206173115.7654-1-ansuelsmth@gmail.com>
 <20240206173115.7654-4-ansuelsmth@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240206173115.7654-4-ansuelsmth@gmail.com>

On Tue, Feb 06, 2024 at 06:31:06PM +0100, Christian Marangi wrote:
> Add devm/of_phy_package_join helper to join PHYs in a PHY package. These
> are variant of the manual phy_package_join with the difference that
> these will use DT nodes to derive the base_addr instead of manually
> passing an hardcoded value.
> 
> An additional value is added in phy_package_shared, "np" to reference
> the PHY package node pointer in specific PHY driver probe_once and
> config_init_once functions to make use of additional specific properties
> defined in the PHY package node in DT.
> 
> The np value is filled only with of_phy_package_join if a valid PHY
> package node is found. A valid PHY package node must have the node name
> set to "ethernet-phy-package".
> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew