Received-SPF: pass (google.com: domain of linux-kernel+bounces-60251-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 9 Feb 2024 18:45:56 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>, Daniel
 Borkmann <daniel@iogearbox.net>, Andrii Nakryiko <andrii@kernel.org>,
 Martin KaFai Lau <martin.lau@linux.dev>, Eduard Zingerman
 <eddyz87@gmail.com>, Song Liu <song@kernel.org>, Yonghong Song
 <yonghong.song@linux.dev>, John Fastabend <john.fastabend@gmail.com>, KP
 Singh <kpsingh@kernel.org>, Stanislav Fomichev <sdf@google.com>, Hao Luo
 <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>, Jamal Hadi Salim
 <jhs@mojatatu.com>, Cong Wang <xiyou.wangcong@gmail.com>, Jiri Pirko
 <jiri@resnulli.us>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>, bpf@vger.kernel.org
 (open list:BPF [GENERAL] (Safe Dynamic Programs and Tools)),
 linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH net-next v2] net/sched: actions report errors with
 extack
Message-ID: <20240209184556.00cde1a2@hermes.local>
In-Reply-To: <20240209183133.1cc0a4f5@kernel.org>
References: <20240205185537.216873-1-stephen@networkplumber.org>
	<20240208182731.682985dd@kernel.org>
	<20240209131119.6399c91b@hermes.local>
	<20240209134112.4795eb19@kernel.org>
	<20240209155830.448c2215@hermes.local>
	<20240209183133.1cc0a4f5@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 9 Feb 2024 18:31:33 -0800
Jakub Kicinski <kuba@kernel.org> wrote:

> On Fri, 9 Feb 2024 15:58:30 -0800 Stephen Hemminger wrote:
> > > I mean that NL_REQ_ATTR_CHECK() should be more than enough by itself.
> > > We have full TC specs in YAML now, we can hack up a script to generate
> > > reverse parsing tables for iproute2 even if you don't want to go full
> > > YNL.    
> > 
> > Ok, then will take the err msg across all places using NL_REQ_ATTR_CHECK?  
> 
> Take _out_ ? That'd be great, yup.


I don't think that is actually a good idea because new kernel needs to still
report errors to older userspace iproute2.

This is kind of academic hair splitting, iproute2 doesn't send these kind
of missing part messages. It is more from test suites, or from custom
user programs; found this when looking at DPDK device driver that was
sending its own netlink.