Received-SPF: pass (google.com: domain of linux-kernel+bounces-60133-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <e8378ba2-ccd1-48fe-973d-38986fc0716d@infradead.org>
Date: Fri, 9 Feb 2024 15:00:44 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 02/13] security: Introduce the digest_cache LSM
Content-Language: en-US
To: Roberto Sassu <roberto.sassu@huaweicloud.com>, corbet@lwn.net,
 paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, shuah@kernel.org,
 mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, mic@digikod.net
Cc: linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
 bpf@vger.kernel.org, zohar@linux.ibm.com, dmitry.kasatkin@gmail.com,
 linux-integrity@vger.kernel.org, wufan@linux.microsoft.com,
 pbrobinson@gmail.com, zbyszek@in.waw.pl, hch@lst.de, mjg59@srcf.ucam.org,
 pmatilai@redhat.com, jannh@google.com, dhowells@redhat.com,
 jikos@kernel.org, mkoutny@suse.com, ppavlu@suse.com, petr.vorel@gmail.com,
 petrtesarik@huaweicloud.com, Roberto Sassu <roberto.sassu@huawei.com>
References: <20240209140917.846878-1-roberto.sassu@huaweicloud.com>
 <20240209140917.846878-3-roberto.sassu@huaweicloud.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240209140917.846878-3-roberto.sassu@huaweicloud.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi--

On 2/9/24 06:09, Roberto Sassu wrote:
> diff --git a/security/digest_cache/Kconfig b/security/digest_cache/Kconfig
> new file mode 100644
> index 000000000000..0c47d5151f07
> --- /dev/null
> +++ b/security/digest_cache/Kconfig
> @@ -0,0 +1,17 @@
> +# SPDX-License-Identifier: GPL-2.0
> +config SECURITY_DIGEST_CACHE
> +	bool "Digest_cache LSM"
> +	default n
> +	help
> +	   This option enables an LSM maintaining a cache of digests
> +	   (e.g. of file content or metadata).
> +
> +	   This LSM can support other kernel components in making access
> +	   control decisions.
> +

nit:  -ESTYLE.
coding-style.rst says:

Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.

> +config DIGEST_LIST_DEFAULT_PATH
> +	string
> +	default "/etc/digest_lists"
> +	help
> +	   Default directory where digest_cache LSM expects to find digest
> +	   lists.

Same comment for patch 03/13.
Same comment for patch 04/13.

-- 
#Randy