Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp1335977rdb; Fri, 9 Feb 2024 19:59:00 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWDyJLO+kHLyGAaA2MKAXirDsdGK7NNSmc/hJB83MepWzyg5nUmfhG/oDnssWAa0fp/BIpG5LsOPch64tz090FTf/2s0WY8zowIWR0L0A== X-Google-Smtp-Source: AGHT+IEdJY3vmm0lqcrhO6023I0C3mg3Xs10M3RapX9s8L3NlK1oMTQvDXKgL6RS8PVVMRTtUGuy X-Received: by 2002:a17:902:ced1:b0:1d9:a2d3:8127 with SMTP id d17-20020a170902ced100b001d9a2d38127mr1241201plg.52.1707537540432; Fri, 09 Feb 2024 19:59:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707537540; cv=pass; d=google.com; s=arc-20160816; b=B6j8qZSsD9KpDRc1UJU2QkRxESeO2vOx3uqUZxAVk5FKH0oyTQb51E4XReZIFh/xTZ gSuU5ajx1058F9rJPD0yRwc4YHJJaXyK8Ez4WLJrGVxFRfRJW2DsfCz7MpkxcjXV6V6g //qrb7k2YogZkimEUYhv3hy/11mxz4ZWlbkGLWtm4X/cEaP9ANngp7cCDCP2o9vj6u+1 drWWiGEbbzkxs0WhGUhXhbLveC0JG1fLtIoiwl/MQHUzrFPPtfDkPTSx9VbibZFGlWUX +oUXv8rpBaGazVLKHSu0ShRDuuADCFxy9zfMzQyz8LVxTiG+D0n7iMSpYwZ5cGb/eJOX 7vGA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=IBVqpWZ6N7xxNPeIZbAu+1eyFhOq010Wd0jcNyq4C8w=; fh=fB2mBQ7dV8ZqI36wTnLEV7wL7KU0ay7K/OnLggObnd8=; b=aJuxAo75lnnwz+HJtY/ateV3bSMeDYm/BJAjDvSaqfExrKH4u4zYcdR2GzOhT4tE4l JSjTvlgstog7iGqwwIh0vekqDgb/Om1aZ1eRN5yZdjvHutxae+fwujk4X82Di35S2OLH nx4jj5Y1XpMf5o9O72leQWuD3+AFXL7EQzv3JZfwqM45XcbMZIYX9SWfPGgNbgI4vYPE SfroNNho/WuNuhUEiHnBGpGuEZBLpmGqBZDwKUNfnHQonX/TiC806m3WXqDhqEMLWI9+ VwKJU/6cCN0e9jwx93eZ0JTQ/3UEn9sXFhmAre8JgWFCw/Pqa812ef0C98Q6gnzz8VYn RqWA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="j3eae/Ut"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-60250-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60250-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Forwarded-Encrypted: i=2; AJvYcCX/3Ch88SRlH/RU6hXHIzLZo5PYdzDS1fufj4uv02vo/kaaZNrRsRaKP5FrNdK1v1XjFqKg9YEO3Q8qRIZI91USmpJ9I/8qQf898eiQlA== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id y15-20020a17090264cf00b001da0e441630si2563606pli.625.2024.02.09.19.59.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 19:59:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-60250-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="j3eae/Ut"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-60250-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60250-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 34B7228B0C0 for ; Sat, 10 Feb 2024 02:39:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9E028443F; Sat, 10 Feb 2024 02:39:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="j3eae/Ut" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BEAB63C for ; Sat, 10 Feb 2024 02:39:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707532791; cv=none; b=otw0QXOM6aZKuZIsxQXHTESRNKhp890k9OFhwOsBGAJo5EVHkViHEuIR2KL82MWy0Rhxb12KFQKTn2KXaNzoOi/jsqwMhstaL4p2SpHZlV21BEnCcXSZ09ObuH84aiv6mw15bQ0O9v4dMJZZtP2Oxo9ZlM/YcAuiEaeeWwRyk50= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707532791; c=relaxed/simple; bh=KvmExit0TrANeclOjX4bPITu2Wj408sKc/29bhsRktE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fbxqn/5y4jwEXbpKwSomqV+x/epB6vCkIGhX4jEh4y1jBBNZGEo/PVj+/hnQIWkPfTqnmA9zpsiIZU4Pv2Fvllo4IoqCsNCGlqEFvA2k/tNWtJEXSCK6iHY3n02Mw8ru16dZwZToVNAuAX+NpCRgpM3/MmIuwb3cX4UPviinxg4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=j3eae/Ut; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707532790; x=1739068790; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KvmExit0TrANeclOjX4bPITu2Wj408sKc/29bhsRktE=; b=j3eae/UtTXziLRpflI9ktThe53IM+tacfzsGcuxfjZVsekDJWb6Akjlh okvBPpoKefLpgw/OzoJAswx5edaQIpdcc7aidbxhvqjHsOIovbtbpvUlw VH0IlmEP3ZOxFlVJpDix/KAoBiOERR3njvFoUplwm+33ZM+SVEGTrLspn R1d3kMj+XR+NlPd5GFKBiFnNl9jP4xuCOQ18XUPtaEVtrO/lYlJ2bWkbM 4JJJJ8JDXcISkNa9ebwyRjETppZEFYrHXD6eydaA0iNa7wHZE5S/1jOU3 uEwRF6OWv7ZSeC+eSo4gDdcyLAs3Gwkd8QL/+BKJuVfRGWwN4WhJHGGCg g==; X-IronPort-AV: E=McAfee;i="6600,9927,10979"; a="5384172" X-IronPort-AV: E=Sophos;i="6.05,258,1701158400"; d="scan'208";a="5384172" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2024 18:39:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,258,1701158400"; d="scan'208";a="2077333" Received: from karenaba-mobl1.amr.corp.intel.com (HELO desk) ([10.209.64.107]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2024 18:39:49 -0800 Date: Fri, 9 Feb 2024 18:39:47 -0800 From: Pawan Gupta To: Josh Poimboeuf Cc: Thomas Gleixner , Borislav Petkov , Peter Zijlstra , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Daniel Sneddon , antonio.gomez.iglesias@linux.intel.com, alyssa.milburn@linux.intel.com, andrew.cooper3@citrix.com, linux-kernel@vger.kernel.org, Alyssa Milburn Subject: Re: [PATCH] x86/bugs: Default retbleed to =stuff when retpoline is auto enabled Message-ID: <20240210023947.pefmjmogsxhissem@desk> References: <20240208-retbleed-auto-stuff-v1-1-6f12e513868f@linux.intel.com> <20240210004328.n7uxevxfiqr3gsot@treble> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240210004328.n7uxevxfiqr3gsot@treble> On Fri, Feb 09, 2024 at 04:43:28PM -0800, Josh Poimboeuf wrote: > On Thu, Feb 08, 2024 at 05:12:15PM -0800, Pawan Gupta wrote: > > - * The Intel mitigation (IBRS or eIBRS) was already selected in > > + * If Intel mitigation (IBRS or eIBRS) was already selected in > > * spectre_v2_select_mitigation(). 'retbleed_mitigation' will > > ^ > should be a comma Ok, will fix. Thanks for the review.