Date: Sat, 22 Dec 2007 09:37:17 +0100
From: Sam Ravnborg <sam@ravnborg.org>
To: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: Yuusei KUWANA <kuwana@nyanyan.to>,
       Linux Kernel list <linux-kernel@vger.kernel.org>,
       mikael.starvik@axis.com
Subject: Re: [PATCH] arch/cris/arch-v10/vmlinux.lds.S fix boot problem
Message-ID: <20071222083717.GB22653@uranus.ravnborg.org>
References: <47636D45.6010006@nyanyan.to> <20071221151404.GM10888@axis.com> <20071221155446.GN10888@axis.com> <20071221160718.GO10888@axis.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20071221160718.GO10888@axis.com>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1237
Lines: 41

Hi Jesper.

>  		__initramfs_end = .;
> -		/* We fill to the next page, so we can discard all init
> -		   pages without needing to consider what payload might be
> -		   appended to the kernel image.  */
> -		FILL (0); 
> -		. = ALIGN (8192);
>  	}
>  #endif
> -	
>  	__vmlinux_end = .;            /* last address of the physical file */
> -  	__init_end = .;
> +
> +	/*
> +	 * We fill to the next page, so we can discard all init
> +	 * pages without needing to consider what payload might be
> +	 * appended to the kernel image.
> +	 */
> +	.init.fill : {
> +		FILL (0);
> +		. = ALIGN (8192);
> +	}
> +
> +	__init_end = .;

Can we please have the hardcoded 8192 replaced with a proper constant.
I assume this is PAGESIZE?
See hwat other archs does to make PAGESIZE available for assembly
files and ldscripts. The macro AC is the key point here.

And then please explain why it make a diffrence to put the
alignment in a section like you do.
I do not see it used in the other archs.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/