Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp1430609rdb; Sat, 10 Feb 2024 01:32:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IEMlv6LunVA4BWCz/YoRN2yiRgjXN4p3627H14X5xMulgN1XevNit4ws0QycN/jciChR9GB X-Received: by 2002:a05:6359:459d:b0:176:d1ed:aedf with SMTP id no29-20020a056359459d00b00176d1edaedfmr1656814rwb.0.1707557532475; Sat, 10 Feb 2024 01:32:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707557532; cv=pass; d=google.com; s=arc-20160816; b=Dw5J8Wlnp5GvLBNstI75qW2FG0ZYpP4uGyk683TMdFiNuXOr5dF79fhAFB26dEnSFi dZ/10QCpZWXd3JR9MTZEwTTV1eUHxtbO1v/qMe/DpqZZnlt9Poe4+ucM72b/ei45IRBN kphmbuz/EfvQHWTgrJWgqEBDtm3WoFVaeo8dIocv86RAeUkrMy8ZewKbnWYmH/tCE3d+ XlQyl8QiQALOYsRsaHubO/EoKn2dH7Psqac/CPhS5OOKmuS1jkxe0yhwfydcr4Kex3ms PityRv4qCcDc+Q3G0nC6PEhsOvcqAabv3g8lsyiCCEon3jCTHXhdCGtHemPIKtsKNAKl qbzg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:in-reply-to:subject:cc:to:from:date :feedback-id:dkim-signature; bh=we3+CNIp/sCmExVts2CpdGbhGFMZZEqrf8Zzk61UqYw=; fh=e6vxEq0X5LOA3u/jHrQc9WoEE/nFKy3prZzu/po71AM=; b=OfPExLl58EHrv+jnS/Q7CL66upGDDFaw2pm9Ne0OEhBKr9xmtMa3ZYkU81iHXAnJZo YY8ZAEtpNAgoCPxe5Nu9H+V8FytbkGF41WDvzWY8xQyKXO7TCMooSKoGQE8XqMfhkY05 Ss54IZDzBQqq+5sm0iRec4ZXwlx0AETnx8I3DSvVg5p25gURnh4D8yrqYw3VRrayBVUa iWsMRfj2cGbtdpgRs91/wsr9gBE7AscFP35j4jOecVJZXzV8CCMKOuzAv8sUChoOkITN SPpuV1n0H1GC1MBc91cldTZOn6Vv8WigQvitkSuhbqjWOQFg1Q+pEuQW359frQNUsSEr a6vQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=k7mAoGW9; arc=pass (i=1 dkim=pass dkdomain=messagingengine.com); spf=pass (google.com: domain of linux-kernel+bounces-60356-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60356-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCVfQ9RtBYuPV5rjfmwpkD15zdxQHCgS477ORDVxchvCMheySxJwGrCeYgAWL2mNLZmsaiKcyTO+gz7YBSxEhz31lG2xfS/mlPBCj3DihQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id c3-20020a05622a024300b0042c509e60ddsi3740730qtx.248.2024.02.10.01.32.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Feb 2024 01:32:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-60356-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=k7mAoGW9; arc=pass (i=1 dkim=pass dkdomain=messagingengine.com); spf=pass (google.com: domain of linux-kernel+bounces-60356-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60356-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3A4EA1C21ADE for ; Sat, 10 Feb 2024 09:32:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BADB4364B4; Sat, 10 Feb 2024 09:32:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="k7mAoGW9" Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09DF6364B3; Sat, 10 Feb 2024 09:31:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.111.4.28 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707557522; cv=none; b=dnmmxnaDPSh6+mwajhb1sd1Ez55xoJNOuDnMAzXehPUCpXG6hc7uumeUmdnqJ9eT1K7Up/7brjVh5R8TCxCysyKaIpMlrL6elDUupS0cdYuY2n5dwcxrUq5XxzSDYVD53XdZnDkos0qb0mV9v5+6bNyBXs56Oas/RZBsiBoFNFk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707557522; c=relaxed/simple; bh=TP9W4qCq8hgSVWD+ohqGLyVeD4l5sBB7DBV8tYBFOBA=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=aKoQSpcyjdMwIZTu9JS4dnDDSG2zpgu19iB1YYNtj8mFgDBu1w/HrN1nNQ4jYM7VES7j+6F3dN2SqY81ohd803A5NOB6ftYOt7T5fTrnwKDaWri9gtpuZAJRCZoJsTC6NVThGCcUv0EOLcCHxKQo80nZqgWRHs3hGK9LtPZQmMQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=none smtp.mailfrom=linux-m68k.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=k7mAoGW9; arc=none smtp.client-ip=66.111.4.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux-m68k.org Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B1F445C0077; Sat, 10 Feb 2024 04:31:58 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 10 Feb 2024 04:31:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1707557518; x=1707643918; bh=we3+CNIp/sCmExVts2CpdGbhGFMZ ZEqrf8Zzk61UqYw=; b=k7mAoGW9Pzm6fLDCrX/8udswlMtlLI8f16Z0dsWLV1aw 6UEH6kq3mLRz/9T93kjud2ONbUAAQ6U1fsd0PM00d+YuVfF6IiN+RHi/yS7MfGnQ d1iT2kRdK7jnvjXNckVx4Wgs/c0VTo2pLRYnNlupWwtm1ZJaoPK3kqquTaqn88Di CcgdwidBw7lZ9uhAyRHlw5gvX2HtZcj0hGBTIoSew8zMEY7nD/3zJ6XJfROQ9Yiv 0tMEU3QRnqAf699kzuAZryF3fhBSafwrzqH9ifbjtPUr15zZiA1Jsg2xTv4soSoR IQ7w45GG9gkyY1q5PlhpQ+xj5ihstfFfmUGCi/7SSw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrtdekgddtgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefujgfkfhggtgesthdtredttddtvdenucfhrhhomhephfhinhhnucfv hhgrihhnuceofhhthhgrihhnsehlihhnuhigqdhmieekkhdrohhrgheqnecuggftrfgrth htvghrnhepleeuheelheekgfeuvedtveetjeekhfffkeeffffftdfgjeevkeegfedvueeh ueelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepfh hthhgrihhnsehlihhnuhigqdhmieekkhdrohhrgh X-ME-Proxy: Feedback-ID: i58a146ae:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 10 Feb 2024 04:31:55 -0500 (EST) Date: Sat, 10 Feb 2024 20:32:18 +1100 (AEDT) From: Finn Thain To: Lee Jones cc: Geert Uytterhoeven , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Michael Schmitz , "James E.J. Bottomley" , "Martin K. Petersen" , drew@colorado.edu, Thomas_Roesch@m2.maus.de, linux-scsi@vger.kernel.org Subject: Re: [PATCH 03/10] scsi: NCR5380: Replace snprintf() with the safer scnprintf() variant In-Reply-To: <20240208102939.GF689448@google.com> Message-ID: <0f9c95f9-2c14-eee6-7faf-635880edcea4@linux-m68k.org> References: <20240208084512.3803250-1-lee@kernel.org> <20240208084512.3803250-4-lee@kernel.org> <20240208102939.GF689448@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 8 Feb 2024, Lee Jones wrote: > On Thu, 08 Feb 2024, Geert Uytterhoeven wrote: > > > > > Confused... The return value is not used at all? > > Future proofing. > Surely a better way to prevent potential future API abuse is by adding checkpatch.pl rules. That way does not generate churn. James or Martin, if you can find some value in this patch, go ahead and apply it. I'm afraid I can't see it.