Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp1499218rdb; Sat, 10 Feb 2024 04:57:04 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU6c+wjWDbSWLHk/zkNYpkuRec8Sz3FOvXFBCrgnez8ZgxYvx4NNCAjtoUFI2Hcd9gcZH16issajcwekJRKS4BeKCHsKSrvxhNOOTWN+g== X-Google-Smtp-Source: AGHT+IEdhzh6HJOgCVo8Pvxs+Vnz8WG2OjE+Gxe6+hVR3WTbip7M8kI9Dhu1TeqmCFmPxm3WLc6C X-Received: by 2002:a05:6a00:4588:b0:6e0:3b48:572d with SMTP id it8-20020a056a00458800b006e03b48572dmr2084524pfb.31.1707569824098; Sat, 10 Feb 2024 04:57:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707569824; cv=pass; d=google.com; s=arc-20160816; b=gVtsuQnW66U/T/fOF1kvdOQ9kOaEpU/fH8c0E3164trhpH6SgYb3NnFYKRdNmBio9q i1w+wgwJp5cBZi68NhQOGUjr92GJGTAyGhTdUsevFfAGZI+bPM43lV6USwv7bgT1CE+y WqVZwB/h7JukGK11+fPKsVrqaHSeiUn1s7XgwSd5w0SFnLy5Kv/ro0xJoxWHuU8avJfJ fcWDKx07/hfro22K6FSH+YO4voBS4So8IDTNMQkZmf+nu43H5XoFD/2uict/b2/atVv9 Tr06l/K7EqHUHxOkLXTACx1Vt3SuUZG/7RC+kR6UF1001rUXIersGIusY3YTy88Ndvxr 5lZw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=TKP8jSYeInEcUcVuK6dJE4HvbY/2xSYzKDCvgSqNHf8=; fh=tWDppYDARhKAboxukVeD1oyJupscs5UlRxE9UZMNogY=; b=jiMWmXFECtKMV4JTGS72LBYZUDAHGb8QXzkQIjxUtOhv3BHQAGbPwtxhP/VyD4QJkU eCl54tq3np3BpP+/Mfvy5KBIJ15qmGMJKyq/NVZNp/Qb/EZbsQwPs+8KWmIbIMogE22W zfNZ8RBN1mN/P/gJbjhZPszn0aoIQAuOlu0XZmpjlQJL+0npwePv7Mnnqe0HZvMOzaNZ J1ifA4qotoD+W6qeLIdSM9r10z/AI5ZyUdp+j410AF0h59kHTsMGREg6Ph7T9Uf3Jvwd fyAa492cWWfOGU2xISX0lH52yVka8hAlsjCOErX11Abzt1c16RmxfIk/xa0ubSAyPC69 /A0w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=remlab.net); spf=pass (google.com: domain of linux-kernel+bounces-60405-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60405-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCXrXkaLxwLiVFlCuVhbja5W/QtG03kO2D21cV5YG3nQ0NSJIQq/nCgYb8RFEV0Zd7YY4/xwZVR+37OCz87xZH/OJssOu7t8qJzaCEEqHA== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id q1-20020a056a00084100b006e096a7e051si413428pfk.397.2024.02.10.04.57.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Feb 2024 04:57:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-60405-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=remlab.net); spf=pass (google.com: domain of linux-kernel+bounces-60405-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60405-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BDA63283842 for ; Sat, 10 Feb 2024 12:57:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C293D4C618; Sat, 10 Feb 2024 12:56:44 +0000 (UTC) Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [51.75.19.47]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 732F03D554; Sat, 10 Feb 2024 12:56:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=51.75.19.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707569804; cv=none; b=tnwcoi/fGiJ6+t5nI5qQ4UOzLoG/RCrflB+nWcwrI7ajVAd9S9e0lA1kXYkj5Uzsv6oiGEIycxCwkMtT+xhgrXM7RBUJf9Kzx21BQqtrO30Ohn2qSLFBkwycUA9T9A8Nekm0H4RSGggHeXjxxIpEBNPkEcs2rbNCkAZAW4Hodww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707569804; c=relaxed/simple; bh=tP5NgIL70LcknVWnXEpL1M5b/5gVZ6befjCl0rPG4bY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=uwo3zMMhRsRZrATpo+cXEIVU836CY2XDWtbA97pB8exmy0XRS2YSy5C1xYzU2b4JsiigL9C7C5uZXJ3LmWK35fRlbulyDPgKw/WsafLHI6zPiTMu1zSiEI7bLKQfHXNWQi7ZXQ5tshpm681tH86swORKirQEaHxVY6rxoeWholg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=remlab.net; spf=pass smtp.mailfrom=remlab.net; arc=none smtp.client-ip=51.75.19.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=remlab.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=remlab.net Received: from basile.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id 48C07C01A3; Sat, 10 Feb 2024 14:50:54 +0200 (EET) From: =?UTF-8?q?R=C3=A9mi=20Denis-Courmont?= To: courmisch@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] phonet: take correct lock to peek at the RX queue Date: Sat, 10 Feb 2024 14:50:53 +0200 Message-ID: <20240210125054.71391-1-remi@remlab.net> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Rémi Denis-Courmont Reported-by: Luosili Signed-off-by: Rémi Denis-Courmont --- net/phonet/datagram.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/phonet/datagram.c b/net/phonet/datagram.c index 3aa50dc7535b..976fe250b509 100644 --- a/net/phonet/datagram.c +++ b/net/phonet/datagram.c @@ -34,10 +34,10 @@ static int pn_ioctl(struct sock *sk, int cmd, int *karg) switch (cmd) { case SIOCINQ: - lock_sock(sk); + spin_lock_bh(&sk->sk_receive_queue.lock); skb = skb_peek(&sk->sk_receive_queue); *karg = skb ? skb->len : 0; - release_sock(sk); + spin_unlock_bh(&sk->sk_receive_queue.lock); return 0; case SIOCPNADDRESOURCE: -- 2.43.0