Received-SPF: pass (google.com: domain of linux-kernel+bounces-60412-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: David Laight <David.Laight@ACULAB.COM>
To: 'Pavel Machek' <pavel@ucw.cz>, Justin Stitt <justinstitt@google.com>
CC: Kees Cook <keescook@chromium.org>, Andy Shevchenko <andy@kernel.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	"linux-hardening@vger.kernel.org" <linux-hardening@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC] string: Allow 2-argument strscpy()
Thread-Topic: [RFC] string: Allow 2-argument strscpy()
Thread-Index: AQHaWe5TIJbv1x38yUWctvLGNyIGYrEDmx4Q
Date: Sat, 10 Feb 2024 13:51:18 +0000
Message-ID: <4b396628800149c69e157f0340778fbf@AcuMS.aculab.com>
References: <20240129202901.work.282-kees@kernel.org>
 <20240129215525.4uxchtrywzzsrauc@google.com> <ZcPDMZFPY08S4MGR@duo.ucw.cz>
In-Reply-To: <ZcPDMZFPY08S4MGR@duo.ucw.cz>
Accept-Language: en-GB, en-US
Precedence: bulk
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

From: Pavel Machek
> Sent: 07 February 2024 17:52
> > > Using sizeof(dst) is the overwhelmingly common case for strscpy().
> > > Instead of requiring this everywhere, allow a 2-argument version to b=
e
> > > used that will use the sizeof() internally.
> >
> > Yeah, this is definitely the case. I have a ton of patches replacing
> > strncpy with strscpy [1] and many of them match the pattern of:
> > | strscpy(dest, src, sizeof(dest))
> >
> > BTW, this hack for function overloading is insane. Never really looked =
into
> > it before.
>=20
> This hack is insane, but this is also highly confusing, please don't
> do this.

A much simpler 'hack' - here defaulting in 16.
Although you'd probably want a compile-time check on the
number of arguments.

And convert 'sizeof 'non-array' to (say) -1 and error
a length that is a constant -1.

=09David

extern int func_2(void *, const void *, int);

#define func_1(_p0, _p1, len, ...) func_2(_p0, _p1, len)
#define func(_p0, ...) func_1(_p0, __VA_ARGS__, 16)

int f1(void *p0, const void *p1)
{
    return func(p0, p1);
}

int f2(void *p0, const void *p1, int len)
{
    return func(p0, p1, len);
}

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1=
PT, UK
Registration No: 1397386 (Wales)