Received-SPF: pass (google.com: domain of linux-kernel+bounces-60432-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240127160405.19696-1-petre.rodan@subdimension.ro>
 <20240127160405.19696-5-petre.rodan@subdimension.ro> <Zb-1UGJt27OV-vjc@surfacebook.localdomain>
 <ZcEPJh1i7cc0xyBW@sunspire> <20240210150907.40e27f53@jic23-huawei>
In-Reply-To: <20240210150907.40e27f53@jic23-huawei>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Sat, 10 Feb 2024 17:12:15 +0200
Message-ID: <CAHp75VerichvwEOHvYYsHdYYAVJUajYk=LaO0VRpS51DgAr29A@mail.gmail.com>
Subject: Re: [PATCH v2 4/4] iio: pressure: hsc030pa add triggered buffer
To: Jonathan Cameron <jic23@kernel.org>
Cc: Petre Rodan <petre.rodan@subdimension.ro>, linux-iio@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Feb 10, 2024 at 5:09=E2=80=AFPM Jonathan Cameron <jic23@kernel.org>=
 wrote:
> On Mon, 5 Feb 2024 18:39:02 +0200
> Petre Rodan <petre.rodan@subdimension.ro> wrote:
> > On Sun, Feb 04, 2024 at 06:03:28PM +0200, andy.shevchenko@gmail.com wro=
te:

> > > > + memcpy(&data->scan.chan[1], &data->buffer[2], 2);
> > >
> > > Hmm... We don't have fixed-size memcpy() :-(
> >
> >       __be16 *ptr;
> >
> >       ptr =3D (__be16 *) data->buffer;
> >       data->scan.chan[0] =3D *ptr;
> >       data->scan.chan[1] =3D *++ptr;
> >
> > is this an acceptable replacement? I do not understand that your concer=
n was, my
> > intent was to copy exactly 2 bytes over.
>
> Andy?
>
> I'm not sure what you meant here either.

It was just a rhetorical remark, no AR implied. I.o.w. the current code is =
okay.

> There is an existing oddity that the read_raw deals with this as a be32 a=
nd
> masking out the right sections for each channel rather than perhaps more =
logical
> be16 pair here.


--=20
With Best Regards,
Andy Shevchenko