Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp1580201rdb; Sat, 10 Feb 2024 07:52:49 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU7k9GKlp/4G3Cf/x7uZQlhmRdHRyC1kkA7SidbEX3KqsYqy5pvv6NHZyh6EAFaUz3JTqV+UtH3A6aR1iQf5BrwrNEXfQtZo7Z+9H7wxg== X-Google-Smtp-Source: AGHT+IGYH2x/A/8KIWJxS4Zrw9p01/N4mU8fHTc6lbP+57MlycMxcf12mVx6yRdxfAwJTGCgUgXI X-Received: by 2002:a05:6808:1717:b0:3bf:e6c5:9b2b with SMTP id bc23-20020a056808171700b003bfe6c59b2bmr2917438oib.13.1707580368786; Sat, 10 Feb 2024 07:52:48 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707580368; cv=pass; d=google.com; s=arc-20160816; b=lpWeU8CTokAW0JeWempwQ5OWkfLVCmdT3kawbGKSgQfs/YbFnoTmOe775WZKtlC+K9 SiZU00W79T4yDEqQ2NKZnpTo9RR4Xc96lzcZrkKqdWb0fHifDRqOy2w8RO7VDWjl994X 7YXAEJjLE4WVW6D1M9S9+r8g2v7VL/9eRa881Cg7vIOECNB8RMUe+tv76o9npzXjZl9z QuHy2XYJH7ovxsI21oz7zwQgnKeAr2vQaOvS7C1evottxIpTdcNSjuXf0tvzNnm87u2g C16KZyYJmCb7I3Fagac5NBEc4yBt0MXKeyhCpx0NTXsg+SVB7XL7KWaPMd6hp7/ol0ny KiZw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=9pE7tNcVqf3ULEwZt3/+Ai13JeAYO5Kvy1Tmkfb4+Hg=; fh=8bdqKnH9c9OpNxYIsKyZm9YBx/KU3NTa0twRNCK0Fhc=; b=CgMqVU6BOZRGdz4H6tjpjeMvGuLEGT3s4+SQjXK5qWd+yevbDB8KogeSGceo4yDWn6 kN3ewWjdSjdOflemcHFrh47LvLbA5LIByK09qhQ0iIAt9dWwgGmPBmpCwHDHoMNFh0Md d7zot1dDbkQauVQavkm4n48rrohX/9ZZRV8SoR78wd9IW1iaBy+6U/k1YRIuq7Rw2yna iLQBL2LLbkPxb/ASQ/froyk6vlWyTdHwOc3vcPK8+x55pIyaWrnbNfLhc+fkrZztY45t YxwmJJAAPC9O/UPmPBZ/n+G2I9eRIKX7jekI7SiYw2P9jnwPh7LuKBuaQUPIn8uXByeY EitQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rwW9dlAL; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-60442-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60442-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCUR2VxYZQdcH0hyen+QBLcXYuSxQTfC9riHWVRGp14xZJFkbMWrYPxpotDalAbF2DbRvqQ14U/mlTtuMustk5VhwVGEA2xpJNsnOkp/Cg== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id s7-20020a05622a178700b0042c56f2bc74si4569008qtk.94.2024.02.10.07.52.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Feb 2024 07:52:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-60442-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rwW9dlAL; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-60442-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60442-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 80E771C21671 for ; Sat, 10 Feb 2024 15:52:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3AA435C022; Sat, 10 Feb 2024 15:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rwW9dlAL" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E4FA5BAC1; Sat, 10 Feb 2024 15:52:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707580360; cv=none; b=AvZHv0NCLV0A3JA01os15BrKVwLh6eRQpDsRdumxkGRPeFa1TyTrqv8oE/Ge4IJv4QZqGYJeFBoQRgzzsyUaBnU+28hvq3+/dEBncJLX4iwKum2sakBgWTusvkUW2qfZ0dd/ETyqVZNYbYFU4W7yB4Fw3fJKfsbccMU7OuAE8Zo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707580360; c=relaxed/simple; bh=KmRdhdIm1e1YU1Z6SApSOHV6og3dM5i8UxxHp/UIxk8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=D1OqDFRBZfx9IeG/KN9j0Aw3hQ7Dgs08Rjfhqmq+p0dLEnJRLCYTdVTFNVxVPdAMANML2QBOmdiLWV3QA80XcpJ2su7S2YB7NZFLA6vX5NG9e7aLiZxybdF+qK7W5vKtsnKuVu6YwZXq7PqH9KijBKpa60PqopyTaFullwyikaE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rwW9dlAL; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C405C433F1; Sat, 10 Feb 2024 15:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707580359; bh=KmRdhdIm1e1YU1Z6SApSOHV6og3dM5i8UxxHp/UIxk8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rwW9dlAL5q+YfP+CFq1zy21CHbAgsmxykad3Z/AfpPIYlpGU/jy4LJEXB7hMXySP7 q/WeSdF1IJ5H7kXv4Pp1VI2QcsKXAGG0skbk9y7YsEFgYtuCFB2wSzrtungydqpQLU zgdg2i64goXJFGyCR8DZxF3DxqYlLLD9x7LwaJQWoI4ZPDUByJRORw+h2OityoT/qI gP28VBMucnmfn2pVXcT0lmECdQ7sOVeHzRDcmszK3SYREmRmJ9unUdVtHsHza7DqsM YWJOLDHUAfSb40EEk5rmOYpi6xWyYgSmM8fRXG/57Ptf6Yr1upNzfSEqnLJj97NR0R dZwd9Mcb+StwQ== Date: Sat, 10 Feb 2024 15:52:26 +0000 From: Jonathan Cameron To: Alisa-Dariana Roman Cc: alexandru.tachici@analog.com, alisa.roman@analog.com, conor+dt@kernel.org, devicetree@vger.kernel.org, dlechner@baylibre.com, krzysztof.kozlowski+dt@linaro.org, krzysztof.kozlowski@linaro.org, lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, michael.hennerich@analog.com, robh+dt@kernel.org Subject: Re: [PATCH v3 3/5] iio: adc: ad7192: Use standard attribute Message-ID: <20240210155226.5e509845@jic23-huawei> In-Reply-To: <20240208172459.280189-4-alisa.roman@analog.com> References: <20240208172459.280189-1-alisa.roman@analog.com> <20240208172459.280189-4-alisa.roman@analog.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 8 Feb 2024 19:24:57 +0200 Alisa-Dariana Roman wrote: > Replace custom attribute filter_low_pass_3db_frequency_available with > standard attribute. > > Store the available values in ad7192_state struct. > > The function that used to compute those values replaced by > ad7192_update_filter_freq_avail(). > > Function ad7192_show_filter_avail() is no longer needed. > > Note that the initial available values are hardcoded. > > Signed-off-by: Alisa-Dariana Roman Looks good. Thanks for tidying this up. I've nothing to add to other reviews that have already come in for v3. Thanks, Jonathan