Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp1604565rdb; Sat, 10 Feb 2024 08:48:25 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXUs78Ex5vKq1v8MOxa2z2XeFKEql+BIW4jnVFbkZUreAgxMObNmdtGqFPIjYPmmPVUHkTXQ+wVEvNTfL79XLoIcVLA3IKhSZm+s417sQ== X-Google-Smtp-Source: AGHT+IGdKFny1w5wnmVahd8CkBnrolOhA97qR0hxO8edARczxKkbXM/FOAGo/CQi541zEKJDSw7m X-Received: by 2002:a17:906:8314:b0:a35:f2a6:3172 with SMTP id j20-20020a170906831400b00a35f2a63172mr1598607ejx.43.1707583705743; Sat, 10 Feb 2024 08:48:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707583705; cv=pass; d=google.com; s=arc-20160816; b=Y6FIZKxZs7fhk9DoST9oCjKIWMHLtquvhoiXQd01aXhIJH+g+fk1f9AGrs6sdg4wV8 VV9mLNK5CFsbNhXlAJbtB5SLpDtSPqMwyETU9Id4mIYQa/02o9sjs5bGkWPrtjDQO2SJ UIiIiC14+mC9WXBhDTq6tFtPeYApyTsuajrMvdISlwhNywtl1khcfjlbypgsX2A8mqmV qS9r6kn9vbusFBxnL1Dpg9h+fzxPu0uXD5+sLZfIJJ5Cmq84E6mwIvHcsRDtd9/uExCt bsjbbWFwEXozrvWifHI3fjncz3WOH3FkdbmLl1vPMJG7c4o9O06Ymzlu7Ud3i8HzYtV9 VthA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=RNOlq1DoB0NVWYtqXbTR9MbEAhhwgPqFXSplVvwt+8w=; fh=BjSVQOdL62RzuuPIBXUP9mi8DabHXN2EkuZZ0lSEk5U=; b=0Tdrq5YgME1eZjnG1C5svTwnIROI33pvsSHNMU2RNOrCRG7KEqT3OhDKWz9SQPIX8Q D+2HXK0SN1UItYutj72R+dt3we8gCTfySxv50moTlBpsk87IfzUCL+ZYhc4DXadqw1KG ospDyFIaRk3WGlxNI/SuAsp6t5QwoJgSL8wbw1c/airHuBOJIjxGe9hFqig7qZyWRM4Q yJ9I4MgDwywbt9v+0Rmju6rSja8H7s1gZQp0ijsN5E+Jvut5Hve6+wwaQnmszVOMO93u fWvc9aZTDjrtr0sZdTL2XF2UcJxHHU+2JpClg9gHIiBa1qqsZJO0R+mdSTTIn47sddUQ 2GtQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-60474-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60474-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCVn7rw5QLfNBSOziqhKIa16u7+Wmf62I1UFRol/Mdv6McqPlbhnQ5y/pvTZLlxHKYLSsWw+rcqE9MDn1H/i+QUBkUWbo1MrBAyuXOotVw== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id k16-20020a1709061c1000b00a3c1d467f48si981134ejg.842.2024.02.10.08.48.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Feb 2024 08:48:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-60474-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-60474-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60474-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CD22D1F25571 for ; Sat, 10 Feb 2024 16:47:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C1C5E5CDEA; Sat, 10 Feb 2024 16:46:57 +0000 (UTC) Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2C9A53815; Sat, 10 Feb 2024 16:46:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707583617; cv=none; b=l/WoGhSvajoaTPh1G/tg+ARMwI2x35Jf9T7+coTFq5OXTfEeSDKnIzqJRVOgox5k68flzRhSw3NuLNt+FXI+C1W/jPy6mMEaOkRSguxkdN2YkZ9zNN34hHpltGGC1WPXUHhaCFccHSFhAUPUB1HCJCu+3Dx3D/QGFNa5BHhlfYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707583617; c=relaxed/simple; bh=LAPzHF/wrID+WV98xjGsBm9F4FPvNWo66tnWoA0LJTk=; h=Subject:To:CC:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=OyH8YtZO9iAVQN8Fwgqo7fxn8NBB0YcAQbv1z0gUhTnwZzzso2HmTARI7MdluaC5ziPf3qiZ1X1VussvSYcgnXIhkXyyYqWtoSi57tAD0nJGKv8/wuOrr3cpaTh+73BEzFmoqBvrlFmpSuX8vidNKT0tPy02GWAmxYEJnzQvtw0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.1.105] (31.173.86.126) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Sat, 10 Feb 2024 19:46:45 +0300 Subject: Re: [RFC PATCH net-next v2 4/7] net: ravb: Always update error counters To: Paul Barker , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni CC: Yoshihiro Shimoda , Wolfram Sang , , , References: <20240206091909.3191-1-paul.barker.ct@bp.renesas.com> <20240206091909.3191-5-paul.barker.ct@bp.renesas.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Sat, 10 Feb 2024 19:46:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240206091909.3191-5-paul.barker.ct@bp.renesas.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch02.omp.ru (10.188.4.13) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 02/10/2024 16:34:25 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 183344 [Feb 10 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.3 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.86.126 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.86.126 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: omp.ru:7.1.1;127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.86.126 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 02/10/2024 16:39:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 2/10/2024 2:13:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 2/6/24 12:19 PM, Paul Barker wrote: > The error statistics should be updated each time the poll function is > called, even if the full RX work budget has been consumed. This prevents > the counts from becoming stuck when RX bandwidth usage is high. > > This also ensures that error counters are not updated after we've > re-enabled interrupts as that could result in a race condition. > > Also drop an unnecessary space. > > Signed-off-by: Paul Barker Definitely looks like a bug fix... [...] MBR, Sergey