Received-SPF: pass (google.com: domain of linux-kernel+bounces-60481-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Sat, 10 Feb 2024 16:53:25 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Nuno =?UTF-8?B?U8Oh?= <noname.nuno@gmail.com>
Cc: Cosmin Tanislav <demonsingur@gmail.com>, Cosmin Tanislav
 <cosmin.tanislav@analog.com>, Lars-Peter Clausen  <lars@metafoo.de>,
 Michael Hennerich <Michael.Hennerich@analog.com>, Andy Shevchenko
 <andy.shevchenko@gmail.com>, linux-iio@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: adc: ad4130: zero-initialize clock init data
Message-ID: <20240210165325.6aa34d06@jic23-huawei>
In-Reply-To: <fd81a6127a9b7abb6eae0785281836a238af8b57.camel@gmail.com>
References: <20240207132007.253768-1-demonsingur@gmail.com>
	<fd81a6127a9b7abb6eae0785281836a238af8b57.camel@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, 08 Feb 2024 09:15:08 +0100
Nuno S=C3=A1 <noname.nuno@gmail.com> wrote:

> On Wed, 2024-02-07 at 15:20 +0200, Cosmin Tanislav wrote:
> > The clk_init_data struct does not have all its members
> > initialized, causing issues when trying to expose the internal
> > clock on the CLK pin.
> >=20
> > Fix this by zero-initializing the clk_init_data struct.
> >=20
> > Fixes: 62094060cf3a ("iio: adc: ad4130: add AD4130 driver")
> > Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
> > --- =20
>=20
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Both applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

>=20
> > =C2=A0drivers/iio/adc/ad4130.c | 2 +-
> > =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/iio/adc/ad4130.c b/drivers/iio/adc/ad4130.c
> > index 53e19a863198..c7df499f9775 100644
> > --- a/drivers/iio/adc/ad4130.c
> > +++ b/drivers/iio/adc/ad4130.c
> > @@ -1794,7 +1794,7 @@ static int ad4130_setup_int_clk(struct ad4130_sta=
te *st)
> > =C2=A0{
> > =C2=A0	struct device *dev =3D &st->spi->dev;
> > =C2=A0	struct device_node *of_node =3D dev_of_node(dev);
> > -	struct clk_init_data init;
> > +	struct clk_init_data init =3D {};
> > =C2=A0	const char *clk_name;
> > =C2=A0	int ret;
> > =C2=A0 =20
>=20