Received-SPF: pass (google.com: domain of linux-kernel+bounces-60482-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sat, 10 Feb 2024 16:57:47 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Nuno =?UTF-8?B?U8Oh?= <noname.nuno@gmail.com>
Cc: Cosmin Tanislav <demonsingur@gmail.com>, Lars-Peter Clausen
 <lars@metafoo.de>, Michael Hennerich <Michael.Hennerich@analog.com>, Cosmin
 Tanislav <cosmin.tanislav@analog.com>, linux-iio@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: accel: adxl367: fix I2C FIFO data register
Message-ID: <20240210165747.1f93c795@jic23-huawei>
In-Reply-To: <70a4854e94cfd04b1a0ec9d3defe50ec56fc874f.camel@gmail.com>
References: <20240207033657.206171-1-demonsingur@gmail.com>
	<20240207033657.206171-2-demonsingur@gmail.com>
	<70a4854e94cfd04b1a0ec9d3defe50ec56fc874f.camel@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, 07 Feb 2024 10:08:38 +0100
Nuno S=C3=A1 <noname.nuno@gmail.com> wrote:

> On Wed, 2024-02-07 at 05:36 +0200, Cosmin Tanislav wrote:
> > As specified in the datasheet, the I2C FIFO data register is
> > 0x18, not 0x42. 0x42 was used by mistake when adapting the
> > ADXL372 driver.
For future reference (not worth a v2): You could wrap a little longer - 75
chars is fine normally for commit messages. =20
> >=20
> > Fix this mistake.
> >=20
> > Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
> > --- =20
>=20
> This needs a Fixes: tag. With that:
>=20
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Fine to just reply to each of these emails with an appropriate
fixes tag - no need for a v2.


>=20
> > =C2=A0drivers/iio/accel/adxl367_i2c.c | 2 +-
> > =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/iio/accel/adxl367_i2c.c b/drivers/iio/accel/adxl36=
7_i2c.c
> > index b595fe94f3a3..62c74bdc0d77 100644
> > --- a/drivers/iio/accel/adxl367_i2c.c
> > +++ b/drivers/iio/accel/adxl367_i2c.c
> > @@ -11,7 +11,7 @@
> > =C2=A0
> > =C2=A0#include "adxl367.h"
> > =C2=A0
> > -#define ADXL367_I2C_FIFO_DATA	0x42
> > +#define ADXL367_I2C_FIFO_DATA	0x18
> > =C2=A0
> > =C2=A0struct adxl367_i2c_state {
> > =C2=A0	struct regmap *regmap; =20
>=20