Received-SPF: pass (google.com: domain of linux-kernel+bounces-60483-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sat, 10 Feb 2024 17:01:12 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>, Lars-Peter Clausen
 <lars@metafoo.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 Matti Vaittinen <mazziesaccount@gmail.com>, Andy Shevchenko
 <andriy.shevchenko@linux.intel.com>, Marek Vasut <marex@denx.de>, Anshul
 Dalal <anshulusr@gmail.com>, Javier Carrasco
 <javier.carrasco.cruz@gmail.com>, Matt Ranostay <matt@ranostay.sg>, Stefan
 Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>,
 linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/5] dt-bindings: iio: light: adps9300: Add property
 vdd-supply
Message-ID: <20240210170112.6528a3d4@jic23-huawei>
In-Reply-To: <0a03e639-9998-40b2-95bd-15dc40139509@linaro.org>
References: <20240206130017.7839-1-subhajit.ghosh@tweaklogic.com>
	<20240206130017.7839-3-subhajit.ghosh@tweaklogic.com>
	<dbfde067-50b8-4f86-a098-0fc160114854@linaro.org>
	<84591019-6958-4685-8830-54260aadd26b@tweaklogic.com>
	<0a03e639-9998-40b2-95bd-15dc40139509@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 9 Feb 2024 08:33:11 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 08/02/2024 11:40, Subhajit Ghosh wrote:
> > Hi Krzysztof,
> > 
> > On 8/2/24 18:47, Krzysztof Kozlowski wrote:  
> >> On 06/02/2024 14:00, Subhajit Ghosh wrote:  
> >>> Add vdd-supply property which is valid and useful for all the
> >>> devices in this schema.  
> >>
> >> Why is it useful? How is it useful? DT describes the hardware, not
> >> because something is "useful".  
> > I am adding this property based on a previous review:
> > https://lore.kernel.org/all/20240121153655.5f734180@jic23-huawei/  
> 
> The property was there already.
> 
> > 
> > Does the below commit message in this context make sense to you?
> > "Add vdd-supply property for all the devices in this schema."  
> 
> It's still poor. You should say why, e.g. because devices have it.

I'd change the patch title to:

dt-bindings: iio: light: adps9300: Add missing vdd-supply

For description something simple like:

All devices covered by the binding have a vdd supply.


> 
> >>  
> >>>
> >>> this patch depends on patch:
> >>> "dt-bindings: iio: light: Merge APDS9300 and APDS9960 schemas"  
> >>
> >> This is unrelated and does not make any sense in commit msg. Drop.  
> > Apologies for the silly questions:
> > What does the "Drop" signify? Are you asking me to drop/delete the above
> > "...patch depends..." message or does it have any other meaning?  
> 
> Drop entire paragraph.
> 
> 
> Best regards,
> Krzysztof
>