Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp1630713rdb; Sat, 10 Feb 2024 09:55:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IExfMGUVdBRq96DR48TraFhztaeD78M7bYpdIvy2Tdf/SkgPeQAbY2lmtPWz7Kgb0rNTkHY X-Received: by 2002:aa7:d5c7:0:b0:560:cc04:a96c with SMTP id d7-20020aa7d5c7000000b00560cc04a96cmr1614644eds.24.1707587758600; Sat, 10 Feb 2024 09:55:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707587758; cv=pass; d=google.com; s=arc-20160816; b=U9WznIy3uuxXpWDuQeHG5F+p6erk/IkHOFHEwUTRO/VoZPcW+cEamxJBxXfdGB/iJR Fz1R8I60q3UJLD23xxgWNxgQPlbgoP+uFfcz2yQl55BUzuO8ChHy7WvoMo8/teUIQGN/ KDTqVaVIweDSAan2ktAuofo3qtrc0o7IjEn1BJIh4SKS8Ik3cCax/LeQ6EoSbdHINux+ 790RHYJt+ToJq9zL85sNFsYOkjg/Xwv7oTudyZMWBdTCQU4sUv8U2h7Wd29h5mbqMlWO 346E0Zjw8Epmy9Dkz78icR1HnXevl0FhdmegHNthRebGaLcQrHBCPNFa9mu/EvdlzWIk F6EA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=EWsJw+QPCaPl2JJ6q0a6cPvbsaNr0atx7CXk33I1BVY=; fh=9Wg/d5WmonHGkBvuujsxpxLNhw/jQwiVw6KHWVmfVf8=; b=WNVgaSQYuXROYjf/R22Qd608+usk9wZS622sc4RhUruyn315TyeAlz1c+FWHxTnB9+ 8MmvEg0bsXxhDXy5Ws6TMlwrLgj1Yp7q+mKW1b/th3Yz5U0Qw1nv86TUe4cS/kunAnw1 BZrmI07s6lPSuoyABPyC5pigZ4sA0ZyKQjt+OoFBZqD/HQqfvM0xn2cK9/NBa6325rg0 hLf+7Y9OLZY8enhCxLHOwJn/04Vo+B2gyu8xcmlhUqRcX5dD9ySvuXWKuEdP9+ZvCIcY JzHuY5gn89w7p3UYN20a/OGfQiAFRXPj0fkgyqy4XCnFFiaWURQgc2pbFZk9LxFlZ5H4 D7SQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="WH3CZQ/r"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-60504-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60504-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCX1ZAvhmmvGm9Jb1t2mHDDI2lv6AIXiYA8+8MZG3BoVa0EaUlm6y7538Znh8o4c0VmY10wBwbi0rIqwEUIWjjd/yHaZyws+vUSIfpiAkQ== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id t9-20020aa7d709000000b00561280da64esi989302edq.607.2024.02.10.09.55.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Feb 2024 09:55:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-60504-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="WH3CZQ/r"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-60504-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60504-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 577491F256BE for ; Sat, 10 Feb 2024 17:55:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2FB115D733; Sat, 10 Feb 2024 17:55:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WH3CZQ/r" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 528AA5D491; Sat, 10 Feb 2024 17:55:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707587734; cv=none; b=EytE+Ygswfmd023RyHXBHjAOPK8MD5MpJUzFArBr1vX1Z2PidB8m8w+LCm9CrF30PmYMesb/UNiaUU3WEK/5RsuPGUkKzgVwRnamdS+hHPJiZbg7d4XPf4Une3/mg3XeqZTv8Gk7IDR5kHNB3xXejJ6Jtpjnvb8Rqpk2gx3NgOg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707587734; c=relaxed/simple; bh=ap3JjIjFbc61TT1tG3+muHIUhO4Rb8ru71qzcOe2sUs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lhvfwNYpgO8D6tc5GgBq8tHKTm/8XvPnq5rKRMcTDltaVjWwGtAcaTw2qfT8P/WMJOdruOOhy8vo/WzzIXV7AvzKcr2CYqmHRU6UQ5kcVQsVPBwzRruMgXJQEi/gKCZ0NIOxa/ocL/Li+2IbfQqP1AbTjqGrMkOfbOUYfBZ67Y0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WH3CZQ/r; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5FD9C433C7; Sat, 10 Feb 2024 17:55:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707587733; bh=ap3JjIjFbc61TT1tG3+muHIUhO4Rb8ru71qzcOe2sUs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WH3CZQ/rC5aqGe3w5A3t4lwJXSR0BY2C3oE7PzQlrcQqCBGMklvzatKYf3QS6ebxa HpzyXgCCUBLPsP9lA92acqB3O4VHNMek8jbItLX+km4TDUTPBXgIosDxoEH1QHJKLR V0DZEn2hjLeyxma5llNWnvurVtZukJYJCt6CJOuyY3hyhFoa4JmT3CxZcxArtvvfVJ 4a3DTdlIgb74YLnpGUxtaE+2wmJM0PzR0M2lP4zTM+J8EP/uzfg+KpwvRaJmowCnBM fJLxrtGBEJSEOInF/xnsHK/A4iebE04NosajUR4ZtdCVu9H4NfdPSyUZ8dbGmElisK uZu3dydsybGOQ== Date: Sat, 10 Feb 2024 17:55:21 +0000 From: Jonathan Cameron To: Dimitri Fedrau Cc: Lars-Peter Clausen , Javier Carrasco , Li peiyu <579lpy@gmail.com>, Nuno Sa , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] iio: humidity: hdc3020: drop u8 register pairs Message-ID: <20240210175521.6984cee6@jic23-huawei> In-Reply-To: <20240207074758.4138724-2-dima.fedrau@gmail.com> References: <20240207074758.4138724-1-dima.fedrau@gmail.com> <20240207074758.4138724-2-dima.fedrau@gmail.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 7 Feb 2024 08:47:51 +0100 Dimitri Fedrau wrote: > Switch to 16bit defines. Create helper functions that are aware of the > new register format and apply them wherever possible. The dropping of const is an unrelated (though sensible) change. Given it's really minor, just calling it out with a comment here would be fine (rather than a separate patch). Otherwise looks good to me. Thanks for cleaning this up. Jonathan > > Signed-off-by: Dimitri Fedrau