Received-SPF: pass (google.com: domain of linux-kernel+bounces-60855-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240210222226.890031-1-vibhavp@gmail.com>
In-Reply-To: <20240210222226.890031-1-vibhavp@gmail.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Sun, 11 Feb 2024 10:57:34 -0500
Message-ID: <CABBYNZJx68KUkiHXeZmSnzwpkK2CAB_ASrD5dK+WMocDuwuomQ@mail.gmail.com>
Subject: Re: [PATCH 0/1] Bluetooth: mgmt: Add command for getting device IO capabilities.
To: Vibhav Pant <vibhavp@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org, 
	johan.hedberg@gmail.com, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Vibhav,

On Sat, Feb 10, 2024 at 5:22=E2=80=AFPM Vibhav Pant <vibhavp@gmail.com> wro=
te:
>
> The following patch adds a new command to the bluetooth management interf=
ace,
> GET_DEVICE_IO_CAPABILITY. The command allows userspace to get the IO capa=
bility,
> and the authentication methods supported by a connected device. The comma=
nd is
> necessary in order to implement parts of the Win32 Bluetooth API in the W=
ine,
> specifically the following two structs:
>
> * BLUETOOTH_AUTHENTICATION_CALLBACK_PARAMS, which provides IO and auth ca=
pabilities
> info for an incoming authentication request from a device.
>
> * BTH_DEVICE_INFO, which contains flags indicating whether the device sup=
ports
> Simple Secure Pairing and MITM protection. The former is supported throug=
h BlueZ's
> "LegacyPairing" property.
>
> Because the Wine API are implemented on top of BlueZ, I'll also be provid=
ing a
> corresponding patch that uses the newly added management command to expos=
e the
> capabilities through new properties in the org.bluez.Device1 interface.

Interesting, but the IO capability matching logic lives under the
kernel so I wonder how useful this information is if you can't really
do much about the authentication method used? And in case you are
thinking of changing the pairing procedure to just leave it up to the
upper layer to figure it out, I don't think that is a good idea
because that is subject to qualification that would effectively be a
new implementation.

> Thanks,
> Vibhav
>
> Vibhav Pant (1):
>   Bluetooth: mgmt: Add command for getting device IO capabilities.
>
>  include/net/bluetooth/mgmt.h | 19 ++++++++
>  net/bluetooth/mgmt.c         | 89 ++++++++++++++++++++++++++++++++++++
>  2 files changed, 108 insertions(+)
>
> --
> 2.43.0
>
>


--=20
Luiz Augusto von Dentz