Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2041433rdb; Sun, 11 Feb 2024 08:36:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IEPqxorzhqLpFrzssm+nJcYBfCIUYvFMlt6wUvBiunQUbJjfq1jDz5h11jRjMnxNE3qZ6Ww X-Received: by 2002:a05:6214:509d:b0:68c:b9c9:5adb with SMTP id kk29-20020a056214509d00b0068cb9c95adbmr6782484qvb.41.1707669395883; Sun, 11 Feb 2024 08:36:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707669395; cv=pass; d=google.com; s=arc-20160816; b=BGSHgvi6uSPNvamb5qsr0itb2FRwskhsaxKc2Kmo08CJVuUvrBkKlhtIrTwVgOdpCP qVob9G42Kkg9kJwuU+gpqRet9Qf7y29GWee/GD3Y+aJ6GcIIJe0BjmI9j67nS2sE3Ij6 S1MA1ODQorwA1vcKyp+G9WyTXStaCJ/l2qZznMYqpFpiq8rEZTmAh9fiGfJJ2+z6b7mo Ru5h/fLxjpl5tyE1Pvid9ROYnglVzWNMRgY3ARH4IKo0yO/R2h7SYFNZXXo5NC+E4Bm4 mQLTaSh9nMOguhDAUJi7LFUjs0iSw11e9krAx6PedqPpGt5uTJ+iLaip/RKDyb+yRaBS JZpA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=MOR4SQTKi2ZuVZyEtD9XAGZ3ejYq8ORlTE2y7GUdKoE=; fh=SdMMv9lb3BZawJxSA3DRllF485e4XLTD+n4LZB96zhk=; b=Er/ZG10OrXNkdzXcbGGHlBNrG+CGKv3rdvTSCRyvxxMrVps9/R+DlN7cpkXNFWps9r aIfdREdDugTx7HW8YCvc2kYMUT5zc/THgVo+CogfW5xtrIsquFU5izKHtw9yyFiT1ULh Df0xw+ONuKo64E0D4jpZWnyBhSgte4pnUg9HfFXeohVY6ULrNEzLX8c4d+MvYJXYwAfn OxPIgQBL80mD8CGZHGk6BjUE5Fa7c6SY7K5BUrHbNNoOY/d2iRzOGE+p1QdRykUWcwD8 Wv2DUK6WdzrRue5Ra+N9Uc4Pozpnvq6jl6kW//YqRGbemmo/T7Zbsv38L40Cb4Ymu650 QRmA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="GXE/ixzo"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-60866-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60866-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCV2CgjAkt/RL8M3gflYJ4hp0SmbQ9Ods4PPipt4Nnwm/3pRXfZmQGxTEeIyXwLTDEz2bAJlTPBmB7AdRwv95JHEi0CrIzcPHJQ26FXZjw== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id f2-20020a056214076200b0068c8ab72bc7si6558493qvz.112.2024.02.11.08.36.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Feb 2024 08:36:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-60866-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="GXE/ixzo"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-60866-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60866-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9B8081C21E26 for ; Sun, 11 Feb 2024 16:36:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E0E7B5C600; Sun, 11 Feb 2024 16:36:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GXE/ixzo" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 090F11DFEF; Sun, 11 Feb 2024 16:36:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707669383; cv=none; b=ZGYbhZgOm85jHg6ndafWWKu3NHzk1ye1bFuYW+MYxbOwJCmuszXuMgaqycaymIgmv5kFsamDKp+jZSRasHV+aXTAEQkyH6VxFf5IDPHcrt7w7URIZqBv0kStfu2EYto/O5gnlqaQAvLo7DLbk3g1LLt/3LCYhkj/2JVm7bluC08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707669383; c=relaxed/simple; bh=BVT7c5MMwoanGGQVtjw+M5JfeoluaC7HDWDxAzZAEyg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LgpNv2R3YOhfp6lZbdXYwNr8CssqAMj2g0SNjzfGF6nQA3qTF5kgc67FQ1wO3kkFWaFGBax2vDHVrGEzZKHGTY1WJkY/MU++HAZMA9E3J6o+D0XxGcmmP0AjoW6MocfGMBHgHU1/Ze0KLA9lkBBuamiVaBr+oXhnGKlSfVQ7uGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GXE/ixzo; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E63DC433C7; Sun, 11 Feb 2024 16:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707669382; bh=BVT7c5MMwoanGGQVtjw+M5JfeoluaC7HDWDxAzZAEyg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GXE/ixzolu0k8wKk/Vk6a7Fel7WWw+xxHDcbCPywbSyyo83tTRz477KXJUWMxpXvf Tr1MXoK+sD403mAy4u2WLgduc5yUbSq8mXGAZ41zGRqxZlklydfPn2uirTjb+A38cv 4kxcPMlLJ1dGLJxIa2DAPO3EmgFPIH4m9QZ4ZV/JqOGEc8MY4SMxuwl66j6r7DLiE4 PODM2fF5Rfh2eDLFzzxVxsV6EwDQslfZxBRq3+kY+e8GuWHKr4qd3ccjm2g+mjIALS pMFPyjIkh/eo+Ylq6zScv089vlj50F4L/BZg2Nh6IIqO46IqsbixZ0qFymqZSmNbrG AZwBVKL2aUKEw== Date: Sun, 11 Feb 2024 11:36:20 -0500 From: Sasha Levin To: Florian Fainelli Cc: stable@vger.kernel.org, Russell King , Jakub Kicinski , Doug Berger , Florian Fainelli , "David S. Miller" , "open list:BROADCOM GENET ETHERNET DRIVER" , "open list:BROADCOM GENET ETHERNET DRIVER" , open list Subject: Re: [PATCH stable 5.15 v2] net: bcmgenet: Fix EEE implementation Message-ID: References: <20240208190605.3341379-1-florian.fainelli@broadcom.com> <20240208190605.3341379-2-florian.fainelli@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20240208190605.3341379-2-florian.fainelli@broadcom.com> On Thu, Feb 08, 2024 at 11:06:05AM -0800, Florian Fainelli wrote: >[ Upstream commit a9f31047baca57d47440c879cf259b86f900260c ] > >We had a number of short comings: > >- EEE must be re-evaluated whenever the state machine detects a link > change as wight be switching from a link partner with EEE > enabled/disabled > >- tx_lpi_enabled controls whether EEE should be enabled/disabled for the > transmit path, which applies to the TBUF block > >- We do not need to forcibly enable EEE upon system resume, as the PHY > state machine will trigger a link event that will do that, too > >Fixes: 6ef398ea60d9 ("net: bcmgenet: add EEE support") >Signed-off-by: Florian Fainelli >Reviewed-by: Russell King (Oracle) >Link: https://lore.kernel.org/r/20230606214348.2408018-1-florian.fainelli@broadcom.com >Signed-off-by: Jakub Kicinski >Signed-off-by: Sasha Levin >Signed-off-by: Florian Fainelli It doesn't look like this one applies to 5.15... -- Thanks, Sasha