Received-SPF: pass (google.com: domain of linux-kernel+bounces-60875-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Petlozu Pravareshwar <petlozup@nvidia.com>
To: Rob Herring <robh@kernel.org>
CC: "thierry.reding@gmail.com" <thierry.reding@gmail.com>, Jonathan Hunter
	<jonathanh@nvidia.com>, "krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>, "conor+dt@kernel.org"
	<conor+dt@kernel.org>, "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"dmitry.osipenko@collabora.com" <dmitry.osipenko@collabora.com>,
	"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>, Kartik Rajput
	<kkartik@nvidia.com>, "cai.huoqing@linux.dev" <cai.huoqing@linux.dev>,
	Sandipan Patra <spatra@nvidia.com>, "linux-tegra@vger.kernel.org"
	<linux-tegra@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>
Subject: RE: [PATCH V2 2/3] dt-bindings: tegra: pmc: Update scratch as an
 optional aperture
Thread-Topic: [PATCH V2 2/3] dt-bindings: tegra: pmc: Update scratch as an
 optional aperture
Thread-Index: AQHaSYNiQc3Ffh8ZXUOeuNNLMtgYTrDyrdYAgBLXPvA=
Date: Sun, 11 Feb 2024 17:07:44 +0000
Message-ID:
 <IA0PR12MB8906A78CE7A5652181720561B5492@IA0PR12MB8906.namprd12.prod.outlook.com>
References: <20240117202504.943476-1-petlozup@nvidia.com>
 <20240117202504.943476-2-petlozup@nvidia.com>
 <20240130171908.GA1964535-robh@kernel.org>
In-Reply-To: <20240130171908.GA1964535-robh@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?iITa0vXEwKuB8gRM64LY06deP1KRWD7qosL1kNZx3jeVI4CWq9rOCMosyER8?=
 =?us-ascii?Q?BFfdw9gCOIkpg7Fi9ynjbU3Qa0A8I+FRrQpCvPaT8LJRtB3T4pBcR0BTSCcz?=
 =?us-ascii?Q?MrcqSPOv4mTk63jSRmfoj6sJILIvAoBoummbFRxs+gLAHtxbWEpEECgnnH3t?=
 =?us-ascii?Q?+IwhC43Na4wm/CrRtY0ytZDHTLhwjgnGMsaUsYGMstAZ8qwq2ec9hoRzKBLz?=
 =?us-ascii?Q?4c2YKVKsHe8cNvopOGnFJo3Q2LeVe5D2+54zEnXFFZ+dQhQJh5lkzdFA/PZB?=
 =?us-ascii?Q?pvS0R1VNryPl0Be1KEx1r1LhKIBb4fg7KqBkSS7UyjE/57/dp6OHuaGdWt91?=
 =?us-ascii?Q?nx6tAWhpC7YGoZFKFXissnyc4PBasTMeZEkwHG7oaqIaNL/xZsHreiydP5Fs?=
 =?us-ascii?Q?FbJaglMWggNfzZuNh7cnpap0XQbjfZ+nvBSL+iCfsrBBDpogU5FRAFmyJ/Yf?=
 =?us-ascii?Q?+Crf7zlNs9RICL4ghg3JCrOriW6B0E17wti35HNhWuVs+VGmJZvtPMMK/Oni?=
 =?us-ascii?Q?1kfdCZGEX8i3fG0xWtQuK168HZ6FvW/bBSr3ke5W2H0b4O0PYyFwhkR8PAOH?=
 =?us-ascii?Q?jn8nXAg4HXkCfWRp8S7yiFijzxwJadwiw7GGEVWvQ5ccl1FS5oe90i1TjTgQ?=
 =?us-ascii?Q?vdCj6U0g6GSwXecjAss/lcEM1+NDAFsgDgkItLt6USx+UIys2w/NASeVlvai?=
 =?us-ascii?Q?VUKM+sAwk6Jwws+kSYodlNT7qLclOhu0W06rTT8pF6w4epyST5iy78eZpZN/?=
 =?us-ascii?Q?tLXNJYhruT1X2nRVpZdzqPu9SLbNRN95yEsIViY0CemRVFtAFMt8y3mIelUb?=
 =?us-ascii?Q?gpu22nxIxQeXTIZuYl1aAzUSQjp6lShmt/xzAc6CChsrilOWYzS5WGkx8/Dt?=
 =?us-ascii?Q?lDEZ05DMib9tcp2pCrT2T57IaiKjqf2KXmy5KPYR3rfrjA9mwHZA1D2K59D6?=
 =?us-ascii?Q?gY9RdMeOp97HrVo5Bf0g4VukXnjczDQq3sEKtyefqhdQLRbeGxuTcQ+W8M3D?=
 =?us-ascii?Q?0bSFrUe0DRkAGE4224Iticmm5wlU0RJ6PaTbYkeV5yLP5ISqD1nENMS5Kuqv?=
 =?us-ascii?Q?gTLdn+95zD02llkidy6qaJPmHNL4Wj0DVhMl+NGOfewHRe1hKqoBEpZeQrB/?=
 =?us-ascii?Q?z/ftPEfya+I86n2p3hHF/I/lD9QnBbjzUnD9/DUmexqK1F1AVr81eoFGgE4s?=
 =?us-ascii?Q?syZLL4wjf9qbMcE6+kej6rCylg66mfkJY0WYfcXpIGavkW1sSM3vS443cRrI?=
 =?us-ascii?Q?P3bC9htnhPbn66En13kI6BOLLRpOIWv70OHF0VXBdppqPrlI9NfaFs343X8a?=
 =?us-ascii?Q?yUF17+I3xzteTIH3o5Qhm2pgv94/p05CeJfAAHT3z0qaHBP1Dft+1w+nLx/2?=
 =?us-ascii?Q?9jwfsD622ZuY7FyutoZm3HZOi8K4cliMNU9odyWlHLNOmaiYvgRfyi+BouDK?=
 =?us-ascii?Q?GF0s5s3jcy9v33HpNOpPtWpOVkvKLUsPJSOYN02EtiP5d6qvHnvjo5cUybQa?=
 =?us-ascii?Q?JHp4bEoBMWqkmkHaU7z9EBw6GbcFPHK4KmMzhyAg1WKTqKBoMzrkGfaRx49i?=
 =?us-ascii?Q?NfsPLiEorn/M+McqK8ZT8sYVYt2HA+ZDvl06s90V?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8906.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 02d204f5-d89f-4411-656e-08dc2b23f6a4
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2024 17:07:44.1061
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VuMZj8O4aXh87DQ+J/zVWs02V2O4KYYdNi+16gc2O1aM5bYwXGTeHn+sfS2FEttzNEm7roeNQLUu7Rjzorm10A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4512

> On Wed, Jan 17, 2024 at 08:25:03PM +0000, Petlozu Pravareshwar wrote:
> > Scratch address space register is used to store reboot reason. For
> > some Tegra234 systems, the scratch space is not available to store the
> > reboot reason. This is because scratch region on these systems is not
> > accessible by the kernel as restricted by the Hypervisor.
> > Such systems would delist scratch aperture from PMC DT node.
> >
> > Accordingly, this change makes "scratch" as an optional aperture for
> > Tegra234 in PMC dt-binding document.
> >
> > Signed-off-by: Petlozu Pravareshwar <petlozup@nvidia.com>
> > ---
> > Changes in v2:
> > - Fix dt_binding_check indentation warning.
> > - Update 'reg-names' property items list.
> >
> >  .../arm/tegra/nvidia,tegra186-pmc.yaml        | 78 ++++++++++++++-----
> >  1 file changed, 58 insertions(+), 20 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-
> pmc.yaml
> > b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-
> pmc.yaml
> > index 0faa403f68c8..79928824005d 100644
> > ---
> > a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-
> pmc.yaml
> > +++ b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-
> pmc.
> > +++ yaml
> > @@ -27,7 +27,7 @@ properties:
> >        - const: pmc
> >        - const: wake
> >        - const: aotag
> > -      - const: scratch
> > +      - enum: [ scratch, misc ]
> >        - const: misc
> >
> >    interrupt-controller: true
> > @@ -41,25 +41,63 @@ properties:
> >      description: If present, inverts the PMU interrupt signal.
> >      $ref: /schemas/types.yaml#/definitions/flag
> >
> > -if:
> > -  properties:
> > -    compatible:
> > -      contains:
> > -        const: nvidia,tegra186-pmc
> > -then:
> > -  properties:
> > -    reg:
> > -      maxItems: 4
> > -
> > -    reg-names:
> > -      maxItems: 4
> > -else:
> > -  properties:
> > -    reg:
> > -      minItems: 5
> > -
> > -    reg-names:
> > -      minItems: 5
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: nvidia,tegra186-pmc
> > +    then:
> > +      properties:
> > +        reg:
> > +          maxItems: 4
> > +        reg-names:
> > +          items:
> > +            - const: pmc
> > +            - const: wake
> > +            - const: aotag
> > +            - const: scratch
>=20
> There is no need to define the names and order again. Just this is
> sufficient:
>=20
> maxItems: 4
> contains:
>   const: scratch
>=20
Agree. Will address this in the next patch.

> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: nvidia,tegra194-pmc
> > +    then:
> > +      properties:
> > +        reg:
> > +          minItems: 5
> > +        reg-names:
> > +          items:
> > +            - const: pmc
> > +            - const: wake
> > +            - const: aotag
> > +            - const: scratch
> > +            - const: misc
>=20
> Just 'minItems: 5' is sufficient here.
>=20
Will address this in the next patch.

> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: nvidia,tegra234-pmc
> > +    then:
> > +      properties:
> > +        reg:
> > +          minItems: 4
> > +          maxItems: 5
>=20
> That should already be the top-level constraint.
>
Will address this in the next patch.
=20
> > +        reg-names:
> > +          anyOf:
> > +            - items:
> > +                - const: pmc
> > +                - const: wake
> > +                - const: aotag
> > +                - const: misc
> > +            - items:
> > +                - const: pmc
> > +                - const: wake
> > +                - const: aotag
> > +                - const: scratch
> > +                - const: misc
>=20
> Only need:
>=20
> contains:
>   const: misc
Will address this in the next patch.

Thanks.