Received-SPF: pass (google.com: domain of linux-kernel+bounces-60882-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <735172b1-1267-43e7-a2af-8596d849760a@auristor.com>
Date: Sun, 11 Feb 2024 12:24:09 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] afs: Increase buffer size in afs_update_volume_status()
To: Daniil Dulov <d.dulov@aladdin.ru>, linux-afs@lists.infradead.org
Cc: Marc Dionne <marc.dionne@auristor.com>,
 David Howells <dhowells@redhat.com>, linux-kernel@vger.kernel.org,
 lvc-project@linuxtesting.org
References: <20240211150442.3416-1-d.dulov@aladdin.ru>
Content-Language: en-US
From: Jeffrey E Altman <jaltman@auristor.com>
Organization: AuriStor, Inc.
In-Reply-To: <20240211150442.3416-1-d.dulov@aladdin.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2/11/2024 10:04 AM, Daniil Dulov wrote:
> The max length of volume->vid value is 20 characters.
> So increase idbuf[] size up to 20 to avoid overflow.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: d2ddc776a458 ("afs: Overhaul volume and server record caching and fileserver rotation")
> Signed-off-by: Daniil Dulov <d.dulov@aladdin.ru>
> ---
>   fs/afs/volume.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/afs/volume.c b/fs/afs/volume.c
> index f84194b791d3..9d0da38bbcf6 100644
> --- a/fs/afs/volume.c
> +++ b/fs/afs/volume.c
> @@ -302,7 +302,7 @@ static int afs_update_volume_status(struct afs_volume *volume, struct key *key)
>   {
>   	struct afs_server_list *new, *old, *discard;
>   	struct afs_vldb_entry *vldb;
> -	char idbuf[16];
> +	char idbuf[19];
>   	int ret, idsz;
>   
>   	_enter("");

Thanks for the patch.

The commit message says idbuf[] is being increased to 20 chars but the 
patch only increases it to 19.

Should idbuf[] be 20 or should the commit message be altered?

Jeffrey Altman