Received-SPF: pass (google.com: domain of linux-kernel+bounces-60883-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sun, 11 Feb 2024 17:36:40 +0000
From: Conor Dooley <conor@kernel.org>
To: Heiko =?iso-8859-1?Q?St=FCbner?= <heiko@sntech.de>
Cc: Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	linux-rockchip@lists.infradead.org, linux-phy@lists.infradead.org,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Frank Wang <frank.wang@rock-chips.com>,
	Kever Yang <kever.yang@rock-chips.com>, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v1 03/10] dt-bindings: phy: add rockchip usbdp combo phy
 document
Message-ID: <20240211-uproot-awoke-b3c70f168e17@spud>
References: <20240209181831.104687-1-sebastian.reichel@collabora.com>
 <20240209181831.104687-4-sebastian.reichel@collabora.com>
 <3267388.oiGErgHkdL@diego>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Y3S4+lww4bcgDsY0"
Content-Disposition: inline
In-Reply-To: <3267388.oiGErgHkdL@diego>


--Y3S4+lww4bcgDsY0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 09, 2024 at 11:17:40PM +0100, Heiko St=FCbner wrote:
> Am Freitag, 9. Februar 2024, 19:17:19 CET schrieb Sebastian Reichel:

> > +  rockchip,dp-lane-mux:

Why "mux" and not "map"?

> > +    $ref: /schemas/types.yaml#/definitions/uint32-array
> > +    minItems: 2
> > +    maxItems: 4
> > +    description:
> > +      An array of physical Tyep-C lanes indexes. Position of an entry =
determines
>=20
> nit: Type-C lane indexes
>=20
> > +      the dp lane index, while the value of an entry indicater physica=
l Type-C lane.
>=20
> nit: indicates instead of indicater?

If we are talking nits, the first use of "dp" should be "DisplayPort (DP)"
and s/dp/DP/ elsewhere.

>=20
> > +      The support dp lanes number are 2 or 4. e.g. for 2 lanes dp lane=
s map, we could
>=20
> nit: The supported dp lane numbers ... ?
>=20
>=20
> > +      have "rockchip,dp-lane-mux =3D <2, 3>;", assuming dp lane0 on Ty=
pe-C phy lane2,
> > +      dp lane1 on Type-C phy lane3. For 4 lanes dp lanes map, we could=
 have
> > +      "rockchip,dp-lane-mux =3D <0, 1, 2, 3>;", assuming dp lane0 on T=
ype-C phy lane0,
> > +      dp lane1 on Type-C phy lane1, dp lane2 on Type-C phy lane2, dp l=
ane3 on Type-C
> > +      phy lane3.

And

> If dp lane map by DisplayPort Alt mode, this property is not need.

"If DP lanes are mapped by" "not needed."

Cheers,
Conor.

--Y3S4+lww4bcgDsY0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZckFqAAKCRB4tDGHoIJi
0mdTAQDyQTT+aO5vXfGBJ344i7lWsxRedOFHbKlJ1OGgglszlwEA4pLizuhJUa9l
cE8jarPeJgs3wrqeqmKQwRLTt0f+BgI=
=Fvfu
-----END PGP SIGNATURE-----

--Y3S4+lww4bcgDsY0--