Received-SPF: pass (google.com: domain of linux-kernel+bounces-60900-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Erick Archer <erick.archer@gmx.com>
To: David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Joerg Roedel <joro@8bytes.org>,
	Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Kees Cook <keescook@chromium.org>
Cc: Erick Archer <erick.archer@gmx.com>,
	iommu@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: [PATCH] iommu/vt-d: Use kcalloc() instead of kzalloc()
Date: Sun, 11 Feb 2024 18:51:43 +0100
Message-Id: <20240211175143.9229-1-erick.archer@gmx.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:wI4IgzOPPy0=;TDkhQ6yQenORkRkTgJLiNmfm6Gi
 5iW80IJ/ey3QnC1veoGSCMBdQbMHXSGaWqyEyg0wEIeiJke8XUPZGcuoFemWgbf8YOwJSmWOY
 F5WLHfRBGpROAxcxX7i5AK3bb/oDGrZFl6tQP7K1ZciNJk9Deom6B4U9Y7QDNOpH74JRJZ/0Q
 g1aaV2LnMscM8uHovQ6YF443hcmzZsAwIGe0wtMB1a4ECoX8h5gVszW+8SwZkajYnZow8TJkQ
 lMqf5ytzcbUN7IDBck3E+A1QubFlpYNYfQiilPG+NDJtYJhoY53u/fvUGOEeSJI5AIOJ57Sfu
 MuwG8zh+zOkBWv0p+rmGsmnW1vc7AiGBhByxJmNTr3ZgbnEuBja1u0kKgItQMecs1knwBJxDb
 32i7iM8Ra91F1N5UW8gHRL3cAy9y3LbDksnP5J3bPqcL7SnvPuwFB/kyzjAfEyZCpBe4okbdM
 r/yMFgBWhQucTTmivdwGWnP3zx+jSve0ndgQWZ/wvAs4Nb4giAd8ZVYcecd+GxlY6NGELRQPt
 uhV0KoiSV5FlPphrNUhAOAPEWyuvRT8hsnIQzJnD0RfWBeGwEQvoUQnHS226QxXREyu9Tc7Nf
 qytb8yVAA42UVzM133l+eX0uvQJUxaTJ1lA8CC/6+h59q5zV64+zM3G9/UezNwW3t5i74Jrb6
 FXxCgm8ZpOSohQJ9tpb7qjwukxVX8eGexTsYA2qAFg0knoqgktimtMLdFF9KLO3vpFUZlVL5J
 0xbiUEQdQzPX5h9BZBL4J575YFZJWOrC0g5OG0lDd/61KYkpzo0aG5/MsKeilGuPMR567zEeH
 ztmsDBEbq8AU0Z7RHD18T4AKAQq0Ig0xBirZYLAvtpjqs=

This is an effort to get rid of all multiplications from allocation
functions in order to prevent integer overflows [1].

Here the multiplication is obviously safe because DMAR_LATENCY_NUM
is the number of latency types defined in the "latency_type" enum.

enum latency_type {
	DMAR_LATENCY_INV_IOTLB =3D 0,
	DMAR_LATENCY_INV_DEVTLB,
	DMAR_LATENCY_INV_IEC,
	DMAR_LATENCY_PRQ,
	DMAR_LATENCY_NUM
};

However, using kcalloc() is more appropriate [2] and improves
readability. This patch has no effect on runtime behavior.

Link: https://github.com/KSPP/linux/issues/162 [1]
Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-co=
ded-arithmetic-in-allocator-arguments [2]
Signed-off-by: Erick Archer <erick.archer@gmx.com>
=2D--
 drivers/iommu/intel/perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/intel/perf.c b/drivers/iommu/intel/perf.c
index 94ee70ac38e3..adc4de6bbd88 100644
=2D-- a/drivers/iommu/intel/perf.c
+++ b/drivers/iommu/intel/perf.c
@@ -33,7 +33,7 @@ int dmar_latency_enable(struct intel_iommu *iommu, enum =
latency_type type)

 	spin_lock_irqsave(&latency_lock, flags);
 	if (!iommu->perf_statistic) {
-		iommu->perf_statistic =3D kzalloc(sizeof(*lstat) * DMAR_LATENCY_NUM,
+		iommu->perf_statistic =3D kcalloc(DMAR_LATENCY_NUM, sizeof(*lstat),
 						GFP_ATOMIC);
 		if (!iommu->perf_statistic) {
 			ret =3D -ENOMEM;
=2D-
2.25.1