Received-SPF: pass (google.com: domain of linux-kernel+bounces-60909-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
To: Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com"
	<edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Sunil Kovvuri Goutham
	<sgoutham@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Geethasowjanya
 Akula <gakula@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Naveen
 Mamindlapalli <naveenm@marvell.com>,
        "horms@kernel.org" <horms@kernel.org>
Subject: RE: [PATCH 1/2] octeontx2-af: Remove the PF_FUNC validation for NPC
 transmit rules
Thread-Topic: [PATCH 1/2] octeontx2-af: Remove the PF_FUNC validation for NPC
 transmit rules
Thread-Index: AQHaXRlApo3qAicmJUy+rFKKud0sSrEFerrg
Date: Sun, 11 Feb 2024 18:46:40 +0000
Message-ID: 
 <CO1PR18MB466623157B4EE9B2C04119E4A1492@CO1PR18MB4666.namprd18.prod.outlook.com>
References: <1707676587-12711-1-git-send-email-sbhatta@marvell.com>
In-Reply-To: <1707676587-12711-1-git-send-email-sbhatta@marvell.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?KOwnhDJcXIK4k3Wt5JxYg68OISMRWiWm6660Eqz+oi6GQq/EwQ3IVqV+ARbs?=
 =?us-ascii?Q?Am+ugGu17hBUrUFofrT9jwI1h2SpwoscVr3+q1gT1iAZjO08xHSCXXxtVixk?=
 =?us-ascii?Q?3qoVw1Q2iJMjdpxtrRxpZHeXqwtgdTH7V5KCFpph3niMZCelZIn5LBdFZfeC?=
 =?us-ascii?Q?azBl4SbqFwTvx+pAlCnu3hsSa9uA/FureZWGZd9BI04nyn9Bagw95eeV8i0v?=
 =?us-ascii?Q?HqoMtJ5S7daOzT0Wx7TofFCYXunbJZQ+R8MNb+RUlShWhGidpTKcRJ3AuL2Z?=
 =?us-ascii?Q?GuoK6q8wukuKt0Um6ZCAPc2NCvNYJybrKsZzaLubdaXYHJeLo8f9uirzgXnW?=
 =?us-ascii?Q?UkgmFXtsYZA8LC/OgVWjmbZ8h4FIix/LMQJZ/t7TJUp1kbD8wgtinSuTuZLd?=
 =?us-ascii?Q?I6UdRLCw36dibG0t5+VOBoi2GS4dw7EhMHcaVDES8Y2Ow1CeeEqBgCoz+zis?=
 =?us-ascii?Q?nCljfpearC1+D6ulZEJuB5bG9/yForhaxeVvsIvcutJqsCFp6Sqvv1tHhds+?=
 =?us-ascii?Q?Satmurfl/U8Il0JGSQn+58qlUKBq8gG+HacpEugktzlS+fz71GcRFnHNAZHe?=
 =?us-ascii?Q?HTpSPqTUZKhn+0HlQscTM1AmthQo4OGvCIuaIn/HYINUNl0SdkfmnCrWuFEW?=
 =?us-ascii?Q?GNbZYs/q2pb3Lex8xMTd66d44CFD5bh6+j0WdAEKBseAEmAaT87GhvGGX1MN?=
 =?us-ascii?Q?vg44pfLzuv7it03LwvORuizuO9FqbhqcGardzmNdeRWNaOjpiJE2oTMTJ6H9?=
 =?us-ascii?Q?vLaPiNuezAuaFYc1X0Bln09/FoP7dbJRWdu3kvGsXCpiadHdBL6KFOEIhmUB?=
 =?us-ascii?Q?DyCY/jMR5i99+BEM+oJ1527i+NodRcdNxlHa9o8KiuNmiaODctxqYFbxrxNa?=
 =?us-ascii?Q?H+ZRM4ogHSFDFIMR/4Bw22c/sULJaGwO6BKJE8DhBXIydLETvnWUdDMokArM?=
 =?us-ascii?Q?XhqVgKn3nT0/KD00nKSR7+KiJcE9HlPtvL7L8TkHpZ2lMhcJ1zaU9dOYzSrn?=
 =?us-ascii?Q?ECLs+NZBtgnCDF32m2jtPWpX++D4cX7pwEhadNMPB9J562A00obTojBxOKd5?=
 =?us-ascii?Q?XnEBhXcW2mQ9QQvDdYzBIXridCqqE1bbOts4QpzoZP3Mx/pUZy1UA7LgVdEN?=
 =?us-ascii?Q?lR3iXdp6iekOaQ3GghUk1UmWZu5jEARsVWibetgUXlGr/N+zxOhW/uhBIkzQ?=
 =?us-ascii?Q?iLcAocf4PoidOYgpViEVEDb3PUxIt0e23tio9x/ugRQzW3TMznLyIqxXa5hU?=
 =?us-ascii?Q?uSP5y5YGmvedHYg3dn+XT860CdGES+pjS+5uIiSe7j69LHgDc3me3/CqB2mL?=
 =?us-ascii?Q?Y8RuEg0qyguiEKawtNP0XkLxw1u5w+vzIJ7dmwH9tM/dNCohFqu/iCUO6g2i?=
 =?us-ascii?Q?fZ4vtFhU8iTUEeZPHEtvmD7ZLk1Dmn83BSz1j5FsbbOzj0asJI4/1GuI+a4E?=
 =?us-ascii?Q?0qC5P3QIzZSMBq0U6A7KFzT+jMY96IrqUf4dSFmTO3BcXtddNlrkza4XpNVB?=
 =?us-ascii?Q?DOSaM79s3f+EsmG06UzBpbAnnNAvGSCndDC+nnuCUW+0VrJETlIM7M28hOoK?=
 =?us-ascii?Q?J58TzzAJgAE3RTV9hB8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4666.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3f81fe9-35e5-48c6-cf16-08dc2b31c950
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2024 18:46:41.0281
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: o+kNo7DeU09d3jUx5TWhrqQbxyM75nV8EUj+B9i2705U4A1r720d891zkeMbFq8xU06mGD/KXo0OrW3GIZTuNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR18MB4249
X-Proofpoint-ORIG-GUID: 6bTZN9s99v44a1sAQItQoU-wvBxYFLnj
X-Proofpoint-GUID: 6bTZN9s99v44a1sAQItQoU-wvBxYFLnj
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-11_17,2024-02-08_01,2023-05-22_02

Hi,

Please ignore this patch. My bad this is single patch but sent as 1/2.

Thanks,
Sundeep

>-----Original Message-----
>From: Subbaraya Sundeep <sbhatta@marvell.com>
>Sent: Monday, February 12, 2024 12:06 AM
>To: netdev@vger.kernel.org; linux-kernel@vger.kernel.org
>Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
>pabeni@redhat.com; Sunil Kovvuri Goutham <sgoutham@marvell.com>; Linu
>Cherian <lcherian@marvell.com>; Geethasowjanya Akula <gakula@marvell.com>;
>Hariprasad Kelam <hkelam@marvell.com>; Naveen Mamindlapalli
><naveenm@marvell.com>; horms@kernel.org; Subbaraya Sundeep Bhatta
><sbhatta@marvell.com>
>Subject: [PATCH 1/2] octeontx2-af: Remove the PF_FUNC validation for NPC
>transmit rules
>
>NPC transmit side mcam rules can use the pcifunc of transmitting
>device for mcam lookup. The commit 18603683d766 ("octeontx2-af: Remove
>channel verification while installing MCAM rules") removed the receive
>side channel verification to save hardware MCAM filters while switching
>packets across interfaces but missed removing transmit side checks.
>This patch removes transmit side rules validation.
>
>Fixes: 18603683d766 ("octeontx2-af: Remove channel verification while inst=
alling
>MCAM rules")
>Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
>---
> .../net/ethernet/marvell/octeontx2/af/rvu_npc.c    | 32 -----------------=
-----
> 1 file changed, 32 deletions(-)
>
>diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
>b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
>index 8cfd74a..e5d6156 100644
>--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
>+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
>@@ -61,28 +61,6 @@ int rvu_npc_get_tx_nibble_cfg(struct rvu *rvu, u64
>nibble_ena)
> 	return 0;
> }
>
>-static int npc_mcam_verify_pf_func(struct rvu *rvu,
>-				   struct mcam_entry *entry_data, u8 intf,
>-				   u16 pcifunc)
>-{
>-	u16 pf_func, pf_func_mask;
>-
>-	if (is_npc_intf_rx(intf))
>-		return 0;
>-
>-	pf_func_mask =3D (entry_data->kw_mask[0] >> 32) &
>-		NPC_KEX_PF_FUNC_MASK;
>-	pf_func =3D (entry_data->kw[0] >> 32) & NPC_KEX_PF_FUNC_MASK;
>-
>-	pf_func =3D be16_to_cpu((__force __be16)pf_func);
>-	if (pf_func_mask !=3D NPC_KEX_PF_FUNC_MASK ||
>-	    ((pf_func & ~RVU_PFVF_FUNC_MASK) !=3D
>-	     (pcifunc & ~RVU_PFVF_FUNC_MASK)))
>-		return -EINVAL;
>-
>-	return 0;
>-}
>-
> void rvu_npc_set_pkind(struct rvu *rvu, int pkind, struct rvu_pfvf *pfvf)
> {
> 	int blkaddr;
>@@ -2851,12 +2829,6 @@ int rvu_mbox_handler_npc_mcam_write_entry(struct
>rvu *rvu,
> 	else
> 		nix_intf =3D pfvf->nix_rx_intf;
>
>-	if (!is_pffunc_af(pcifunc) &&
>-	    npc_mcam_verify_pf_func(rvu, &req->entry_data, req->intf, pcifunc)) =
{
>-		rc =3D NPC_MCAM_INVALID_REQ;
>-		goto exit;
>-	}
>-
> 	/* For AF installed rules, the nix_intf should be set to target NIX */
> 	if (is_pffunc_af(req->hdr.pcifunc))
> 		nix_intf =3D req->intf;
>@@ -3208,10 +3180,6 @@ int
>rvu_mbox_handler_npc_mcam_alloc_and_write_entry(struct rvu *rvu,
> 	if (!is_npc_interface_valid(rvu, req->intf))
> 		return NPC_MCAM_INVALID_REQ;
>
>-	if (npc_mcam_verify_pf_func(rvu, &req->entry_data, req->intf,
>-				    req->hdr.pcifunc))
>-		return NPC_MCAM_INVALID_REQ;
>-
> 	/* Try to allocate a MCAM entry */
> 	entry_req.hdr.pcifunc =3D req->hdr.pcifunc;
> 	entry_req.contig =3D true;
>--
>2.7.4