Subject: Re: list corruption on ib_srp load in v2.6.24-rc5
From: Dave Dillow <dave@thedillows.org>
To: FUJITA Tomonori <tomof@acm.org>
Cc: linux-kernel@vger.kernel.org, general@lists.openfabrics.org, pw@osc.edu,
       fujita.tomonori@lab.ntt.co.jp
In-Reply-To: <20071223014407L.tomof@acm.org>
References: <1198273973.9979.34.camel@lap75545.ornl.gov>
	 <1198275532.9979.43.camel@lap75545.ornl.gov>
	 <20071223014407L.tomof@acm.org>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Date: Sat, 22 Dec 2007 12:32:48 -0500
Message-Id: <1198344768.10564.1.camel@obelisk.thedillows.org>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1096
Lines: 30

On Sun, 2007-12-23 at 01:41 +0900, FUJITA Tomonori wrote:
> I think that as Pete pointed out, srp_remove_one needs to call
> srp_remove_host.
> 
> Can you try this?

If I need to escape family during the holidays, I'll test it from home.
Otherwise I'll be able to test on Wednesday.

Thanks for the patch,
Dave

> diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
> index 950228f..bdb6f85 100644
> --- a/drivers/infiniband/ulp/srp/ib_srp.c
> +++ b/drivers/infiniband/ulp/srp/ib_srp.c
> @@ -2053,6 +2053,7 @@ static void srp_remove_one(struct ib_device *device)
>  
>  		list_for_each_entry_safe(target, tmp_target,
>  					 &host->target_list, list) {
> +			srp_remove_host(target->scsi_host);
>  			scsi_remove_host(target->scsi_host);
>  			srp_disconnect_target(target);
>  			ib_destroy_cm_id(target->cm_id);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/