Received-SPF: pass (google.com: domain of linux-kernel+bounces-61025-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 12 Feb 2024 00:52:10 +0100
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Andrew Davis <afd@ti.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>, 
	Cristian Ciocaltea <cristian.ciocaltea@gmail.com>, Florian Fainelli <florian.fainelli@broadcom.com>, 
	Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, 
	Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, 
	Sean Wang <sean.wang@mediatek.com>, Matthias Brugger <matthias.bgg@gmail.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-actions@lists.infradead.org, linux-arm-msm@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v3 18/19] power: reset: syscon-poweroff: Move device data
 into a struct
Message-ID: <glaiaikudbtuahnwnqoduretcnmrpb7lg2gerlnntcltrjfcko@4vgjb4v66rad>
References: <20240208170410.67975-1-afd@ti.com>
 <20240208170410.67975-19-afd@ti.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="kaire7t4f3nkubt5"
Content-Disposition: inline
In-Reply-To: <20240208170410.67975-19-afd@ti.com>


--kaire7t4f3nkubt5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Andrew,

On Thu, Feb 08, 2024 at 11:04:09AM -0600, Andrew Davis wrote:
> Currently all these device data elements are top level global variables.
> Move these into a struct. This will be used in the next patch when
> the global variable usage is removed. Doing this in two steps makes
> the patches easier to read.
>=20
> Signed-off-by: Andrew Davis <afd@ti.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collab=
ora.com>
> ---
>  drivers/power/reset/syscon-poweroff.c | 36 +++++++++++++++------------
>  1 file changed, 20 insertions(+), 16 deletions(-)
>=20
> diff --git a/drivers/power/reset/syscon-poweroff.c b/drivers/power/reset/=
syscon-poweroff.c
> index 1b2ce7734260c..4899a019256e8 100644
> --- a/drivers/power/reset/syscon-poweroff.c
> +++ b/drivers/power/reset/syscon-poweroff.c
> @@ -15,15 +15,19 @@
>  #include <linux/pm.h>
>  #include <linux/regmap.h>
> =20
> -static struct regmap *map;
> -static u32 offset;
> -static u32 value;
> -static u32 mask;
> +struct syscon_poweroff_data {
> +	struct regmap *map;
> +	u32 offset;
> +	u32 value;
> +	u32 mask;
> +};
> +
> +static struct syscon_poweroff_data *data;

This patch is broken without the follow-up patch, since data is
never allocated. You need to move the memory allocation from the
next patch to this one.

Greetings,

-- Sebastian

--kaire7t4f3nkubt5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmXJXaIACgkQ2O7X88g7
+pqWHw//YjP5WDl7ANWk9IYw2vdEU3+QH1H7FGbUoqOS9I3NQYsyulnSSNcpgNPR
cjcrY/JjHY1YgnpjYOpTVZo7wA3IiBcEs/cW27nmZPAChYMMxjpxSqFHFAJHziP5
TAbPTHQVwEXT8/UVC5+SH4lJpTu3TvEdd5dvDfwDxndhtZN4LD4sfi4sicqZqPXT
o7z1rrkiTsrxG7bPlOkwSYDJMHda4vRThjNCViOMNGZvVXCv9xl8wLZakhCzG0Kq
yLmeSZlrAHd9hliX3lGOGJVrCEGpURn1qmXIJcKHKsbhX9FJwtC4R5BJYRQ6lVYs
rLIrMAaomMFfys+1qKV9JaJQRzcsjmWLhS1jjZSuAgbXNdwEWti+lzkTZHUedIM7
eSTFGlRWQehHEt6ScfZYS5ng6hjpw6VOPJpeXfocH/06HKbHFal8AHgVRNxnq/m1
dvTON6w0wbbMOuZD99CbIdSbSM7b6fVEHuipwiVC7ma0+1q/SUTC9wdcP6EHlCUm
oMqCuNcfTlmPuyV2XDN2Z/gcZukKdgsS0nxf9G1rennT0ksQAVyhOsz/RhjtTHEP
Y36rClmKr7j81XO4fu37OCnEX6qGff/EYnV5M2d5Dx/Qog/dbcUQ+VsezYtnx5uH
+cQcEKfBdCmbqY2EmZZaM/0y/r7Ch0AETaeS9bKv30yNqsH4Dhc=
=X1uU
-----END PGP SIGNATURE-----

--kaire7t4f3nkubt5--