Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2185977rdb; Sun, 11 Feb 2024 16:09:03 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWZen+uZasyJRJham52AlA4PRJRr+aNv82ZWGS8vlWb2OU8VF193/YiQ48IGM1KDrp0E4Gd9BIULvPmF+H3ed3Owfg3qGIj/1exhQn/7Q== X-Google-Smtp-Source: AGHT+IHHDW1lL53IZL/ynUfpc/TyX871WRUQL2zRuLJuVm/5S/qwqMKkTAtrtI/3s0EvXmG47gwF X-Received: by 2002:a9d:7854:0:b0:6e2:e0d3:aa6 with SMTP id c20-20020a9d7854000000b006e2e0d30aa6mr2346989otm.30.1707696543151; Sun, 11 Feb 2024 16:09:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707696543; cv=pass; d=google.com; s=arc-20160816; b=HEnBMhoN6Zhe6/P5LVr0j6OUFbg0hVumVzcK7bJpIaGQ5X+UybMUyVFz3Pm3CFDDWN tgZMtVEkFJH9vxnP5g/FAsn7/WBN2Bfj40ZoBl8ka2oNmBBYYrrb+nFloEnHigIohdsM wkas8GMFXIgyl0XyVzjBW9PsnHuqX62sOqSse5StC7gZYm0ZZOXqQry6jn7LwrUJ8M4I 9Xq+bbz4FxXH8ag+lc6CdSPjCX5P4mjmdhNZleC+5fL3GuaiMdm1qjmvoc84w3U1aAyj PTV7De/8JSeEtqdX73MvsneF8rxzVwnp7ViaWq6OQuWURlRp+DY+w9lUaTQw4y3H+2yM Uu2A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:organization:references :in-reply-to:message-id:subject:cc:to:from:date; bh=K6Kf1B7DEs6YHaarcJNh3Bcxaiec7kaSwpYi2e+mo2Y=; fh=sStrA4/SjAg4MLztFiJ2xBBFFqgaz1UJurU2kmSXL+s=; b=WEM+kEtC8ue+/rFvb3KSIsrcasv8VzOsDIuUxSZEFroShr90wHZjmwt9VzCMyj22t5 HQ4DL1awEwE3d8dFRHIe1rYiwNLjaemsMGqd/6s0ZpqobgaSu4XGFhsa83z3iLJNBJqc y6+mQdzHPpr1envoWm+v4zNnJe9BFyR4zShY5Fk9nhl2t3ifJQ5KbHB1oVyyYTO/i97F +wUTeZbiGgkupKMCvv1Sp+joZzJsZR3A2Cqf57c0W5F2Uo4xg3Y54Ip87lgZyXmgVkoK Djghp/4XDUNr20nsbu0lyv/ahs+2k+jVRHPLHBCMwiC3GdlXPh/Eow3KBzXOzJawPeNn 6wdw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-61030-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61030-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com X-Forwarded-Encrypted: i=2; AJvYcCXFqxCr3ntLwGSoVRJ0ZjqJPQhjZIwRgm/LYnUrLLymgz3KJP9NOaT0oe6yf1nRkMoh/NOQp8KyJGzCmZsg9lDfsA//nnjAZhQjdC6eXw== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id f10-20020ac86eca000000b0042c6b42b029si3497644qtv.349.2024.02.11.16.09.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Feb 2024 16:09:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-61030-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-61030-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61030-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E2B801C20A14 for ; Mon, 12 Feb 2024 00:09:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A9485A3D; Mon, 12 Feb 2024 00:08:54 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B4B2D368; Mon, 12 Feb 2024 00:08:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707696534; cv=none; b=VyZeCK4MzIg1AV/4b0Td7F1Vhkbvh4fqlqJtjppq+xQZ1BmvCTL3p1Q5PlHQ1u5nknP0Y2UtEjJeJPUGSKElGtz2eEqmJU0eu+ml55GPaGw2mnS8KCWlryHRdT99k2+3g2+Ee3YlECGyjP02tjhL7vF6kpHIbSAd4/smfJEY1iM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707696534; c=relaxed/simple; bh=aZrV4SDAhZ2GYilzh8Xv+nGrKhDFhsjF5dRvA9nvciM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hebJU7Yyg6d6UuE4PxhbkKsNdyxycYPPrzDJ8sxfd/f1JdB9H+pLICWzpW/74YRl553uK0mdiVmQO1UzwkNRRV9A99DVb+CNmhGD8/hOVnRu5/pMqB8DUFePVvMo7ditK9bboqk5tBZqc9M3Lvwaq6pW6hflNkX7fToMa8JLSdE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B651DA7; Sun, 11 Feb 2024 16:09:29 -0800 (PST) Received: from minigeek.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8DA6B3F5A1; Sun, 11 Feb 2024 16:08:45 -0800 (PST) Date: Mon, 12 Feb 2024 00:07:27 +0000 From: Andre Przywara To: Andrey Skvortsov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Arnaud Ferraris , Alexey Klimov , Daniel Lezcano Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add thermal trip points for GPU Message-ID: <20240212000727.4690bdb6@minigeek.lan> In-Reply-To: References: <20240211105326.506049-1-andrej.skvortzov@gmail.com> <20240211125209.15d58462@minigeek.lan> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 11 Feb 2024 17:24:19 +0300 Andrey Skvortsov wrote: Hi Andrey, > Hi Andre, > > On 24-02-11 12:52, Andre Przywara wrote: > > On Sun, 11 Feb 2024 13:53:26 +0300 > > Andrey Skvortsov wrote: > > > > Hi Andrey, > > > > > From: Alexey Klimov > > > > > > Without trip points for GPU, the following errors are printed in the > > > dmesg log and the sun8i-thermal driver fails to load: > > > > So how does that post differ from Alexey one's a few weeks back: > > https://lore.kernel.org/linux-arm-kernel/20240101000008.65747-1-alexey.klimov@linaro.org/ > > It seems like the same patch? > > Yes, it's the same patch. I've added only information about failed > dtbs_check errors in already supported boards to commit message. > I've found this patch from June 2023 without any feedback. [1] Since I've > worked on dts changes for PinePhone A64, I've decided to resend > it. Sorry, I wasn't aware that Alexey resent it in the mean time. No worries, that's fine, thanks for the explanation. > It's better to continue discussion in original Alexey's patch. Will Alexey have time to reply and resend? If not, or if you are not sure (it's been a while), it's fine to take over this series, and send a v2, by yourself. If you can just explicitly state that the GPU trip point values are copied from the CPU ones (because they share a die), I am happy as far as my comment is concerned. This is arguably somewhat mentioned in the commit message already, but I missed it on the first read, so would like to see this more prominently stated. As mentioned before, and also stated by Jernej, consider this patch purely device-specific, not related to any Linux behaviour, and give rationale only based on the binding, which requires trip points. Something simple as "The DT binding requires trip points, and dt-validate complains about them missing for any A64 boards." should suffice. Thanks, Andre > > And Jernej and I had some comments (no mentioning of "Linux" in commit > > message, add cooling maps, source of trip temperature values), can you > > please try to address them? > > > > > > > thermal_sys: Failed to find 'trips' node > > > thermal_sys: Failed to find trip points for thermal-sensor id=1 > > > sun8i-thermal: probe of 1c25000.thermal-sensor failed with error -22 > > > > I think it's pretty obvious that the trip points are missing when they > > shouldn't, so this does not need too much explanation or rationale in > > the commit message, so you can cut this short. > > > > > When thermal zones are defined, trip points definitions are mandatory. > > > Trip values for the GPU are assumed to be the same values as the CPU > > > ones. The available specs do not provide any hints about thermal regimes > > > for the GPU and it seems GPU is implemented on the same die as the CPU. > > > > > > 'make dtbs_check' complains about problem in dts for 18 A64-based boards > > > supported by the kernel: > > > > > > sun50i-a64-pine64.dtb: thermal-zones: gpu0-thermal: 'trips' is a required property > > > from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml# > > > sun50i-a64-pine64.dtb: thermal-zones: gpu1-thermal: 'trips' is a required property > > > from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml# > > > > > > Tested on Pine a64+ and PinePhone 1.2. > > > > > > Cc: Samuel Holland > > > Cc: Jernej Skrabec > > > Cc: Chen-Yu Tsai > > > Cc: Daniel Lezcano > > > Cc: devicetree@vger.kernel.org > > > Signed-off-by: Alexey Klimov > > > Tested-by: Andrey Skvortsov > > > > You would need your Signed-off-by: here, since you send this, even when > > on Alexey's behalf. > > > > Cheers, > > Andre > > > > 1. https://lkml.org/lkml/2023/6/4/416 >